Merge pull request #394 from topcoder-platform/dev

[PROD] - Security fixes & clean up

Author: kkartunov

.nvmrc

@@ -0,0 +1 @@
+v22.13.1

package-lock.json

@@ -7,9 +7,7 @@
     "types": "./types/src/main.d.ts",
     "repository": "https://github.com/topcoder-platform/universal-navigation.git",
     "scripts": {
-        "build:nudge": "APP_BUILD_TARGET=nudge vite build --mode=production",
-        "build:base": "vite build --mode=production && npx rimraf ./types && npm run types",
-        "build": "npm run build:base && npm run build:nudge",
+        "build": "vite build --mode=production && npx rimraf ./types && npm run types",
         "check": "svelte-check --tsconfig ./tsconfig.json",
         "demo:dist": "npx http-server --cors --host local.topcoder-dev.com --port 8083 ./dist",
         "demo:marketing": "npx http-server --host local.topcoder-dev.com --port 8081 ./demo/marketing -P http://local.topcoder-dev.com:8081? -o /",
@@ -21,15 +19,15 @@
         "types": "./node_modules/typescript/bin/tsc -p ./tsconfig.json --declaration --emitDeclarationOnly --outDir types"
     },
     "devDependencies": {
-        "@sveltejs/vite-plugin-svelte": "^1.1.0",
-        "@tsconfig/svelte": "^3.0.0",
-        "sass": "^1.56.1",
-        "svelte": "^3.52.0",
-        "svelte-check": "^2.9.2",
-        "svelte-preprocess": "^4.10.7",
-        "tslib": "^2.4.0",
-        "typescript": "^4.6.4",
-        "vite": "^3.2.3",
-        "vite-plugin-css-injected-by-js": "^2.1.1"
+        "@sveltejs/vite-plugin-svelte": "^3.1.2",
+        "@tsconfig/svelte": "^5.0.6",
+        "sass": "^1.95.0",
+        "svelte": "^4.2.20",
+        "svelte-check": "^4.3.4",
+        "svelte-preprocess": "^6.0.3",
+        "tslib": "^2.8.1",
+        "typescript": "^5.9.3",
+        "vite": "^5.4.21",
+        "vite-plugin-css-injected-by-js": "^3.5.2"
     }
 }

package.json

@@ -2,8 +2,8 @@ import type { AuthUser } from "./auth-user.model"
 import type { ProfileCompletionData } from "./profile-completion.model"
 
 export interface AuthConfig {
-  user: AuthUser
-  profileCompletionData: ProfileCompletionData
+  user?: AuthUser
+  profileCompletionData?: ProfileCompletionData
   autoFetchUser?: boolean
   ready: boolean
   signIn: () => void

src/lib/app-context/auth-config.model.ts

@@ -1,4 +1,4 @@
-@import 'lib/styles/fonts.scss';
+@use 'lib/styles/fonts.scss' as *;
 
 .accordionWrap {
   display: flex;

src/lib/components/Accordion.module.scss

@@ -4,8 +4,8 @@
   import { getPublicPath } from 'lib/utils/paths';
   import styles from './Accordion.module.scss';
 
-  export let activeRoute: NavMenuItem = undefined;
-  export let items: NavMenuItem[];
+  export let activeRoute: NavMenuItem | undefined = undefined;
+  export let items: NavMenuItem[] = [];
   export let style: 'primary'|'secondary'|undefined = undefined;
 
   const toggledItems: {[key: string]: boolean} = {};
@@ -42,7 +42,13 @@
             {item.label}
           </a>
           {#if item.children?.length}
-            <span class={styles.itemTrigger} on:click={() => toggleItem(item)} on:keydown={() => {}}>
+            <span
+              class={styles.itemTrigger}
+              role="button"
+              tabindex="0"
+              on:click={() => toggleItem(item)}
+              on:keydown={(ev) => ev.key === 'Enter' && toggleItem(item)}
+            >
               <img src={iconUrl} alt="^" />
             </span>
           {/if}

src/lib/components/Accordion.svelte

@@ -1,4 +1,4 @@
-@import 'lib/styles/fonts.scss';
+@use 'lib/styles/fonts.scss' as *;
 
 $btnSize: 32px;
 

src/lib/components/Banner.module.scss

@@ -1,4 +1,4 @@
-@import 'lib/styles/fonts.scss';
+@use 'lib/styles/fonts.scss' as *;
 
 .btn {
   all: unset;

src/lib/components/Button.module.scss

@@ -11,7 +11,7 @@
   export let variant: ButtonVariant = ''
   export let disabled: boolean = false;
   export let size: 'sm'|'md'|'md-0' = 'sm';
-  export let ref: HTMLElement = null;
+  export let ref: HTMLElement | null = null;
 
 </script>
 

src/lib/components/Button.svelte

@@ -1,4 +1,4 @@
-@import 'lib/styles/fonts.scss';
+@use 'lib/styles/fonts.scss' as *;
 
 .linksMenuWrap {
   display: flex;