Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to HypothesisTests.jl? #1

Open
azev77 opened this issue Nov 23, 2020 · 3 comments
Open

Port to HypothesisTests.jl? #1

azev77 opened this issue Nov 23, 2020 · 3 comments

Comments

@azev77
Copy link

azev77 commented Nov 23, 2020

Hi @torfjelde and thanks for this package!
Is there a chance you can port this to HypothesisTests.jl?
(that way more Julia users can discover & use this)

@torfjelde
Copy link
Owner

Hey @azev77 !
So both this and the WeibullCount.jl package (ref: torfjelde/WeibullCount.jl#1) are really not something I would suggest using 😕

These two packages are essentially the very first thing I did in Julia, in an attempt to learn the language. Let's just say the quality of these packages isn't something I'm particularly proud of:) So if I were to do something like that, it would have to be rewrites of the current packages.

A rewrite of the WeibullCount.jl package is very far down on my TODO-list as this is not something I need anymore, so there's only two ways this gets rewritten: a) I just really want to some random night, or b) a lot of people really want it. For now none of those have happened.

Now this package, KernelGoodnessOfFit.jl, is also something that's far down on my TODO-list but much more likely that I'll get around to at some point. Now that we have proper packages for kernel functions in Julia, etc., I've been wanting to do this for a while. But again, it's a time-issue as I have a lot of other responsibilities at the moment.

TL;DR: WeibullCount.jl is probably not going to be fixed/contributed to anything, but KernelGoodnessOfFit.jl definitively will at some point. Sorry 😕

With that being said, if you're interested in contributing to either yourself, I'd be happy to try and help where I can:)

@azev77
Copy link
Author

azev77 commented Nov 24, 2020

Sounds good @torfjelde.
In general whenever I see a probability distribution or hypothesis test floating around I always suggest the author contribute it to the major repo...

@torfjelde
Copy link
Owner

Good initiative:) If they didn't require a huge rewrite, this indeed would have been a reminder to do so. I'll leave this issue open though, as a reminder that I need to do this at some point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants