Skip to content

Commit 6f7e33e

Browse files
Resolving PR comment
1 parent 04f4a4a commit 6f7e33e

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

android/src/main/java/com/reactnativewebbrowser/CustomTabsActivitiesHelper.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ interface CustomTabsActivitiesHelper {
1414

1515
val defaultCustomTabsResolvingActivity: String?
1616

17-
fun startCustomTabs(intent: Intent, url: Uri?)
17+
fun startCustomTabs(intent: Intent)
1818

1919
fun canResolveIntent(intent: Intent): Boolean
2020
}

android/src/main/java/com/reactnativewebbrowser/InternalCustomTabsActivitiesHelper.kt

+2-1
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,11 @@ class InternalCustomTabsActivitiesHelper(val activityProvider: ActivityProvider)
5656
return getResolvingActivities(intent).isNotEmpty()
5757
}
5858

59-
override fun startCustomTabs(intent: Intent, url: Uri?) {
59+
override fun startCustomTabs(intent: Intent) {
6060
val defaultBrowser = currentActivity.getDefaultBrowser()
6161
val customTabsBrowsers = currentActivity.getCustomTabsBrowsers()
6262

63+
val url = intent.data
6364
if (customTabsBrowsers.contains(defaultBrowser)) {
6465
val customTabs = CustomTabsIntent.Builder().build()
6566
customTabs.intent.setPackage(defaultBrowser)

android/src/main/java/com/reactnativewebbrowser/NativeWebBrowserModule.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ class NativeWebBrowserModule(reactContext: ReactApplicationContext) :
166166
intent.data = Uri.parse(url)
167167
try {
168168
if (customTabsActivitiesHelper.canResolveIntent(intent)) {
169-
customTabsActivitiesHelper.startCustomTabs(intent, Uri.parse(url))
169+
customTabsActivitiesHelper.startCustomTabs(intent)
170170
val result = Arguments.createMap()
171171
result.putString("type", "opened")
172172
promise.resolve(result)

0 commit comments

Comments
 (0)