Skip to content

Commit 4cc6516

Browse files
committed
Fix support for 2024.1
Signed-off-by: Bernát Gábor <[email protected]>
1 parent cb9bdee commit 4cc6516

File tree

9 files changed

+25
-38
lines changed

9 files changed

+25
-38
lines changed

.github/workflows/check.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
- cron: "0 8 * * *"
77

88
concurrency:
9-
group: ${{ github.workflow }}-${{ github.ref }}
9+
group: "${{ github.workflow }}-${{ github.ref }}"
1010
cancel-in-progress: true
1111

1212
jobs:
@@ -17,7 +17,7 @@ jobs:
1717
- uses: actions/setup-java@v4
1818
with:
1919
distribution: temurin
20-
java-version: 11
20+
java-version: 17
2121

2222
- name: Setup Gradle
2323
uses: gradle/gradle-build-action@v3

.github/workflows/publish.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
- uses: actions/setup-java@v4
1111
with:
1212
distribution: temurin
13-
java-version: 11
13+
java-version: 17
1414

1515
- name: Setup Gradle
1616
uses: gradle/gradle-build-action@v3

CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
# PyVenvManage Changelog
44

5+
## [1.4.0]
6+
### Fixed
7+
- Fix support for 2024.1
8+
-
59
## [1.3.4]
610
### Fixed
711
- Fix support for 2021.3
@@ -32,4 +36,3 @@
3236
### Changed
3337
- change items
3438
-->
35-

build.gradle.kts

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,24 +5,24 @@ import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
55

66
plugins {
77
id("java")
8-
id("org.jetbrains.kotlin.jvm") version "1.9.10"
9-
id("org.jetbrains.intellij") version "1.16.0"
8+
id("org.jetbrains.kotlin.jvm") version "1.9.23"
9+
id("org.jetbrains.intellij") version "1.17.3"
1010
id("org.jetbrains.changelog") version "1.3.1"
11-
id("io.gitlab.arturbosch.detekt") version "1.23.1"
11+
id("io.gitlab.arturbosch.detekt") version "1.23.6"
1212
id("org.jlleitschuh.gradle.ktlint") version "11.6.1"
1313
}
1414

1515
val pluginGroup: String = "com.github.pyvenvmanage.pyvenv"
1616
val pluginNameG: String = "PyVenv Manage"
17-
val pluginVersion: String = "1.3.10"
18-
val pluginSinceBuild = "211"
17+
val pluginVersion: String = "1.4.0"
18+
val pluginSinceBuild = "241"
1919
val pluginUntilBuild = ""
2020
// https://www.jetbrains.com/idea/download/other.html
21-
val pluginVerifierIdeVersions = "222.4345.14"
21+
val pluginVerifierIdeVersions = "241.14494.240"
2222
val platformType = "IC"
23-
val platformVersion = "2021.1"
23+
val platformVersion = "2024.1"
2424
// PythonCore https://plugins.jetbrains.com/plugin/631-python/versions
25-
var usePlugins = "PythonCore:211.6693.111"
25+
var usePlugins = "PythonCore:241.14494.240"
2626

2727
group = pluginGroup
2828
version = pluginVersion
@@ -37,16 +37,16 @@ dependencies {
3737

3838
tasks {
3939
withType<JavaCompile> {
40-
sourceCompatibility = "11"
41-
targetCompatibility = "11"
40+
sourceCompatibility = "17"
41+
targetCompatibility = "17"
4242
}
4343
listOf("compileKotlin", "compileTestKotlin").forEach {
4444
getByName<KotlinCompile>(it) {
45-
kotlinOptions.jvmTarget = "11"
45+
kotlinOptions.jvmTarget = "17"
4646
}
4747
}
4848
withType<Detekt> {
49-
jvmTarget = "11"
49+
jvmTarget = "17"
5050
reports {
5151
html.required.set(true)
5252
}
@@ -79,7 +79,7 @@ intellij {
7979
}
8080

8181
detekt {
82-
config = files("./detekt-config.yml")
82+
config.setFrom("./detekt-config.yml")
8383
buildUponDefaultConfig = true
8484
}
8585

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip
44
networkTimeout=10000
55
zipStoreBase=GRADLE_USER_HOME
66
zipStorePath=wrapper/dists

src/main/java/com/github/pyvenvmanage/ConfigureModulePythonVenv.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616

1717
public class ConfigureModulePythonVenv extends ConfigurePythonVenv {
1818

19-
private final String POPUP_ITEM_TEXT = "Set module venv for %s";
20-
2119
protected void setInterpreter(Project project, VirtualFile file, String pythonExecutable) {
2220
Sdk sdk = findExistingSdkForExecutable(pythonExecutable, project);
2321
if (sdk == null) {
@@ -41,6 +39,7 @@ public void update(@NotNull AnActionEvent e) {
4139
Project project = e.getProject();
4240
Module module = ProjectFileIndex.getInstance(project).getModuleForFile(file, false);
4341
if (null != module) {
42+
String POPUP_ITEM_TEXT = "Set module venv for %s";
4443
e.getPresentation().setText(String.format(POPUP_ITEM_TEXT, module.getName()));
4544
e.getPresentation().setEnabledAndVisible(true);
4645
return;

src/main/java/com/github/pyvenvmanage/ConfigurePythonVenv.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55

66
package com.github.pyvenvmanage;
77

8-
import com.intellij.notification.Notification;
9-
import com.intellij.notification.NotificationGroup;
108
import com.intellij.notification.NotificationGroupManager;
119
import com.intellij.openapi.actionSystem.AnAction;
1210
import com.intellij.openapi.actionSystem.AnActionEvent;

src/main/java/com/github/pyvenvmanage/VenvIconProvider.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
import com.intellij.openapi.util.Iconable;
1111
import com.intellij.psi.PsiDirectory;
1212
import com.intellij.psi.PsiElement;
13+
import com.jetbrains.python.icons.PythonIcons;
1314
import com.jetbrains.python.sdk.PythonSdkUtil;
14-
import icons.PythonIcons;
1515
import org.jetbrains.annotations.NotNull;
1616
import org.jetbrains.annotations.Nullable;
1717

@@ -28,7 +28,7 @@ public Icon getIcon(@NotNull PsiElement element, int flags) {
2828
final String venvRootPath = ((PsiDirectory) element).getVirtualFile().getPath();
2929
if (PythonSdkUtil.getPythonExecutable(venvRootPath) != null) {
3030
return PythonIcons.Python.Virtualenv;
31-
};
31+
}
3232
}
3333
return null;
3434
}
@@ -40,7 +40,7 @@ public Icon getLayerIcon(@NotNull Iconable element, boolean isLocked) {
4040
final String venvRootPath = ((PsiDirectory) element).getVirtualFile().getPath();
4141
if (PythonSdkUtil.getPythonExecutable(venvRootPath) != null) {
4242
return PythonIcons.Python.Virtualenv;
43-
};
43+
}
4444
}
4545
return null;
4646
}

src/main/java/icons/PyVenvManageIcons.java

Lines changed: 0 additions & 13 deletions
This file was deleted.

0 commit comments

Comments
 (0)