Optionally reuse flows for anti-commuting covers#37
Open
inmzhang wants to merge 4 commits into
Open
Conversation
|
|
A preview of e50278f is uploaded and can be seen here: ✨ https://tqec.github.io/tqecd/pull/37/ ✨ Changes may take a few minutes to propagate. |
HaoTy
reviewed
May 2, 2026
Collaborator
HaoTy
left a comment
HaoTy
left a comment
There was a problem hiding this comment.
Will try to review this PR over the weekend. Once we make the performance improvements to cover finding and the Pauli string, the overhead should be largely mitigated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue is found by one of my colleagues (Weiping Lin).
For the following circuit:
There should be two detectors
DETECTOR rec[-1]andDETECTOR rec[-2]. However,annotate_detectors_automaticallyreturns a single detectorDETECTOR rec[-1] rec[-2]. This is because intqecd/src/tqecd/flow.py
Lines 90 to 93 in 7e47c39
This PR adds an option to reuse the flows for further anticommuting cover opportunities. It's achieved by removing a single flow instead of all the flows each time. Note that it will significantly increase the runtime when this option is on but it enables more opportunities to find complete detectors.