Adding dynamic icons and Address#1474
Open
neuvill wants to merge 2 commits into
Open
Conversation
Member
|
Wait, I thought dynamic icons mean you can upload your own icon. I'm not sure I understand the value of this change. |
Author
Member
|
I don't think simply replacing existing icons make sense. Maybe the motion status can be on the right side of the list, next to ignition and other icons. |
Member
|
Rotating icon on the map also doesn't make sense because we already have a direction indicator. |
Member
|
In general this feature needs much more consideration and discussion before implementing. |
Author
|
Ok I see that, what do you suggest regarding the icons, and what about the address as Device details? |
Member
|
I think address as device details is reasonable. We can do a separate PR just for that. As for icon, I provided some suggestions above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This is a contribution that allows users to choose "Dynamic icons" as an icon and "Address" as a Device details (secondary text):
1- Dynamic icons:
In the device now you can choose Dynamic icon and this allows you to view the stat of the device (moving, idling and parked) directly in the device list or in the map and it changes dynamically depending on the state,
to allow this to work,we need to add a calculated attribute as follows:
Description: Dynamic status
Attribut: dynamicStatus
Expression:
motion ? 'moving' : (ignition ? 'idling' : 'parked')Type: String
2 - Address:
Now the Address can be choose as device details (secondary text), just make sure that Traccar is connected to an unlimited reverse geocoding server and the conf file is correctly configured to always display the address.
PS
I also added the total number of devices in the search bar.