Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Issues with Pause/Resume/Cancel button(s) aria-labels for Screen Reader Users #5623

Open
2 tasks done
krysten7 opened this issue Jan 24, 2025 · 1 comment
Open
2 tasks done
Labels

Comments

@krysten7
Copy link

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

  1. Use a screen reader (e.g., NVDA, JAWS, or VoiceOver) to navigate the Uppy interface.
  2. Add multiple files to the uploader.
  3. Interact with the following buttons:
    • Global Cancel Button (top left corner and bottom right corner).
    • Global Pause/Resume Button (bottom right corner).
    • Single File Cancel Button (top right corner of an individual file).
    • Single File Pause/Resume Button (associated with an individual file).
  4. Observe the aria-label values announced by the screen reader for each button.

Expected behavior

The aria-label for each button should be descriptive and provide sufficient context for screen reader users to understand the purpose of the action.

Specifically:

  • The Global Cancel Button should have an aria-label like "Cancel All" to indicate it applies to all uploads.
  • The Global Pause/Resume Button should have an aria-label like "Pause All" or "Resume All" to indicate it applies to all uploads.
  • The Single File Cancel Button should include the file name in the aria-label, e.g., "Cancel - testFile.jpg."
  • The Single File Pause/Resume Button should include the file name in the aria-label, e.g., "Pause - testFile.jpg" or "Resume - testFile.jpg."

Actual behavior

The aria-label values for the buttons are not descriptive enough, making it difficult for screen reader users to distinguish between global and single-file actions or understand the context of the buttons:

  • The Global Cancel Button has an aria-label of "Cancel," which does not clarify that it applies to all uploads.
  • The Global Pause/Resume Button has an aria-label of "Pause" or "Resume," which does not clarify that it applies to all uploads.
  • The Single File Cancel Button has an aria-label of "Cancel," which does not include the file name and therefore lacks context.
  • The Single File Pause/Resume Button has an aria-label of "Pause" or "Resume," which does not include the file name and therefore lacks context.
@krysten7 krysten7 added the Bug label Jan 24, 2025
@Murderlon
Copy link
Member

Hi, can you make a PR to improve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants