Merge pull request #35 from transprime-research/feat-add-array-search-with-closure-search-using-key-and-value

feat: Fix issues with search result overriding last result

Author: omitobi

src/Traits/ArrayPrefix.php

@@ -88,8 +88,10 @@ public function walkRecursive(callable $callable, $arg = null)
     public function search($needle, bool $strict = true, $default = null)
     {
         if ($needle instanceof \Closure) {
-            return $this->filter(fn($value, $key) => $needle($value, $key))
-                ->keys()
+            return $this
+                ->copy()
+                ->filter(fn($value, $key) => $needle($value, $key))
+                ->keys(false)
                 ->when($this->getWorkableItem(), new self([$default]))
                 ->offsetGet(0);
         }

tests/ArrayPrefixTraitTest.php

@@ -289,8 +289,23 @@ public function testSearch(): void
         $this->assertEquals(
             2,
             arrayed($data)->search(
-                fn($value, $key) => $value === 'c' && $key = 2,
+                fn($value, $key) => $value === 'c' && $key == 2,
             ),
         );
+
+        // Ensure initial result is not overwritten.
+        $arrayed = arrayed($data);
+
+        $searchResult = $arrayed->search(fn($value, $key) => $value === 'c' && $key === 2);
+
+        $this->assertEquals(
+            2,
+            $searchResult,
+        );
+
+        $this->assertEquals(
+            ['a', 'b', 'c', 'd'],
+            $arrayed->result(),
+        );
     }
 }