Skip to content

Really avoid referencing willscott/go-nfs #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2025

Conversation

arielshaqed
Copy link

Go modules are weird.

@arielshaqed
Copy link
Author

Tested with go test ./....

Will pull with 1 approving review unless you tell me not to.

@arielshaqed
Copy link
Author

Also I added

	github.com/treeverse/go-nfs v0.0.4-0.20250720084328-cab01dbb17e8 // indirect

to go.mod on lakeFS-Enterprise and it seems to test & compile (even make everest...), which is probably a nice thing.

Copy link

@yonipeleg33 yonipeleg33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This command returns 0 results:
grep -rnw "willscott/go-nfs[\"/ ].*" .
And for sanity, when running it on master, it finds the same locations that changed in this PR.
So LGTM!

@arielshaqed
Copy link
Author

Thanks!

Pulling and then tagging it at v0.0.4-RC.1.

@arielshaqed arielshaqed merged commit 4c4ef2a into master Jul 20, 2025
@arielshaqed arielshaqed deleted the chore/fix-module-name branch July 20, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants