From 3ab77df379a1b60d214059059f537636a32aac22 Mon Sep 17 00:00:00 2001 From: Evan Carothers Date: Fri, 27 Jan 2017 12:53:24 -0600 Subject: [PATCH] BugFix - removed xdomain_cookie.html hash rewrite which caused errors with back button When browsing a website with the xdomain cookie installed, hitting the back button would load the cached version of the site, which had xdomain_cookie.html#ready as the path for the HTML file, resulting in a JSON decode error when the html iframe page tried to pull the hash_data and do a JSON decode on 'ready' --- dev/xdomain_cookie.html | 2 -- package.json | 2 +- src/xdomain_cookie.html | 2 -- src/xdomain_cookie.js | 2 +- src/xdomain_cookie.min.js | 2 +- 5 files changed, 3 insertions(+), 7 deletions(-) diff --git a/dev/xdomain_cookie.html b/dev/xdomain_cookie.html index 9f03c0c..e275cd4 100644 --- a/dev/xdomain_cookie.html +++ b/dev/xdomain_cookie.html @@ -11,8 +11,6 @@ _iframe_origin = _hash_data.iframe_origin, _debug = _hash_data.debug; - window.location.hash = "#ready"; - function _log(){ if(!_debug) return; arguments[0] = ":XDC_IFR: "+arguments[0]; diff --git a/package.json b/package.json index 003df9d..6a229b7 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "xdomain-cookies", - "version": "1.0.6", + "version": "1.0.7", "repository": { "type": "git", "url": "git+https://github.com/contently/xdomain-cookies" diff --git a/src/xdomain_cookie.html b/src/xdomain_cookie.html index 9f03c0c..e275cd4 100644 --- a/src/xdomain_cookie.html +++ b/src/xdomain_cookie.html @@ -11,8 +11,6 @@ _iframe_origin = _hash_data.iframe_origin, _debug = _hash_data.debug; - window.location.hash = "#ready"; - function _log(){ if(!_debug) return; arguments[0] = ":XDC_IFR: "+arguments[0]; diff --git a/src/xdomain_cookie.js b/src/xdomain_cookie.js index ed1d702..deab213 100644 --- a/src/xdomain_cookie.js +++ b/src/xdomain_cookie.js @@ -1,4 +1,4 @@ -/* Version 1.0.6 xdomain-cookies (http://contently.github.io/xdomain-cookies/) from Contently (https://github.com/contently) */ +/* Version 1.0.7 xdomain-cookies (http://contently.github.io/xdomain-cookies/) from Contently (https://github.com/contently) */ (function(exports) { "use strict"; diff --git a/src/xdomain_cookie.min.js b/src/xdomain_cookie.min.js index c2aef9e..10c4c61 100644 --- a/src/xdomain_cookie.min.js +++ b/src/xdomain_cookie.min.js @@ -1,3 +1,3 @@ -/* Version 1.0.6 xdomain-cookies (http://contently.github.io/xdomain-cookies/) from Contently (https://github.com/contently) */ +/* Version 1.0.7 xdomain-cookies (http://contently.github.io/xdomain-cookies/) from Contently (https://github.com/contently) */ !function(exports){"use strict";var xDomainCookie=function(iframe_path,namespace,xdomain_only,iframe_load_timeout_ms,secure_only,debug){function _log(){_debug&&(arguments[0]=":XDC_PAGE: "+arguments[0],console.log.apply(console,arguments))}function _inbound_postmessage(event){_log("_inbound_postmessage",event.origin,event.data);var origin=event.origin||event.originalEvent.origin;if(iframe_path.substr(0,origin.length)===origin&&"string"==typeof event.data){var data=null;try{data=JSON.parse(event.data)}catch(e){}"object"!=typeof data||data instanceof Array||"msg_type"in data&&"xdsc_read"===data.msg_type&&"namespace"in data&&data.namespace===_namespace&&(_xdomain_cookie_data=data.cookies,_iframe_ready=!0,_fire_pending_callbacks())}}function _iframe_load_error_occured(){_log("_iframe_load_error_occured"),_iframe_load_error=!0,_fire_pending_callbacks()}function _on_iframe_ready_or_error(cb){_callbacks.push(cb),_fire_pending_callbacks()}function _fire_pending_callbacks(){if(_iframe_load_error||_iframe_ready)for(;_callbacks.length>0;)_callbacks.pop()(_iframe_load_error)}function _set_cookie_in_iframe(cookie_name,cookie_value,expires_days){var data={namespace:_namespace,msg_type:"xdsc_write",cookie_name:cookie_name,cookie_val:cookie_value,expires_days:expires_days,secure_only:_secure_only};_log("_set_cookie_in_iframe",data),document.getElementById("xdomain_cookie_"+_id).contentWindow.postMessage(JSON.stringify(data),iframe_path)}function _get_local_cookie(cookie_name){for(var name=cookie_name+"=",ca=document.cookie.split(";"),i=0;i