Skip to content

Commit 00569b7

Browse files
authored
Update CMake configuration to support latest release (#151) (#152)
* Remove 'libopencv' dependencies * Removing 'libcusparseLt.so' it appears a part of the devel image * Updating name of the variabl to presue it's purpose * Remove 'libcusparseLt.so' * Remove 'libopenblas.so.0' from dependency list
1 parent 6fba107 commit 00569b7

File tree

1 file changed

+6
-38
lines changed

1 file changed

+6
-38
lines changed

CMakeLists.txt

Lines changed: 6 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,6 @@ endif() # TRITON_PYTORCH_ENABLE_TORCHTRT
179179
if (CMAKE_HOST_SYSTEM_PROCESSOR MATCHES "aarch64")
180180
set(LIBS_ARCH "aarch64")
181181
set(LIBTORCH_LIBS
182-
"libopenblas.so.0"
183182
"libnvpl_blas_core.so.0"
184183
"libnvpl_blas_ilp64_gomp.so.0"
185184
"libnvpl_blas_ilp64_seq.so.0"
@@ -206,16 +205,7 @@ else()
206205
"libmkl_vml_def.so.1"
207206
)
208207
endif()
209-
set(OPENCV_LIBS
210-
"libopencv_video.so"
211-
"libopencv_videoio.so"
212-
"libopencv_highgui.so"
213-
"libopencv_imgcodecs.so"
214-
"libopencv_imgproc.so"
215-
"libopencv_core.so"
216-
"libopencv_calib3d.so"
217-
"libopencv_flann.so"
218-
"libopencv_features2d.so"
208+
set(TORCHVISION_LIBS
219209
$<IF:$<BOOL:${RHEL_BUILD}>,libjpeg.so.62,libjpeg.so>
220210
$<IF:$<BOOL:${RHEL_BUILD}>,libpng16.so.16,libpng16.so>
221211
)
@@ -231,7 +221,7 @@ if (${TRITON_PYTORCH_DOCKER_BUILD})
231221
OUTPUT
232222
${PT_LIBS}
233223
${LIBTORCH_LIBS}
234-
${OPENCV_LIBS}
224+
${TORCHVISION_LIBS}
235225
LICENSE.pytorch
236226
include/torch
237227
include/torchvision
@@ -248,24 +238,14 @@ if (${TRITON_PYTORCH_DOCKER_BUILD})
248238
COMMAND docker cp pytorch_backend_ptlib:${PY_INSTALL_PATH}/torch/lib/libtorch_cuda_linalg.so libtorch_cuda_linalg.so
249239
COMMAND docker cp pytorch_backend_ptlib:${PY_INSTALL_PATH}/torch/lib/libtorch_global_deps.so libtorch_global_deps.so
250240
COMMAND docker cp pytorch_backend_ptlib:${PY_INSTALL_PATH}/torch/lib/libcaffe2_nvrtc.so libcaffe2_nvrtc.so
251-
# TODO: Revisit when not needed by making it part of cuda base container.
252-
COMMAND docker cp -L pytorch_backend_ptlib:/usr/local/cuda/lib64/libcusparseLt.so libcusparseLt.so;
253241
COMMAND /bin/sh -c "if [ ${TRITON_PYTORCH_ENABLE_TORCHVISION} = 'ON' ]; then if [ ${RHEL_BUILD} = 'ON' ]; then docker cp -a -L pytorch_backend_ptlib:/usr/local/lib64/libtorchvision.so libtorchvision.so; else docker cp -a -L pytorch_backend_ptlib:/usr/local/${LIB_DIR}/libtorchvision.so.1 libtorchvision.so.1; fi; fi"
254242
COMMAND /bin/sh -c "if [ ${TRITON_PYTORCH_ENABLE_TORCHVISION} = 'ON' ]; then docker cp pytorch_backend_ptlib:/opt/pytorch/vision/torchvision/csrc include/torchvision/torchvision; fi"
255243
COMMAND /bin/sh -c "if [ ${TRITON_PYTORCH_ENABLE_TORCHTRT} = 'ON' ]; then docker cp pytorch_backend_ptlib:/usr/local/lib/python3.12/dist-packages/torch_tensorrt/lib/libtorchtrt_runtime.so libtorchtrt_runtime.so; fi"
256244
COMMAND docker cp pytorch_backend_ptlib:${PY_INSTALL_PATH}/torch_tensorrt/bin/torchtrtc torchtrtc || echo "error ignored..." || true
257245
COMMAND docker cp pytorch_backend_ptlib:/opt/pytorch/pytorch/LICENSE LICENSE.pytorch
258246
COMMAND docker cp pytorch_backend_ptlib:${PY_INSTALL_PATH}/torch/include include/torch
259247
COMMAND docker cp pytorch_backend_ptlib:/opt/pytorch/pytorch/torch/csrc/jit/codegen include/torch/torch/csrc/jit/.
260-
COMMAND docker cp -L pytorch_backend_ptlib:/usr/local/${LIB_DIR}/libopencv_videoio.so libopencv_videoio.so
261-
COMMAND docker cp -L pytorch_backend_ptlib:/usr/local/${LIB_DIR}/libopencv_highgui.so libopencv_highgui.so
262-
COMMAND docker cp -L pytorch_backend_ptlib:/usr/local/${LIB_DIR}/libopencv_video.so libopencv_video.so
263-
COMMAND docker cp -L pytorch_backend_ptlib:/usr/local/${LIB_DIR}/libopencv_imgcodecs.so libopencv_imgcodecs.so
264-
COMMAND docker cp -L pytorch_backend_ptlib:/usr/local/${LIB_DIR}/libopencv_imgproc.so libopencv_imgproc.so
265-
COMMAND docker cp -L pytorch_backend_ptlib:/usr/local/${LIB_DIR}/libopencv_core.so libopencv_core.so
266-
COMMAND docker cp -L pytorch_backend_ptlib:/usr/local/${LIB_DIR}/libopencv_calib3d.so libopencv_calib3d.so
267-
COMMAND docker cp -L pytorch_backend_ptlib:/usr/local/${LIB_DIR}/libopencv_features2d.so libopencv_features2d.so
268-
COMMAND docker cp -L pytorch_backend_ptlib:/usr/local/${LIB_DIR}/libopencv_flann.so libopencv_flann.so
248+
269249
COMMAND /bin/sh -c "if [ ${RHEL_BUILD} = 'ON' ]; then docker cp -L pytorch_backend_ptlib:/usr/lib64/libjpeg.so.62 libjpeg.so.62; else docker cp -L pytorch_backend_ptlib:/usr/local/lib/libjpeg.so.62 libjpeg.so.62 && docker cp pytorch_backend_ptlib:/usr/lib/${LIBS_ARCH}-linux-gnu/libjpeg.so.8.2.2 libjpeg.so; fi;"
270250
COMMAND /bin/sh -c "if [ ${RHEL_BUILD} = 'ON' ]; then docker cp -L pytorch_backend_ptlib:/usr/lib64/libpng16.so.16 libpng16.so.16; else docker cp -L pytorch_backend_ptlib:/usr/lib/${LIBS_ARCH}-linux-gnu/libpng16.so libpng16.so; fi;"
271251
COMMAND /bin/sh -c "if [ -f libmkl_def.so.1 ]; then patchelf --add-needed libmkl_gnu_thread.so.1 libmkl_def.so.1; fi"
@@ -283,7 +263,7 @@ if (${TRITON_PYTORCH_DOCKER_BUILD})
283263
COMMENT "Extracting pytorch and torchvision libraries and includes from ${TRITON_PYTORCH_DOCKER_IMAGE}"
284264
VERBATIM
285265
)
286-
add_custom_target(ptlib_target DEPENDS ${PT_LIBS} ${LIBTORCH_LIBS} ${OPENCV_LIBS})
266+
add_custom_target(ptlib_target DEPENDS ${PT_LIBS} ${LIBTORCH_LIBS} ${TORCHVISION_LIBS})
287267
add_library(ptlib SHARED IMPORTED GLOBAL)
288268
add_dependencies(ptlib ptlib_target)
289269

@@ -449,14 +429,13 @@ install(
449429

450430
if (${TRITON_PYTORCH_DOCKER_BUILD})
451431
set(PT_LIB_PATHS "")
452-
FOREACH(plib ${PT_LIBS} ${LIBTORCH_LIBS} ${OPENCV_LIBS})
432+
FOREACH(plib ${PT_LIBS} ${LIBTORCH_LIBS} ${TORCHVISION_LIBS})
453433
set(PT_LIB_PATHS ${PT_LIB_PATHS} "${CMAKE_CURRENT_BINARY_DIR}/${plib}")
454434
ENDFOREACH(plib)
455435

456436
install(
457437
FILES
458438
${PT_LIB_PATHS}
459-
${CMAKE_CURRENT_BINARY_DIR}/libcusparseLt.so
460439
${CMAKE_CURRENT_BINARY_DIR}/LICENSE.pytorch
461440
DESTINATION ${CMAKE_INSTALL_PREFIX}/backends/pytorch
462441
)
@@ -469,7 +448,7 @@ if (${TRITON_PYTORCH_DOCKER_BUILD})
469448
)
470449
endif() # TRITON_PYTORCH_ENABLE_TORCHTRT
471450

472-
FOREACH(plib ${PT_LIBS} ${LIBTORCH_LIBS} ${OPENCV_LIBS})
451+
FOREACH(plib ${PT_LIBS} ${LIBTORCH_LIBS} ${TORCHVISION_LIBS})
473452
install(
474453
CODE
475454
"EXECUTE_PROCESS(
@@ -482,22 +461,11 @@ if (${TRITON_PYTORCH_DOCKER_BUILD})
482461
)
483462
ENDFOREACH(plib)
484463

485-
set(OPENCV_VERSION "406")
486464
install(
487465
CODE
488466
"EXECUTE_PROCESS(
489-
COMMAND ln -sf libopencv_video.so libopencv_video.so.${OPENCV_VERSION}
490-
COMMAND ln -sf libopencv_videoio.so libopencv_videoio.so.${OPENCV_VERSION}
491-
COMMAND ln -sf libopencv_highgui.so libopencv_highgui.so.${OPENCV_VERSION}
492-
COMMAND ln -sf libopencv_imgcodecs.so libopencv_imgcodecs.so.${OPENCV_VERSION}
493-
COMMAND ln -sf libopencv_imgproc.so libopencv_imgproc.so.${OPENCV_VERSION}
494-
COMMAND ln -sf libopencv_core.so libopencv_core.so.${OPENCV_VERSION}
495-
COMMAND ln -sf libopencv_calib3d.so libopencv_calib3d.so.${OPENCV_VERSION}
496-
COMMAND ln -sf libopencv_features2d.so libopencv_features2d.so.${OPENCV_VERSION}
497-
COMMAND ln -sf libopencv_flann.so libopencv_flann.so.${OPENCV_VERSION}
498467
COMMAND ln -sf libpng16.so libpng16.so.16
499468
COMMAND ln -sf libjpeg.so libjpeg.so.8
500-
COMMAND ln -sf libcusparseLt.so libcusparseLt.so.0
501469
RESULT_VARIABLE LINK_STATUS
502470
WORKING_DIRECTORY ${CMAKE_INSTALL_PREFIX}/backends/pytorch)
503471
if(LINK_STATUS AND NOT LINK_STATUS EQUAL 0)

0 commit comments

Comments
 (0)