Skip to content

Commit 19d952c

Browse files
committed
fix conflict
1 parent 81829e0 commit 19d952c

File tree

10 files changed

+39
-861
lines changed

10 files changed

+39
-861
lines changed

src/main/java/org/embulk/output/bigquery_java/BigqueryClient.java.orig

Lines changed: 0 additions & 491 deletions
This file was deleted.

src/main/java/org/embulk/output/bigquery_java/config/BigqueryConfigValidator.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ public class BigqueryConfigValidator {
88
public static void validate(PluginTask task) {
99
validateMode(task);
1010
validateModeAndAutoCreteTable(task);
11+
validateClustering(task);
1112
}
1213

1314
public static void validateMode(PluginTask task) throws ConfigException {

src/main/java/org/embulk/output/bigquery_java/config/BigqueryConfigValidator.java.orig

Lines changed: 0 additions & 36 deletions
This file was deleted.

src/main/java/org/embulk/output/bigquery_java/config/BigqueryConfigValidator.java.rej

Lines changed: 0 additions & 16 deletions
This file was deleted.

src/main/java/org/embulk/output/bigquery_java/config/PluginTask.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,4 +154,8 @@ public interface PluginTask
154154
Optional<BigqueryTimePartitioning> getTimePartitioning();
155155

156156
void setTimePartitioning(Optional<BigqueryTimePartitioning> bigqueryTimePartitioning);
157+
158+
@Config("clustering")
159+
@ConfigDefault("null")
160+
Optional<BigqueryClustering> getClustering();
157161
}

src/main/java/org/embulk/output/bigquery_java/config/PluginTask.java.orig

Lines changed: 0 additions & 157 deletions
This file was deleted.

src/main/java/org/embulk/output/bigquery_java/config/PluginTask.java.rej

Lines changed: 0 additions & 15 deletions
This file was deleted.

src/test/java/org/embulk/output/bigquery_java/config/TestBigqueryTaskBuilder.java

Lines changed: 34 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package org.embulk.output.bigquery_java.config;
22

3+
import com.google.common.io.Resources;
4+
import org.embulk.config.ConfigException;
35
import org.embulk.config.ConfigSource;
46
import org.embulk.output.bigquery_java.BigqueryJavaOutputPlugin;
57
import org.embulk.spi.OutputPlugin;
@@ -68,7 +70,7 @@ public void setFileExt_JSONL_GZIP_JSONL_GZ() {
6870
"auto_create_table: true",
6971
"path_prefix: /tmp/bq_compress/bq_",
7072
""
71-
)
73+
)
7274
);
7375
PluginTask task = config.loadConfig(PluginTask.class);
7476

@@ -77,4 +79,34 @@ public void setFileExt_JSONL_GZIP_JSONL_GZ() {
7779
assertEquals("GZIP", task.getCompression());
7880
assertEquals(".jsonl.gz", task.getFileExt().get());
7981
}
80-
}
82+
83+
@Test
84+
public void clustering() {
85+
config = embulk.configLoader().fromYamlString(
86+
String.join("\n",
87+
"type: bigquery_java",
88+
"mode: replace",
89+
"auth_method: service_account",
90+
"json_keyfile: json_key.json",
91+
"dataset: dataset",
92+
"table: table",
93+
"source_format: NEWLINE_DELIMITED_JSON",
94+
"compression: GZIP",
95+
"auto_create_dataset: false",
96+
"auto_create_table: true",
97+
"path_prefix: /tmp/bq_compress/bq_",
98+
"clustering:",
99+
" fields:",
100+
" - foo",
101+
" - bar",
102+
" - baz"
103+
)
104+
);
105+
PluginTask task = config.loadConfig(PluginTask.class);
106+
BigqueryTaskBuilder.setAbortOnError(task);
107+
System.out.println(task.getClustering().get().getFields());
108+
List<String> expectedOutput = Arrays.asList("foo", "bar", "baz");
109+
110+
assertEquals(expectedOutput, task.getClustering().get().getFields().get());
111+
}
112+
}

src/test/java/org/embulk/output/bigquery_java/config/TestBigqueryTaskBuilder.java.orig

Lines changed: 0 additions & 47 deletions
This file was deleted.

0 commit comments

Comments
 (0)