Skip to content

Commit f1e0f1b

Browse files
authored
Merge pull request #13 from trocco-io/feature/fix_ci_test
change secrets to vars and add NON_ASCII vars in github workflows
2 parents f9dc1a0 + aea8642 commit f1e0f1b

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

.github/workflows/main.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,15 @@ jobs:
3636
- name: Write test secret to file
3737
run: envsubst < ci/config_template.yml > test-config.yml
3838
env:
39-
SERVER_HOSTNAME: ${{ secrets.TEST_SERVER_HOSTNAME }}
40-
HTTP_PATH: ${{ secrets.TEST_HTTP_PATH }}
39+
SERVER_HOSTNAME: ${{ vars.TEST_SERVER_HOSTNAME }}
40+
HTTP_PATH: ${{ vars.TEST_HTTP_PATH }}
4141
PERSONAL_ACCESS_TOKEN: ${{ secrets.TEST_PERSONAL_ACCESS_TOKEN }}
42-
CATALOG_NAME: ${{ secrets.TEST_CATALOG_NAME }}
43-
SCHEMA_NAME: ${{ secrets.TEST_SCHEMA_NAME }}
44-
TABLE_PREFIX: ${{ secrets.TEST_TABLE_PREFIX }}
45-
STAGING_VOLUME_NAME_PREFIX: ${{ secrets.TEST_STAGING_VOLUME_NAME_PREFIX }}
42+
CATALOG_NAME: ${{ vars.TEST_CATALOG_NAME }}
43+
SCHEMA_NAME: ${{ vars.TEST_SCHEMA_NAME }}
44+
TABLE_PREFIX: ${{ vars.TEST_TABLE_PREFIX }}
45+
NON_ASCII_CATALOG_NAME: ${{ vars.TEST_NON_ASCII_CATALOG_NAME }}
46+
NON_ASCII_SCHEMA_NAME: ${{ vars.TEST_NON_ASCII_SCHEMA_NAME }}
47+
STAGING_VOLUME_NAME_PREFIX: ${{ vars.TEST_STAGING_VOLUME_NAME_PREFIX }}
4648
- run: ./gradlew test
4749
env:
4850
EMBULK_OUTPUT_DATABRICKS_TEST_CONFIG: "./test-config.yml"

ci/config_template.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,6 @@ personal_access_token: "$PERSONAL_ACCESS_TOKEN"
44
catalog_name: "$CATALOG_NAME"
55
schema_name: "$SCHEMA_NAME"
66
table_prefix: "$TABLE_PREFIX"
7+
non_ascii_catalog_name: "$NON_ASCII_CATALOG_NAME"
8+
non_ascii_schema_name: "$NON_ASCII_SCHEMA_NAME"
79
staging_volume_name_prefix: "$STAGING_VOLUME_NAME_PREFIX"

0 commit comments

Comments
 (0)