Skip to content

graph hashmap not getting populated (or multiple instances of service) #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JimFuller-RedHat opened this issue Jan 28, 2025 · 1 comment
Assignees

Comments

@JimFuller-RedHat
Copy link
Collaborator

We seem to be recalculating graph everytime we query api/v2/analysis/root-component (or dep)

in modules/analysis/src/service/load.rs#219:

if self.graph.read().contains_key(distinct_sbom_id) {
    // early return if we already loaded it
   log::warn!("we should return early if this graph is contained in hashmap")
    return;
}

we never get log warning.

@JimFuller-RedHat
Copy link
Collaborator Author

this is fixed by this PR #1217

@ctron ctron closed this as completed Feb 3, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in Trustify Feb 3, 2025
@ptomanRH ptomanRH added this to the RHTPA 2.0.0 milestone Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants