Repository navigation
Commit 6293aad
fix(risk-treatment): rank tasks by exact in-process cosine, not filtered ANN (#3359)
Draft treatment plans returned "0 tasks and 0 controls" because
findSimilarTasks issued a metadata-filtered ANN query (organizationId AND
sourceType = "task") against a single 180k+ vector shared-namespace index.
Upstash applies metadata filters during approximate HNSW traversal, so a
highly selective per-org filter makes the traversal exhaust its candidate
budget on nearer, non-matching vectors before reaching the org's tasks —
returning 0 candidates even at topK=1000 when relevant tasks exist. It gets
worse as the shared index grows.
An org holds at most low-hundreds of tasks, so enumerate the org's task
vectors by their `task_${org}_` id prefix and score them exactly in-process.
This is the right-sized tool at this scale: no recall loss, no data
migration. Controls are derived from the suggested tasks, so restoring task
recall restores both.
Scores use `(1 + cos) / 2` to match Upstash's COSINE score scale, so the
downstream department boost / threshold in linkSuggestions and the reranker's
cosineScore hint are unchanged. Verified end-to-end against production data.
Isolated to findSimilarTasks; the orphan prune and in-scope filtering in
runLinkage are unchanged and still compose correctly.
Fixes CS-681
Claude-Session: https://claude.ai/code/session_014LMSrxyX5U6gz8QZqJAGhc
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 73ece08 commit 6293aad
2 files changed
Lines changed: 201 additions & 44 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
| 36 | + | |
35 | 37 | | |
36 | 38 | | |
37 | 39 | | |
| |||
168 | 170 | | |
169 | 171 | | |
170 | 172 | | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
171 | 193 | | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
176 | 209 | | |
177 | 210 | | |
178 | 211 | | |
| |||
181 | 214 | | |
182 | 215 | | |
183 | 216 | | |
184 | | - | |
| 217 | + | |
| 218 | + | |
185 | 219 | | |
186 | | - | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
187 | 223 | | |
188 | | - | |
189 | 224 | | |
190 | 225 | | |
| 226 | + | |
| 227 | + | |
191 | 228 | | |
192 | | - | |
193 | | - | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
194 | 232 | | |
195 | 233 | | |
196 | 234 | | |
197 | | - | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
198 | 243 | | |
199 | 244 | | |
200 | | - | |
| 245 | + | |
| 246 | + | |
201 | 247 | | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
202 | 277 | | |
| 278 | + | |
203 | 279 | | |
204 | 280 | | |
205 | 281 | | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
206 | 289 | | |
207 | 290 | | |
208 | 291 | | |
209 | 292 | | |
210 | | - | |
211 | | - | |
212 | | - | |
| 293 | + | |
| 294 | + | |
213 | 295 | | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
| 296 | + | |
218 | 297 | | |
219 | | - | |
| 298 | + | |
220 | 299 | | |
221 | 300 | | |
222 | 301 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
64 | 65 | | |
65 | 66 | | |
66 | | - | |
| 67 | + | |
67 | 68 | | |
68 | 69 | | |
69 | 70 | | |
| |||
187 | 188 | | |
188 | 189 | | |
189 | 190 | | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
190 | 262 | | |
191 | 263 | | |
192 | 264 | | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
193 | 275 | | |
194 | 276 | | |
195 | 277 | | |
| |||
203 | 285 | | |
204 | 286 | | |
205 | 287 | | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | | - | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
223 | 301 | | |
224 | 302 | | |
225 | 303 | | |
| |||
267 | 345 | | |
268 | 346 | | |
269 | 347 | | |
270 | | - | |
| 348 | + | |
271 | 349 | | |
272 | 350 | | |
273 | 351 | | |
274 | 352 | | |
275 | | - | |
| 353 | + | |
276 | 354 | | |
277 | 355 | | |
278 | 356 | | |
| |||
292 | 370 | | |
293 | 371 | | |
294 | 372 | | |
295 | | - | |
| 373 | + | |
296 | 374 | | |
297 | 375 | | |
298 | 376 | | |
| |||
0 commit comments