Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the number of persons exceed 9? #59

Open
gscfwid opened this issue Jul 28, 2017 · 3 comments
Open

Can the number of persons exceed 9? #59

gscfwid opened this issue Jul 28, 2017 · 3 comments

Comments

@gscfwid
Copy link

gscfwid commented Jul 28, 2017

This condition is common. But the demo is just for 9 persons.

@tsaiid
Copy link
Owner

tsaiid commented Jul 28, 2017

It probably does, but I have not tried.
The limit of max and min persons is set in the inputPeopleSlider in assets/js/index.js.
A more delicate way may be designing an option page for the users to adjust something by themselves.

@gscfwid
Copy link
Author

gscfwid commented Jul 28, 2017

Ok, I get it. Just set the property of 'max' to whatever you want in the inPutpeopleSlider class. Thank your very much. You really did a great work. But I wonder if I can convert the persons' number to their exact names.

@tsaiid
Copy link
Owner

tsaiid commented Jul 29, 2017

Your suggestion is very good. I have been concerning about customizing the person's name instead of number for a while. However, I don't have much time for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants