Skip to content

Clone cached OBJ materials per instance#937

Open
yanziwei wants to merge 1 commit into
tscircuit:mainfrom
yanziwei:yanziwei/clone-cached-obj-materials
Open

Clone cached OBJ materials per instance#937
yanziwei wants to merge 1 commit into
tscircuit:mainfrom
yanziwei:yanziwei/clone-cached-obj-materials

Conversation

@yanziwei

@yanziwei yanziwei commented Jun 8, 2026

Copy link
Copy Markdown

Summary

/claim #93

  • Adds a scoped clone helper for cached OBJ/WRL models.
  • Reuses cached geometry buffers while cloning materials for each rendered instance.
  • Prevents hover/translucency material mutations from leaking across duplicate cached models.

Validation

  • npx biome check src/hooks/use-global-obj-loader.ts
  • npx tsc --noEmit --pretty false
  • npm run build
  • git diff --check

Note: dependencies were installed with npm install --no-package-lock --legacy-peer-deps for local validation without changing any lockfile.

@vercel

vercel Bot commented Jun 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
3d-viewer Ready Ready Preview, Comment Jun 8, 2026 9:59am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant