Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modalコンポーネントを切り出す #22

Closed
Yosshi999 opened this issue Jun 17, 2021 · 0 comments · Fixed by #25
Closed

Modalコンポーネントを切り出す #22

Yosshi999 opened this issue Jun 17, 2021 · 0 comments · Fixed by #25

Comments

@Yosshi999
Copy link

viewer/front/components/の
AdvancedSearchWindowとConfigureWindowの共通部分をModal componentとして切り出し再利用する

#21 (comment)

このあたりのCSSはConfigureWindowと共通だと思うので、なるべくConfigureWindowと共通してる部分をくくりだしてComponentとして切り出したいですね~ つまり新しいModalみたいなComponentを用意して、

class AdvancedSearchWindow extends React.Component {
  render() {
    return (
      <Modal>
        <いろいろ>
      </Modal>
    );
  }
}

みたいな感じにしたい。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant