Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Jump to..." modal window #25

Merged
merged 3 commits into from
Apr 20, 2022
Merged

"Jump to..." modal window #25

merged 3 commits into from
Apr 20, 2022

Conversation

Yosshi999
Copy link

@Yosshi999 Yosshi999 commented Nov 12, 2021

Close #22

  • Jump to channelの実装。ボタンは配置されていないがCtrl+Kでモーダルが開く
  • モーダルウィンドウの外枠のスタイル、モーダル外を暗くしクリックするとモーダルが閉じる処理を切り出した。
  • Advanced Searchの見た目をちょっと修正
  • dockerignoreの追加。node_modulesなどがdocker contextに入らないように調整

@Yosshi999 Yosshi999 requested a review from hakatashi November 12, 2021 17:27
@Yosshi999 Yosshi999 changed the title implement modal window "Jump to..." modal window Nov 13, 2021
Copy link
Member

@hakatashi hakatashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hakatashi hakatashi merged commit f084495 into master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modalコンポーネントを切り出す
2 participants