Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

謎のホワイトアウト #57

Closed
JP3BGY opened this issue Jul 15, 2024 · 1 comment · Fixed by #59
Closed

謎のホワイトアウト #57

JP3BGY opened this issue Jul 15, 2024 · 1 comment · Fixed by #59
Assignees

Comments

@JP3BGY
Copy link

JP3BGY commented Jul 15, 2024

再現方法(TSGerのみ)
https://slack-log.tsg.ne.jp/C7AAX50QY/1611719683.107300
多分周辺におかしいメッセージがある。

@hakatashi hakatashi self-assigned this Jul 15, 2024
@moratorium08
Copy link

Block KitのSectionに対応する概念である SectionBlock コンポーネントの描画の際に、textが必ず存在していることを仮定しているが、これは誤り。 https://github.com/tsg-ut/slack-patron/blob/master/viewer/front/components/message/Block.js#L163-L176

https://api.slack.com/reference/block-kit/blocks#section

The text for the block, in the form of a text object. Minimum length for the text in this field is 1 and maximum length is 3000 characters. This field is not required if a valid array of fields objects is provided instead.

この描画処理において、textがundefinedの場合には、描画をスキップすると良いと思われる。

    {text && (
      <div className="section-block-text">
        <Text text={text} />
      </div>
    )}

@JP3BGY JP3BGY mentioned this issue Dec 29, 2024
@JP3BGY JP3BGY closed this as completed in 7b32302 Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants