Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #57 #59

Merged
merged 2 commits into from
Dec 30, 2024
Merged

fix #57 #59

merged 2 commits into from
Dec 30, 2024

Conversation

JP3BGY
Copy link

@JP3BGY JP3BGY commented Dec 29, 2024 •
edited
Loading

fix #57

@moratorium08
Copy link

button element、header blockや、fieldsの中のtext object などはtextの存在はrequiredらしいので、必ずしもundefinedかどうかハンドルする必要は無いように思っていたんですが、将来的に仕様変更があったときのためですかね

@JP3BGY
Copy link
Author

JP3BGY commented Dec 30, 2024

デバッグ時に勘違いしてた。

@JP3BGY
Copy link
Author

JP3BGY commented Dec 30, 2024

あと、image blockのtitleがstringじゃなくてtext objectだったのでそこも直した。

moratorium08
moratorium08 approved these changes Dec 30, 2024
View reviewed changes
Copy link

@moratorium08 moratorium08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう

@JP3BGY JP3BGY merged commit 7b32302 into master Dec 30, 2024
@JP3BGY JP3BGY deleted the fix-Text branch December 30, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moratorium08 moratorium08 moratorium08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

謎のホワイトアウト
2 participants
@JP3BGY @moratorium08