Merge pull request #21 from tsgcpp/feature/editor_performance_improvement

Fix and improve StringTableCollectionBundleEditor

Author: tsgcpp

Assets/Plugins/LocalizationExtension/Editor/AssetTool/AssetFinding.cs

@@ -16,6 +16,7 @@ public static IReadOnlyList<T> FindAssetsInFolders<T>(IReadOnlyList<DefaultAsset
             }
 
             var folderPathList = folders
+                .Where(folder => folder != null)
                 .Select(AssetDatabase.GetAssetPath)
                 .Where(path => !string.IsNullOrEmpty(path))
                 .Where(path => Directory.Exists(path))

Assets/Plugins/LocalizationExtension/Editor/Google/StringTableCollection/StringTableCollectionBundle.cs

@@ -18,7 +18,7 @@ public sealed class StringTableCollectionBundle : ScriptableObject, ITargetFolde
 
         [Tooltip("The folders to search for StringTableCollection assets.")]
         [SerializeField] private List<DefaultAsset> _targetFolders;
-        public IReadOnlyList<DefaultAsset> TargetFolders => _targetFolders;
+        public IReadOnlyList<DefaultAsset> TargetFolders => _targetFolders ??= new List<DefaultAsset>();
 
         [Tooltip("Sleep seconds per requests for cool time.")]
         [Min(0f)]

Assets/Plugins/LocalizationExtension/Editor/Google/StringTableCollection/StringTableCollectionBundleEditor.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using System.IO;
 using UnityEngine;
 using UnityEditor;
@@ -14,16 +15,19 @@ public sealed class StringTableCollectionBundleEditor : UnityEditor.Editor
 
         public override void OnInspectorGUI()
         {
-            DrawDefaultInspector();
-            EditorGUILayout.Space(16);
+            using (var changeCheck = new EditorGUI.ChangeCheckScope())
+            {
+                DrawDefaultInspector();
+                EditorGUILayout.Space(16);
 
-            DrawToolsWithSheetsServiceProvider();
-            EditorGUILayout.Space(8);
+                DrawToolsWithSheetsServiceProvider();
+                EditorGUILayout.Space(8);
 
-            DrawToolsWithServiceAccount();
-            EditorGUILayout.Space(8);
+                DrawToolsWithServiceAccount();
+                EditorGUILayout.Space(8);
 
-            DrawStringTableCollections();
+                DrawStringTableCollections(changeCheck.changed);
+            }
         }
 
         private void DrawToolsWithSheetsServiceProvider()
@@ -59,8 +63,9 @@ private void DrawToolsWithServiceAccount()
         }
 
         private bool _showStringTableCollections = true;
+        private IReadOnlyList<StringTableCollection> _stringTableCollectionsCache = new List<StringTableCollection>();
 
-        private void DrawStringTableCollections()
+        private void DrawStringTableCollections(bool guiChanged)
         {
             var foldoutStyle = new GUIStyle(EditorStyles.foldout)
             {
@@ -70,9 +75,15 @@ private void DrawStringTableCollections()
             _showStringTableCollections = EditorGUILayout.Foldout(_showStringTableCollections, "Target \"StringTableCollection\"s", foldoutStyle);
             if (!_showStringTableCollections)
             {
+                _stringTableCollectionsCache = null;
                 return;
             }
 
+            if (_stringTableCollectionsCache == null || guiChanged)
+            {
+                _stringTableCollectionsCache = Bundle.StringTableCollections;
+            }
+
             var stringTableCollections = Bundle.StringTableCollections;
             using var h = new EditorGUILayout.VerticalScope(GUI.skin.box);
             using var g = new EditorGUI.DisabledGroupScope(true);