Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpack Solution does not delete old files in .\package folder & "Output" is incorrect. #4

Open
simes1 opened this issue Mar 9, 2021 · 2 comments
Assignees

Comments

@simes1
Copy link

simes1 commented Mar 9, 2021

I've noticed a couple of things when unpacking solutions with D365DevEx.

  1. What is displayed in the "Output" window is not what D365DevEx does when unpacking a solution:
    image

It actually appears to export the solution to %temp% and unpack to a new folder in %temp% with the same name as the solution file. Then it appears to copy the solution zip to (or wherever you've chosen to store it) the and contents of unpacked solution folder to \package (or wherever you've chosen to store than). Finally (providing it doesn't crash along the way) it then deletes the solution zip and folder in %temp%.

What is in the "Output" window does not achieve the same effect if run manually [filename part of solution file missing, final \package part of extract folder missing and ought to use /allowDelete:Yes (unless it is going to prompt for deletes somehow)]

  1. The copy does not remove files from the target \package folder that are not in the source %temp%<solutionfilename> folder. So if you've removed something from your solution it will still be in source control.

  2. It would also be nice if it remembered the settings for "Enable Solution Packager Log?" and "Store Solution Files?" between sessions.

@tsharp
Copy link
Owner

tsharp commented Apr 13, 2021

I believe that is a feature of the SolutionPackager to retain existing files or to remove before unpacking. I will need to look into this.

@tsharp tsharp self-assigned this Apr 13, 2021
@simes1
Copy link
Author

simes1 commented Apr 13, 2021

As the command line displayed in the Output window doesn't appear to match what is actually being used it's hard to know if the /allowDelete:Yes option is being used. If D365DevEx is copying from %temp%\solutionfilename to .\package (as opposed to this behaviour being some artefact of how the solution packager itself operates) then the copy would also need to delete unwanted files in the .\package folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants