Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning/confirmation before powering off a node #169

Closed
srcshelton opened this issue Jan 11, 2024 · 2 comments
Closed

Add warning/confirmation before powering off a node #169

srcshelton opened this issue Jan 11, 2024 · 2 comments
Labels
UI UI related

Comments

@srcshelton
Copy link

Is your feature request related to a problem? Please describe.

As an end-user of a TP2 system making use of installed nodes for long-running compute tasks,
I would like the certainty of being protected from accidentally powering-off a running node or the wrong node)
in order to minimise any time/work lost if a node is incorrectly powered-down.

Describe the solution you'd like

When the BMC Web UI 'Power' view is used to un-tick a node, there should be some form of confirmation before the power to that node is cut.

Ideally, the ticks on this page would be standard check-box controls, and there would be a separate "Apply" button. On hitting "Apply", a confirmation dialog would be shown confirming what actions will be performed if allowed to continue, as well as giving an option to back-out. This would also allow several nodes to be turned on or off at once.

Describe alternatives you've considered

Alternatively, if a two-stage select-then-apply approach isn't desired, at least a confirmation dialog being shown when powering-down a node would be much safer. Note that confirmation could reasonably be skipping when powering-on a node which is currently off.

@srcshelton
Copy link
Author

(If node monitoring as per #170 is implemented then any warning on attempting to power-cycle a node marked as failed could also skip the confirmation dialog?)

@svenrademakers
Copy link
Collaborator

fixed in e5f6158 and upwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI UI related
Projects
None yet
Development

No branches or pull requests

2 participants