Add entities/stake_pools/v0 namespace and definitions#290
Merged
Conversation
joaosreis
added this to the
Milestone 2 : Developpement of Haskell serialization code milestone
joaosreis
force-pushed
the
joaosreis/entities-stake-pool
branch
3 times, most recently
from
6c1cb78 to
9e3a9e4
Compare
joaosreis
force-pushed
the
joaosreis/entities-stake-pool
branch
from
fd53099 to
4d28898
Compare
joaosreis
force-pushed
the
joaosreis/entities-stake-pool
branch
from
4d28898 to
3658206
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for the new entities/stake_pools/v0 CIP-0165 namespace to the scls-cardano CDDL/spec layer, and wires it into conformance testing and the pinned reference CIPs revision.
Changes:
- Introduce
Cardano.SCLS.Namespace.EntitiesStakePoolsand register it inCardano.SCLS.CDDL(KnownSpec, knownNamespaces, key size). - Extend common CDDL rules with stake-pool-related primitives (
staking_keyhash,relay,pool_metadata, etc.) used by the new namespace. - Update conformance/reference plumbing and bump the pinned
tweag/CIPsrevision (Nix + CI workflow).
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scls-cardano/testlib/Cardano/SCLS/Testlib.hs | Adds the new namespace to the implementor test matrix. |
| scls-cardano/test/Reference.hs | Adds the namespace → reference CDDL filename mapping. |
| scls-cardano/scls-cardano.cabal | Registers the new namespace module in the library build. |
| scls-cardano/cddl-src/Cardano/SCLS/Namespace/EntitiesStakePools.hs | New CDDL rules for the entities/stake_pools/v0 namespace. |
| scls-cardano/cddl-src/Cardano/SCLS/Common.hs | Adds shared stake-pool-related CDDL definitions. |
| scls-cardano/cddl-src/Cardano/SCLS/CDDL.hs | Wires the namespace into KnownSpec/knownNamespaces and sets key size. |
| flake.nix | Bumps pinned tweag/CIPs input revision. |
| flake.lock | Updates lock data for the new tweag/CIPs revision. |
| .github/workflows/haskell-ci.yml | Updates CI checkout ref for the pinned tweag/CIPs revision. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
IntersectMBO/cardano-ledger#5742 is approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.