Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuff exported with __all__ variable should be always public #462

Open
tristanlatr opened this issue Jan 19, 2022 · 1 comment
Open

Stuff exported with __all__ variable should be always public #462

tristanlatr opened this issue Jan 19, 2022 · 1 comment
Labels
astbuilder A substantive change is required in the astbuilder flow in order to fix this issue
Milestone

Comments

@tristanlatr
Copy link
Contributor

Names re-exported by the __all__ variables are public names in Python, even starting with an underscore. To make the submodule _igraph public, just re-rexport it in igraph package in the __all__ variable.

We do not currently support that.

An issue with that approach (that should be supported anyway) is that all public names must be added to the __all__ variable unless python will not import your names when doing a wildcard import.

@tristanlatr tristanlatr added the astbuilder A substantive change is required in the astbuilder flow in order to fix this issue label Feb 6, 2022
@tristanlatr tristanlatr added good first issue and removed astbuilder A substantive change is required in the astbuilder flow in order to fix this issue labels Apr 6, 2022
@tristanlatr tristanlatr added this to the 22.x milestone May 11, 2022
@tristanlatr tristanlatr added astbuilder A substantive change is required in the astbuilder flow in order to fix this issue and removed good first issue labels Jun 1, 2022
@tristanlatr
Copy link
Contributor Author

Does it mean that the names that are not part of the __all__ variable should be considered private ? This would be a breaking change, so I don’t think so.

@tristanlatr tristanlatr modified the milestones: 22.x, 23.x Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astbuilder A substantive change is required in the astbuilder flow in order to fix this issue
Projects
None yet
Development

No branches or pull requests

1 participant