Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSS variables for customizing docs theme colors easily. #520

Open
fabiocaccamo opened this issue Mar 15, 2022 · 4 comments
Open

Use CSS variables for customizing docs theme colors easily. #520

fabiocaccamo opened this issue Mar 15, 2022 · 4 comments
Milestone

Comments

@fabiocaccamo
Copy link

No description provided.

@tristanlatr
Copy link
Contributor

Hi @fabiocaccamo,

Could you write a couple of sentences explaining what is the issue you are facing?

The HTML include variety of css classes already, and customization is definitely possible (see #391).

If you’d like to contribute adding and documenting explicit css class for customization, that would be appreciated. But I’m unsure what are the html components that we should include in scope for such addition.

@fabiocaccamo
Copy link
Author

fabiocaccamo commented Mar 15, 2022

Hello @tristanlatr, sorry for having not explained it before.

This is an enhancement, not a bug/problem.

Looking how to customise the style, I expected to find some CSS variables to override defined all in the same place, instead there are many classes that define the style.

For making a custom theme all the classes should be overridden, this is not the best/modern approach at all.

@tristanlatr
Copy link
Contributor

Ok thanks I get it now.

You're proposing to create CSS variables for all colors used accros the CSS, right ? Is there other stuff that would be worth adding as CSS variable ?

Do you want to work on this ?

@fabiocaccamo
Copy link
Author

Yes, exactly. I think that starting only with colors variables would be already a good thing, other improvements may come in a second step.

If I find some time I will do it.

@tristanlatr tristanlatr added this to the 22.x milestone Apr 10, 2022
@tristanlatr tristanlatr modified the milestones: 22.x, 23.x Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants