Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visit all AST branches #597

Open
tristanlatr opened this issue Jun 2, 2022 · 2 comments
Open

Visit all AST branches #597

tristanlatr opened this issue Jun 2, 2022 · 2 comments
Labels
astbuilder A substantive change is required in the astbuilder flow in order to fix this issue enhancement
Milestone

Comments

@tristanlatr
Copy link
Contributor

#589 fixes the issue regarding the ast.If and ast.Try nodes but it doesn’t for the the ast.For nodes. So anything that is in the else block of a for loop, it won’t be processed. It not a huge issue since for loops typically resides inside function body, and else block does not contain any documentable entries, but it’s still a regression.

Maybe I should just add the to the PR #589

@tristanlatr
Copy link
Contributor Author

Ok, so after some investigations, this behaviour is not a new behaviour and it's been like that forever in pydoctor (more than 16 years).

So the PR #589 is good but totally misguided, because it does not fix an issue, it provides a new feature.

@tristanlatr tristanlatr removed the bug label Jul 13, 2022
@tristanlatr tristanlatr changed the title Fix untested regressions caused by the new node visitor Visit all AST branches Jul 13, 2022
@tristanlatr tristanlatr added the astbuilder A substantive change is required in the astbuilder flow in order to fix this issue label Jul 13, 2022
@tristanlatr tristanlatr added this to the 23.x milestone Oct 1, 2023
@tristanlatr
Copy link
Contributor Author

We’re also missing explicit support for match statements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astbuilder A substantive change is required in the astbuilder flow in order to fix this issue enhancement
Projects
None yet
Development

No branches or pull requests

1 participant