Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on making Encoder/Decoder traits public? #23

Open
rukai opened this issue Jun 7, 2023 · 1 comment
Open

Thoughts on making Encoder/Decoder traits public? #23

rukai opened this issue Jun 7, 2023 · 1 comment

Comments

@rukai
Copy link
Collaborator

rukai commented Jun 7, 2023

I want to reimplement certain encoders/decoders to improve performance by skipping parts I dont need.
It would be nice to be able to reuse some Encoder/Decoder implementations on types like VarInt, but that is currently impossible even though VarInt is public since the Encoder and Decoder traits are private.

Any chance of them being made public?

@rukai
Copy link
Collaborator Author

rukai commented Jun 7, 2023

Hmm I was able to just use other crates for VarInt because its a common encoding: https://docs.rs/integer-encoding/latest/integer_encoding/trait.VarInt.html

So if making them public is a problem for maintainability dont worry about it and just close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant