From adf2af6918ffa0c17a6b399a47f661eb5d391abd Mon Sep 17 00:00:00 2001 From: Cyrannosaurus <70718730+Cyrannosaurus@users.noreply.github.com> Date: Sat, 7 Nov 2020 13:16:22 -0600 Subject: [PATCH 1/3] Fix typo but actually change the whole line I prefer trying to get the student engaged. In this case asking them to explain something then later providing the answer with no penalty. --- f20/p5/README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/f20/p5/README.md b/f20/p5/README.md index 4486892..b075c33 100644 --- a/f20/p5/README.md +++ b/f20/p5/README.md @@ -223,7 +223,9 @@ Yes, those aren't quite real IP addresses, as explained in the next section... ### 2. `country` Command This command has two parts: sorting and adding a new country column. -As explained why lateer, the sorting will come first. + +Can you think of a reason to sort the new column before merging? +**Hint** The zip files are pre-sorted It's OK if you read in the complete CSV, then sort, perhaps something like this: From 2299833e918dfed4a9de6fbd2bc345cc5923e3c9 Mon Sep 17 00:00:00 2001 From: Cyrannosaurus <70718730+Cyrannosaurus@users.noreply.github.com> Date: Sat, 7 Nov 2020 14:45:10 -0600 Subject: [PATCH 2/3] do not imply the dataset is pre-sorted by ip I should do the project before changing the outline. --- f20/p5/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/f20/p5/README.md b/f20/p5/README.md index b075c33..12a5dcf 100644 --- a/f20/p5/README.md +++ b/f20/p5/README.md @@ -224,8 +224,8 @@ Yes, those aren't quite real IP addresses, as explained in the next section... This command has two parts: sorting and adding a new country column. -Can you think of a reason to sort the new column before merging? -**Hint** The zip files are pre-sorted +Can you think of a reason to sort the files before merging? +**Hint** What if they are sorted by the same key? It's OK if you read in the complete CSV, then sort, perhaps something like this: From 20a2b7b3ddf366d4e292810f42c7c41addbf6a46 Mon Sep 17 00:00:00 2001 From: Cyrannosaurus <70718730+Cyrannosaurus@users.noreply.github.com> Date: Sat, 7 Nov 2020 14:52:46 -0600 Subject: [PATCH 3/3] finalize this is stressful --- f20/p5/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/f20/p5/README.md b/f20/p5/README.md index 12a5dcf..662b80e 100644 --- a/f20/p5/README.md +++ b/f20/p5/README.md @@ -224,8 +224,8 @@ Yes, those aren't quite real IP addresses, as explained in the next section... This command has two parts: sorting and adding a new country column. -Can you think of a reason to sort the files before merging? -**Hint** What if they are sorted by the same key? +Can you think of a reason to sort the countries column before merging? +**Hint** What if the data it is merging with is sorted by the same key? It's OK if you read in the complete CSV, then sort, perhaps something like this: