Update ts:precompile to only produce declarations

Author: dfreeman

ts/lib/commands/precompile.js

@@ -41,19 +41,14 @@ module.exports = Command.extend({
     return execa('tsc', flags).then(() => {
       let output = [];
       for (let declSource of walkSync(outDir, { globs: ['**/*.d.ts'] })) {
-        if (this._shouldCopy(declSource)) {
-          let compiled = declSource.replace(/\.d\.ts$/, '.js');
-          this._copyFile(output, `${outDir}/${compiled}`, compiled);
-
-          // We can only do anything meaningful with declarations for files in addon/ or src/
-          if (this._isAddonFile(declSource)) {
-            let declDest = declSource
-              .replace(/^addon\//, '')
-              .replace(/^addon-test-support/, 'test-support');
-            this._copyFile(output, `${outDir}/${declSource}`, declDest);
-          } else if (this._isSrcFile(declSource)) {
-            this._copyFile(output, `${outDir}/${declSource}`, declSource);
-          }
+        // We can only do anything meaningful with declarations for files in addon/ or src/
+        if (this._isAddonFile(declSource)) {
+          let declDest = declSource
+            .replace(/^addon\//, '')
+            .replace(/^addon-test-support/, 'test-support');
+          this._copyFile(output, `${outDir}/${declSource}`, declDest);
+        } else if (this._isSrcFile(declSource)) {
+          this._copyFile(output, `${outDir}/${declSource}`, declSource);
         }
       }
 
@@ -63,16 +58,6 @@ module.exports = Command.extend({
     });
   },
 
-  _shouldCopy(source) {
-    return this._isAppFile(source)
-      || this._isAddonFile(source)
-      || this._isSrcFile(source);
-  },
-
-  _isAppFile(source) {
-    return source.indexOf('app') === 0;
-  },
-
   _isAddonFile(source) {
     return source.indexOf('addon') === 0;
   },

ts/tests/commands/precompile-test.js

@@ -18,7 +18,7 @@ describe('Acceptance: ts:precompile command', function() {
     return emberNew({ target: 'addon' }).then(() => ember(['generate', 'ember-cli-typescript']));
   });
 
-  it('generates .js and .d.ts files from the addon tree', function() {
+  it('generates .d.ts files from the addon tree', function() {
     fs.ensureDirSync('addon');
     fs.writeFileSync('addon/test-file.ts', `export const testString: string = 'hello';`);
 
@@ -27,29 +27,21 @@ describe('Acceptance: ts:precompile command', function() {
         let declaration = file('test-file.d.ts');
         expect(declaration).to.exist;
         expect(declaration.content.trim()).to.equal(`export declare const testString: string;`);
-
-        let transpiled = file('addon/test-file.js');
-        expect(transpiled).to.exist;
-        expect(transpiled.content.trim()).to.equal(`export const testString = 'hello';`);
       });
   });
 
-  it('generates .js files only from the app tree', function() {
+  it('generates nothing from the app tree', function() {
     fs.ensureDirSync('app');
     fs.writeFileSync('app/test-file.ts', `export const testString: string = 'hello';`);
 
     return ember(['ts:precompile']).then(() => {
       let declaration = file('test-file.d.ts');
       expect(declaration).not.to.exist;
-
-      let transpiled = file('app/test-file.js');
-      expect(transpiled).to.exist;
-      expect(transpiled.content.trim()).to.equal(`export const testString = 'hello';`);
     });
   });
 
   describe('module unification', function() {
-    it('generates .js and .d.ts files from the src tree', function() {
+    it('generates .d.ts files from the src tree', function() {
       fs.ensureDirSync('src');
       fs.writeFileSync('src/test-file.ts', `export const testString: string = 'hello';`);
 
@@ -62,10 +54,6 @@ describe('Acceptance: ts:precompile command', function() {
           let declaration = file('src/test-file.d.ts');
           expect(declaration).to.exist;
           expect(declaration.content.trim()).to.equal(`export declare const testString: string;`);
-
-          let transpiled = file('src/test-file.js');
-          expect(transpiled).to.exist;
-          expect(transpiled.content.trim()).to.equal(`export const testString = 'hello';`);
         });
     });
   });