Skip to content

Commit eb7a792

Browse files
committed
Add tests todos
1 parent 323131a commit eb7a792

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

connection/transaction.feature

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,8 @@ Feature: Connection Transaction
223223
# | write |
224224
# | schema |
225225

226+
# TODO: Read queries in parallel transactions are successful?
227+
226228
Scenario Outline: write in a <type> transaction fails
227229
Given connection create database: typedb
228230
Given connection open schema transaction for database: typedb

driver/driver.feature

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,7 @@ Feature: TypeDB Driver
333333
# Then connection has database: created-after-write
334334
# Then connection has database: created-after-read
335335

336+
# TODO: Test on_close with planned driver's closing on transaction close (similar to old networking_in_on_close in Rust)
336337

337338
Scenario: Driver processes transaction commit errors correctly
338339
Given connection open schema transaction for database: typedb
@@ -541,6 +542,13 @@ Feature: TypeDB Driver
541542
define attribute name owns name;
542543
"""
543544

545+
# TODO: Cover these cases (can also be moved to connection/transaction if it's fair for the server:
546+
#
547+
# read queries can be opened and iterated concurrently & interleaved freely
548+
# write and schema queries cancel previous read and write queries from responding their answers
549+
# So as soon as you run a write of schema query, previous iterators will eventually be interrupted (didn't manage to make it "eager", youll either be able to finish the answers in the buffer and it's OK, or you eventually get an error in those streams.
550+
#
551+
# Commit, rollback, and close actually do the same things!
544552

545553
############
546554
# CONCEPTS #

0 commit comments

Comments
 (0)