Skip to content

Commit 965d88a

Browse files
authored
Remove incorrect django.db.models re-exports (#1835)
Trying to import these items in Django 4.2.7 fails with `ImportError` at runtime. Not sure if they were removed, or never worked in the first place.
1 parent 87b6ba2 commit 965d88a

File tree

4 files changed

+3
-31
lines changed

4 files changed

+3
-31
lines changed

django-stubs/contrib/admin/decorators.pyi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ from typing import Any, TypeVar, overload
33

44
from django.contrib.admin import ModelAdmin
55
from django.contrib.admin.sites import AdminSite
6-
from django.db.models import Combinable, QuerySet
6+
from django.db.models import QuerySet
77
from django.db.models.base import Model
8-
from django.db.models.expressions import BaseExpression
8+
from django.db.models.expressions import BaseExpression, Combinable
99
from django.http import HttpRequest, HttpResponseBase
1010
from django.utils.functional import _StrOrPromise
1111
from typing_extensions import TypeAlias

django-stubs/db/models/__init__.pyi

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@ from .enums import Choices as Choices
2626
from .enums import IntegerChoices as IntegerChoices
2727
from .enums import TextChoices as TextChoices
2828
from .expressions import Case as Case
29-
from .expressions import Col as Col
30-
from .expressions import Combinable as Combinable
31-
from .expressions import CombinedExpression as CombinedExpression
3229
from .expressions import Exists as Exists
3330
from .expressions import Expression as Expression
3431
from .expressions import ExpressionList as ExpressionList
@@ -37,8 +34,6 @@ from .expressions import F as F
3734
from .expressions import Func as Func
3835
from .expressions import OrderBy as OrderBy
3936
from .expressions import OuterRef as OuterRef
40-
from .expressions import RawSQL as RawSQL
41-
from .expressions import Ref as Ref
4237
from .expressions import RowRange as RowRange
4338
from .expressions import Subquery as Subquery
4439
from .expressions import Value as Value
@@ -77,8 +72,6 @@ from .fields import TextField as TextField
7772
from .fields import TimeField as TimeField
7873
from .fields import URLField as URLField
7974
from .fields import UUIDField as UUIDField
80-
from .fields.files import FieldFile as FieldFile
81-
from .fields.files import FileDescriptor as FileDescriptor
8275
from .fields.files import FileField as FileField
8376
from .fields.files import ImageField as ImageField
8477
from .fields.json import JSONField as JSONField
@@ -94,11 +87,9 @@ from .fields.related import OneToOneRel as OneToOneRel
9487
from .indexes import Index as Index
9588
from .lookups import Lookup as Lookup
9689
from .lookups import Transform as Transform
97-
from .manager import BaseManager as BaseManager
9890
from .manager import Manager as Manager
9991
from .query import Prefetch as Prefetch
10092
from .query import QuerySet as QuerySet
101-
from .query import RawQuerySet as RawQuerySet
10293
from .query import prefetch_related_objects as prefetch_related_objects
10394
from .query_utils import FilteredRelation as FilteredRelation
10495
from .query_utils import Q as Q

django-stubs/db/models/manager.pyi

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@ import datetime
22
from collections.abc import AsyncIterator, Collection, Iterable, Iterator, MutableMapping, Sequence
33
from typing import Any, Generic, NoReturn, TypeVar, overload
44

5-
from django.db.models import Combinable
65
from django.db.models.base import Model
7-
from django.db.models.expressions import OrderBy
6+
from django.db.models.expressions import Combinable, OrderBy
87
from django.db.models.query import QuerySet, RawQuerySet
98
from typing_extensions import Self
109

scripts/stubtest/allowlist_todo.txt

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,6 @@ django.contrib.gis.db.models.BLANK_CHOICE_DASH
299299
django.contrib.gis.db.models.BaseConstraint.contains_expressions
300300
django.contrib.gis.db.models.BaseConstraint.get_violation_error_message
301301
django.contrib.gis.db.models.BaseConstraint.validate
302-
django.contrib.gis.db.models.BaseManager
303302
django.contrib.gis.db.models.BigAutoField.rel_db_type
304303
django.contrib.gis.db.models.BigIntegerField.formfield
305304
django.contrib.gis.db.models.BinaryField.get_placeholder
@@ -309,9 +308,6 @@ django.contrib.gis.db.models.CharField.cast_db_type
309308
django.contrib.gis.db.models.CharField.description
310309
django.contrib.gis.db.models.CharField.formfield
311310
django.contrib.gis.db.models.CheckConstraint.validate
312-
django.contrib.gis.db.models.Col
313-
django.contrib.gis.db.models.Combinable
314-
django.contrib.gis.db.models.CombinedExpression
315311
django.contrib.gis.db.models.Count.__init__
316312
django.contrib.gis.db.models.Count.empty_result_set_value
317313
django.contrib.gis.db.models.DEFERRED
@@ -356,8 +352,6 @@ django.contrib.gis.db.models.Field.rel_db_type
356352
django.contrib.gis.db.models.Field.select_format
357353
django.contrib.gis.db.models.Field.unique
358354
django.contrib.gis.db.models.FieldDoesNotExist
359-
django.contrib.gis.db.models.FieldFile
360-
django.contrib.gis.db.models.FileDescriptor
361355
django.contrib.gis.db.models.FileField.__get__
362356
django.contrib.gis.db.models.FileField.attr_class
363357
django.contrib.gis.db.models.FileField.contribute_to_class
@@ -461,9 +455,6 @@ django.contrib.gis.db.models.QuerySet.__reversed__
461455
django.contrib.gis.db.models.QuerySet.__xor__
462456
django.contrib.gis.db.models.QuerySet.datetimes
463457
django.contrib.gis.db.models.RasterField.contribute_to_class
464-
django.contrib.gis.db.models.RawQuerySet
465-
django.contrib.gis.db.models.RawSQL
466-
django.contrib.gis.db.models.Ref
467458
django.contrib.gis.db.models.SlugField.formfield
468459
django.contrib.gis.db.models.SmallAutoField.rel_db_type
469460
django.contrib.gis.db.models.StdDev.__init__
@@ -957,7 +948,6 @@ django.db.models.BLANK_CHOICE_DASH
957948
django.db.models.BaseConstraint.contains_expressions
958949
django.db.models.BaseConstraint.get_violation_error_message
959950
django.db.models.BaseConstraint.validate
960-
django.db.models.BaseManager
961951
django.db.models.BigAutoField.rel_db_type
962952
django.db.models.BigIntegerField.formfield
963953
django.db.models.BinaryField.get_placeholder
@@ -967,9 +957,6 @@ django.db.models.CharField.cast_db_type
967957
django.db.models.CharField.description
968958
django.db.models.CharField.formfield
969959
django.db.models.CheckConstraint.validate
970-
django.db.models.Col
971-
django.db.models.Combinable
972-
django.db.models.CombinedExpression
973960
django.db.models.Count.__init__
974961
django.db.models.Count.empty_result_set_value
975962
django.db.models.DEFERRED
@@ -1012,8 +999,6 @@ django.db.models.Field.rel_db_type
1012999
django.db.models.Field.select_format
10131000
django.db.models.Field.unique
10141001
django.db.models.FieldDoesNotExist
1015-
django.db.models.FieldFile
1016-
django.db.models.FileDescriptor
10171002
django.db.models.FileField.__get__
10181003
django.db.models.FileField.attr_class
10191004
django.db.models.FileField.contribute_to_class
@@ -1114,9 +1099,6 @@ django.db.models.QuerySet.__deepcopy__
11141099
django.db.models.QuerySet.__reversed__
11151100
django.db.models.QuerySet.__xor__
11161101
django.db.models.QuerySet.datetimes
1117-
django.db.models.RawQuerySet
1118-
django.db.models.RawSQL
1119-
django.db.models.Ref
11201102
django.db.models.SlugField.formfield
11211103
django.db.models.SmallAutoField.rel_db_type
11221104
django.db.models.StdDev.__init__

0 commit comments

Comments
 (0)