Skip to content

Commit a217ff0

Browse files
authored
Ensure multiple admin attributes are to be either list or tuple (#1832)
Attributes are aligned with Django admin's default checks list found here https://docs.djangoproject.com/en/4.2/ref/checks/#admin
1 parent a0040b9 commit a217ff0

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

django-stubs/contrib/admin/options.pyi

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -76,19 +76,19 @@ _ListFilterT: TypeAlias = (
7676
_ModelT = TypeVar("_ModelT", bound=Model)
7777

7878
class BaseModelAdmin(Generic[_ModelT]):
79-
autocomplete_fields: Sequence[str]
80-
raw_id_fields: Sequence[str]
79+
autocomplete_fields: _ListOrTuple[str]
80+
raw_id_fields: _ListOrTuple[str]
8181
fields: _FieldGroups | None
82-
exclude: Sequence[str] | None
82+
exclude: _ListOrTuple[str] | None
8383
fieldsets: _FieldsetSpec | None
8484
form: type[forms.ModelForm[_ModelT]]
85-
filter_vertical: Sequence[str]
86-
filter_horizontal: Sequence[str]
85+
filter_vertical: _ListOrTuple[str]
86+
filter_horizontal: _ListOrTuple[str]
8787
radio_fields: Mapping[str, _Direction]
8888
prepopulated_fields: dict[str, Sequence[str]]
8989
formfield_overrides: Mapping[type[Field], Mapping[str, Any]]
90-
readonly_fields: Sequence[str]
91-
ordering: Sequence[str] | None
90+
readonly_fields: _ListOrTuple[str] | None
91+
ordering: _ListOrTuple[str] | None
9292
sortable_by: _ListOrTuple[str] | None
9393
view_on_site: bool | Callable[[_ModelT], str]
9494
show_full_result_count: bool
@@ -136,19 +136,19 @@ class ModelAdmin(BaseModelAdmin[_ModelT]):
136136
list_display: _DisplayT
137137
list_display_links: _DisplayT | None
138138
list_filter: _ListOrTuple[_ListFilterT]
139-
list_select_related: bool | Sequence[str]
139+
list_select_related: bool | _ListOrTuple[str]
140140
list_per_page: int
141141
list_max_show_all: int
142-
list_editable: Sequence[str]
143-
search_fields: Sequence[str]
142+
list_editable: _ListOrTuple[str]
143+
search_fields: _ListOrTuple[str]
144144
search_help_text: _StrOrPromise | None
145145
date_hierarchy: str | None
146146
save_as: bool
147147
save_as_continue: bool
148148
save_on_top: bool
149149
paginator: type
150150
preserve_filters: bool
151-
inlines: Sequence[type[InlineModelAdmin]]
151+
inlines: _ListOrTuple[type[InlineModelAdmin]]
152152
add_form_template: _TemplateForResponseT | None
153153
change_form_template: _TemplateForResponseT | None
154154
change_list_template: _TemplateForResponseT | None

0 commit comments

Comments
 (0)