Skip to content

Commit 6bd4c06

Browse files
authored
feat: add missing angular-whitespace converter (#1201)
* refactor: simplify converters * refactor: move codelyzer rules to the correct folder * feat: add missing `angular-whitespace` converter
1 parent bf5c9f9 commit 6bd4c06

11 files changed

+26
-14
lines changed

src/converters/lintConfigs/rules/ruleConverters.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,15 @@ import { convertBanTypes } from "./ruleConverters/ban-types";
1010
import { convertBinaryExpressionOperandOrder } from "./ruleConverters/binary-expression-operand-order";
1111
import { convertCallableTypes } from "./ruleConverters/callable-types";
1212
import { convertClassName } from "./ruleConverters/class-name";
13+
import { convertAngularWhitespace } from "./ruleConverters/codelyzer/angular-whitespace";
1314
import { convertComponentClassSuffix } from "./ruleConverters/codelyzer/component-class-suffix";
1415
import { convertComponentMaxInlineDeclarations } from "./ruleConverters/codelyzer/component-max-inline-declarations";
1516
import { convertComponentSelector } from "./ruleConverters/codelyzer/component-selector";
1617
import { convertContextualDecorator } from "./ruleConverters/codelyzer/contextual-decorator";
1718
import { convertContextualLifecycle } from "./ruleConverters/codelyzer/contextual-lifecycle";
1819
import { convertDirectiveClassSuffix } from "./ruleConverters/codelyzer/directive-class-suffix";
1920
import { convertDirectiveSelector } from "./ruleConverters/codelyzer/directive-selector";
21+
import { convertImportDestructuringSpacing } from "./ruleConverters/codelyzer/import-destructuring-spacing";
2022
import { convertNoAttributeDecorator } from "./ruleConverters/codelyzer/no-attribute-decorator";
2123
import { convertNoConflictingLifecycle } from "./ruleConverters/codelyzer/no-conflicting-lifecycle";
2224
import { convertNoForwardRef } from "./ruleConverters/codelyzer/no-forward-ref";
@@ -32,6 +34,7 @@ import { convertNoOutputsMetadataProperty } from "./ruleConverters/codelyzer/no-
3234
import { convertNoPipeImpure } from "./ruleConverters/codelyzer/no-pipe-impure";
3335
import { convertNoQueriesMetadataProperty } from "./ruleConverters/codelyzer/no-queries-metadata-property";
3436
import { convertPipePrefix } from "./ruleConverters/codelyzer/pipe-prefix";
37+
import { convertPreferInlineDecorator } from "./ruleConverters/codelyzer/prefer-inline-decorator";
3538
import { convertPreferOnPushComponentChangeDetection } from "./ruleConverters/codelyzer/prefer-on-push-component-change-detection";
3639
import { convertPreferOutputReadonly } from "./ruleConverters/codelyzer/prefer-output-readonly";
3740
import { convertRelativeUrlPrefix } from "./ruleConverters/codelyzer/relative-url-prefix";
@@ -156,7 +159,6 @@ import { convertFileNameCasing } from "./ruleConverters/file-name-casing";
156159
import { convertForin } from "./ruleConverters/forin";
157160
import { convertFunctionConstructor } from "./ruleConverters/function-constructor";
158161
import { convertImportBlacklist } from "./ruleConverters/import-blacklist";
159-
import { convertImportDestructuringSpacing } from "./ruleConverters/import-destructuring-spacing";
160162
import { convertIncrementDecrement } from "./ruleConverters/increment-decrement";
161163
import { convertIndent } from "./ruleConverters/indent";
162164
import { convertInterfaceName } from "./ruleConverters/interface-name";
@@ -281,7 +283,6 @@ import { convertPreferConditionalExpression } from "./ruleConverters/prefer-cond
281283
import { convertPreferConst } from "./ruleConverters/prefer-const";
282284
import { convertPreferForOf } from "./ruleConverters/prefer-for-of";
283285
import { convertPreferFunctionOverMethod } from "./ruleConverters/prefer-function-over-method";
284-
import { convertPreferInlineDecorator } from "./ruleConverters/prefer-inline-decorator";
285286
import { convertPreferObjectSpread } from "./ruleConverters/prefer-object-spread";
286287
import { convertPreferReadonly } from "./ruleConverters/prefer-readonly";
287288
import { convertPreferSwitch } from "./ruleConverters/prefer-switch";
@@ -331,6 +332,7 @@ import { convertVariableName } from "./ruleConverters/variable-name";
331332
export const ruleConverters = new Map([
332333
["adjacent-overload-signatures", convertAdjacentOverloadSignatures],
333334
["align", convertAlign],
335+
["angular-whitespace", convertAngularWhitespace],
334336
["array-type", convertArrayType],
335337
["arrow-parens", convertArrowParens],
336338
["arrow-return-shorthand", convertArrowReturnShorthand],
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import { RuleConverter } from "../../ruleConverter";
2+
3+
export const convertAngularWhitespace: RuleConverter = () => {
4+
return {};
5+
};

src/converters/lintConfigs/rules/ruleConverters/import-destructuring-spacing.ts renamed to src/converters/lintConfigs/rules/ruleConverters/codelyzer/import-destructuring-spacing.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../ruleConverter";
1+
import { RuleConverter } from "../../ruleConverter";
22

33
export const convertImportDestructuringSpacing: RuleConverter = () => {
44
return {};

src/converters/lintConfigs/rules/ruleConverters/prefer-inline-decorator.ts renamed to src/converters/lintConfigs/rules/ruleConverters/codelyzer/prefer-inline-decorator.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../ruleConverter";
1+
import { RuleConverter } from "../../ruleConverter";
22

33
export const convertPreferInlineDecorator: RuleConverter = () => {
44
return {};
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
import { convertAngularWhitespace } from "../angular-whitespace";
2+
3+
describe(convertAngularWhitespace, () => {
4+
test("conversion without arguments", () => {
5+
const result = convertAngularWhitespace({
6+
ruleArguments: [],
7+
});
8+
9+
expect(result).toEqual({});
10+
});
11+
});

src/converters/lintConfigs/rules/ruleConverters/codelyzer/tests/use-pipe-decorator.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ describe(convertUsePipeDecorator, () => {
66
ruleArguments: [],
77
});
88

9-
expect(result).toEqual({ rules: [] });
9+
expect(result).toEqual({});
1010
});
1111
});
Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
import { RuleConverter } from "../../ruleConverter";
22

33
export const convertUsePipeDecorator: RuleConverter = () => {
4-
return {
5-
rules: [],
6-
};
4+
return {};
75
};
Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
import { RuleConverter } from "../../ruleConverter";
22

33
export const convertNoDuplicateActionTypes: RuleConverter = () => {
4-
return {
5-
rules: [],
6-
};
4+
return {};
75
};

src/converters/lintConfigs/rules/ruleConverters/ngrx-tslint-rules/tests/no-duplicate-action-types.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ describe(convertNoDuplicateActionTypes, () => {
66
ruleArguments: [],
77
});
88

9-
expect(result).toEqual({
10-
rules: [],
11-
});
9+
expect(result).toEqual({});
1210
});
1311
});

0 commit comments

Comments
 (0)