Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

byte2int mypy annotations issue #75

Closed
levincarmel opened this issue Nov 10, 2022 · 1 comment
Closed

byte2int mypy annotations issue #75

levincarmel opened this issue Nov 10, 2022 · 1 comment

Comments

@levincarmel
Copy link

Hi,
Starting 1.16.21.2 we have an issue with mypy failing for annotations of six.byte2int.
We had this method:

def byte2int(c: Union[bytes, int]) -> int:
    if isinstance(c, bytes):
        return six.byte2int(c)
    return c

which was called the following way:
pp_fingerprint = ":".join("{:02x}".format(byte2int(c)) for c in fingerprint).upper()

This used to work until now, but now we get this failure:
Argument 1 to "byte2int" has incompatible type "bytes"; expected "SupportsGetItem[int, <nothing>]"

Is this an issue with this release? Or are we supposed to fix our annotations in some way?

Thanks in advance!

@levincarmel
Copy link
Author

Opened in typeshed repo: python/typeshed#9145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant