-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert all form processing to POST #409
Comments
why not form submissions POST and whatever's not a form submision GET? |
the change shouldn't be big either, i guess just changing the form to POST and making sure it gets the params from the POST rather than string, not sure if that part is not transparent anyway |
like you ve actually done in your last commit :P |
I tested and changed all to post, I think it better than to have to decide which page will have a form on it etc. we can adjust as needed, if it is a problem with browser history. |
So far browser history works as expected |
why not replace form buttons with actual proper links ? hmm I am now wondering if semantically these should be styled links with hrefs, and only actual forms be forms with inputs... #410 |
Get is not a secure method of submitting forms on an open ap specifically.
❓ leave url forms as get? but what if inputs get added later etc, not sure how to handle, all post for now.
support GET optionally ( for script based url programming )
the library seems to not care, however we can deny by checking
server->method() == HTTP_GET
The text was updated successfully, but these errors were encountered: