Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all form processing to POST #409

Open
1 task done
tablatronix opened this issue Aug 30, 2017 · 6 comments
Open
1 task done

Convert all form processing to POST #409

tablatronix opened this issue Aug 30, 2017 · 6 comments
Labels
enhancement Feature Request Question User Question member to member support
Milestone

Comments

@tablatronix
Copy link
Collaborator

tablatronix commented Aug 30, 2017

Get is not a secure method of submitting forms on an open ap specifically.

  • convert all to post

❓ leave url forms as get? but what if inputs get added later etc, not sure how to handle, all post for now.

support GET optionally ( for script based url programming )
the library seems to not care, however we can deny by checking
server->method() == HTTP_GET

@tablatronix tablatronix added the enhancement Feature Request label Aug 30, 2017
@tablatronix tablatronix added this to the dev milestone Aug 30, 2017
@tzapu
Copy link
Owner

tzapu commented Aug 30, 2017

why not form submissions POST and whatever's not a form submision GET?
if you are using a browser and not the captive portal using the back button becomes a pain in the ass if you navigate between POSTs

@tzapu
Copy link
Owner

tzapu commented Aug 30, 2017

the change shouldn't be big either, i guess just changing the form to POST and making sure it gets the params from the POST rather than string, not sure if that part is not transparent anyway

@tzapu
Copy link
Owner

tzapu commented Aug 30, 2017

like you ve actually done in your last commit :P
i'll but out, you are a machine :D

tablatronix added a commit to tablatronix/WiFiManager that referenced this issue Aug 30, 2017
@tablatronix
Copy link
Collaborator Author

I tested and changed all to post, I think it better than to have to decide which page will have a form on it etc. we can adjust as needed, if it is a problem with browser history.

@tablatronix
Copy link
Collaborator Author

tablatronix commented Aug 30, 2017

  • test all devices with POST on all forms provide feedback on browser back and refresh capability.

So far browser history works as expected

@tablatronix tablatronix added the Question User Question member to member support label Aug 30, 2017
@tablatronix
Copy link
Collaborator Author

tablatronix commented Aug 30, 2017

why not replace form buttons with actual proper links ?

hmm I am now wondering if semantically these should be styled links with hrefs, and only actual forms be forms with inputs... #410

tablatronix added a commit to tablatronix/WiFiManager that referenced this issue Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature Request Question User Question member to member support
Projects
None yet
Development

No branches or pull requests

2 participants