Bug: coldfront.core.project.test_views.ProjectListViewTest.test_project_list_search is Flaky

[Eric-Butcher]

What happened?

A test in the project application is very flaky. Most of the time it will not fail but every once in awhile it will.

The most likely reason could think of for this test failing is because the test was mistakenly written believing the Factories always create unique objects, and that when it happens to return a preexisting object somewhere that this throws things off. Will have to investigate further.

Version

1.1.6

Component

Other

What browsers are you seeing the problem on?

None

Relevant log output

======================================================================
FAIL: test_project_list_search (coldfront.core.project.test_views.ProjectListViewTest.test_project_list_search)
Test that project list search works.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/eric/Work/coldfront/coldfront/core/project/test_views.py", line 304, in test_project_list_search
    self.assertEqual(len(response.context["object_list"]), 1)
AssertionError: 2 != 1

----------------------------------------------------------------------

Tasks/ user tests when bug is fixed

• [ ]

[csbarnet]

I've seen this behavior as well

[cecilialau6776]

Figured it out:
The test searches projects based on field of science and PI's last name. During test setup, it creates one random 'main' project and 100 random projects. From the 100, it removes any projects where its PI's last name matches the 'main' project's PI's last name, presumably to avoid this collision. However, filtering by last name in project search does an icontains - case insensitive "contains." Faker, the library creating random names, can create a main project with PI last name "Martin" and and extra projects with PI last name "Martinez," so the search will return "extra" results.

I opened a PR: #808