Skip to content

Commit 0b1620c

Browse files
authored
Update android benchmark to alpha06 and parameterize tests (#41)
* Update AGP, benchmark, androidx deps * Move benchmark plugin to after android closure This seems to be required now * Refactor RxDogTagAndroidPerf to be parameterized * Remove the space in the parameters name Otherwise it confuses the dataparser * Rename for simpler dataparsing * Update data parsing for new names * AGP 3.5.0-rc03 * Update to benchmark 04 * Always use latches * Remove (uncorrect and now unnecessary) test runner * Revert "Always use latches" This reverts commit 29eb894. * Dispose subscribe-only tests after running * Update parser * Use all distro for gradle * Add guarded delegates to test matrix * Skip guarded delegates when not enabled * Refactor subscribers a bit * Update new benchmark results * Use associateWith * Fix naming for guardedDelegateEnabled * Fix style * Filter out guarded delegate tests if no emissions * Fix naming for e2e * Enable enableAdditionalTestOutput for AGP/studio * Add requestLegacyExternalStorage to manifest for Q * SDK 29 * AGP 3.5.0 final * Benchmark alpha05 * Update tests for symmetry of times=0 -> subscribe, rest is throughput * Update parser for new symmetry * Update benchmark.md * Fix kotlin plugin version * Fix thousand/million collisions * Break down e2e parsing * Remove e2e in favor of more broken down throughput * Remove schedulers from complex as they add too much variance * Remove percentage deltas as they're not really informing With the units we're using, this invites readers to focus on the wrong thing * Update to benchmark alpha06 * Simplify columns and naming Now it all fits on a page * Remove bit about percentages * Remove indices * Decrement headers one level and simplify * Grammar * One more tweak to formatting
1 parent cce49ec commit 0b1620c

File tree

9 files changed

+404
-614
lines changed

9 files changed

+404
-614
lines changed

android-benchmark/benchmark/build.gradle

+13-8
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,11 @@ apply plugin: "org.jetbrains.kotlin.android"
1919
apply plugin: "androidx.benchmark"
2020

2121
android {
22-
compileSdkVersion 28
23-
buildToolsVersion '28.0.3'
22+
compileSdkVersion 29
2423

2524
defaultConfig {
2625
minSdkVersion 14
27-
targetSdkVersion 28
28-
testInstrumentationRunner "androidx.benchmark.AndroidBenchmarkRunner"
26+
targetSdkVersion 29
2927
}
3028
compileOptions {
3129
sourceCompatibility = JavaVersion.VERSION_1_8
@@ -37,11 +35,18 @@ android {
3735
}
3836
}
3937

38+
tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).all {
39+
kotlinOptions {
40+
jvmTarget = "1.8"
41+
}
42+
}
43+
4044
dependencies {
41-
implementation "androidx.benchmark:benchmark:1.0.0-alpha01"
42-
implementation "androidx.test:runner:1.1.1"
43-
implementation "androidx.test:rules:1.1.1"
44-
implementation "androidx.test.ext:junit:1.1.0"
45+
implementation "androidx.benchmark:benchmark-common:${deps.versions.androidBenchmark}"
46+
implementation "androidx.benchmark:benchmark-junit4:${deps.versions.androidBenchmark}"
47+
implementation "androidx.test:runner:1.2.0"
48+
implementation "androidx.test:rules:1.2.0"
49+
implementation "androidx.test.ext:junit:1.1.1"
4550
implementation "org.jetbrains.kotlin:kotlin-stdlib:1.3.50"
4651
implementation "io.reactivex.rxjava2:rxandroid:2.1.1"
4752
implementation deps.test.junit
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
#
2+
# Copyright (C) 2019. Uber Technologies
3+
#
4+
# Licensed under the Apache License, Version 2.0 (the "License");
5+
# you may not use this file except in compliance with the License.
6+
# You may obtain a copy of the License at
7+
#
8+
# http://www.apache.org/licenses/LICENSE-2.0
9+
#
10+
# Unless required by applicable law or agreed to in writing, software
11+
# distributed under the License is distributed on an "AS IS" BASIS,
12+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
# See the License for the specific language governing permissions and
14+
# limitations under the License.
15+
#
16+
17+
android.enableAdditionalTestOutput=true

0 commit comments

Comments
 (0)