Skip to content

Commit b4c608a

Browse files
committed
use requirements files for package installs and make lint envs consistent
1 parent e28801a commit b4c608a

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

.github/workflows/python-sanity-check.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,9 @@ jobs:
7676
run: |
7777
sudo apt install -y libenchant-2-dev libcrack2-dev libssl-dev
7878
python -m pip install --upgrade pip
79-
pip install flake8 pylint #pytest
79+
if [ -f local-requirements.txt ]; then pip install -r local-requirements.txt; fi
80+
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
81+
if [ -f recommended.txt ]; then pip install -r recommended.txt; fi
8082
# We may need git installed to get a full repo clone rather than unpacked archive
8183
- name: Check out source repository
8284
uses: actions/checkout@v4
@@ -125,7 +127,7 @@ jobs:
125127
run: |
126128
dnf install -y enchant cracklib openssl-devel
127129
python -m pip install --upgrade pip
128-
pip install flake8 pylint #pytest
130+
if [ -f local-requirements.txt ]; then pip install -r local-requirements.txt; fi
129131
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
130132
if [ -f recommended.txt ]; then pip install -r recommended.txt; fi
131133
# We need git installed to get a full repo clone rather than unpacked archive

local-requirements.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,10 @@
33
# This list is mainly used to specify addons needed for the unit tests.
44
# We only need autopep8 on py 3 as it's used in 'make fmt' (with py3)
55
autopep8;python_version >= "3"
6+
flake8
67
# We need paramiko for the ssh unit tests
78
# NOTE: paramiko-3.0.0 dropped python2 and python3.6 support
89
paramiko;python_version >= "3.7"
910
paramiko<3;python_version < "3.7"
11+
pylint
1012
werkzeug

0 commit comments

Comments
 (0)