From 830e683ddeb6094acc7131b212aba8016c1112d3 Mon Sep 17 00:00:00 2001 From: Alan Poulain Date: Mon, 4 Nov 2024 11:16:05 +0100 Subject: [PATCH] fix(bubble-menu): add `element` to `shouldShow` in BubbleMenu opts (#5790) --- .changeset/five-mice-turn.md | 5 +++++ packages/extension-bubble-menu/src/bubble-menu-plugin.ts | 2 ++ 2 files changed, 7 insertions(+) create mode 100644 .changeset/five-mice-turn.md diff --git a/.changeset/five-mice-turn.md b/.changeset/five-mice-turn.md new file mode 100644 index 0000000000..a7f0aa1aa6 --- /dev/null +++ b/.changeset/five-mice-turn.md @@ -0,0 +1,5 @@ +--- +"@tiptap/extension-bubble-menu": patch +--- + +Add `element: HTMLElement` to `shouldShow` options within the BubbleMenu options. diff --git a/packages/extension-bubble-menu/src/bubble-menu-plugin.ts b/packages/extension-bubble-menu/src/bubble-menu-plugin.ts index 4b8f8d9800..1bcfe71097 100644 --- a/packages/extension-bubble-menu/src/bubble-menu-plugin.ts +++ b/packages/extension-bubble-menu/src/bubble-menu-plugin.ts @@ -46,6 +46,7 @@ export interface BubbleMenuPluginProps { shouldShow?: | ((props: { editor: Editor + element: HTMLElement view: EditorView state: EditorState oldState?: EditorState @@ -238,6 +239,7 @@ export class BubbleMenuView { const shouldShow = this.shouldShow?.({ editor: this.editor, + element: this.element, view, state, oldState,