Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: InputRules do not support the new 'undoable' option #4659

Open
1 of 2 tasks
Nantris opened this issue Nov 29, 2023 · 3 comments
Open
1 of 2 tasks

[Bug]: InputRules do not support the new 'undoable' option #4659

Nantris opened this issue Nov 29, 2023 · 3 comments
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@Nantris
Copy link
Contributor

Nantris commented Nov 29, 2023

Which packages did you experience the bug in?

core

What Tiptap version are you using?

2.1.12

What’s the bug you are facing?

A new version of ProseMirror's InputRules includes an undoable option for InputRules, which TipTap does not currently support.

ProseMirror/prosemirror-inputrules@8b6eabc

What browser are you using?

Chrome

Code example

No response

What did you expect to happen?

TipTap API exposes all underlying ProseMirror functionality.

Anything to add? (optional)

I know this is new so it may not be a bug per se, but this seemed the most applicable category.

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@Nantris Nantris added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Nov 29, 2023
@github-project-automation github-project-automation bot moved this to Triage open in Tiptap Nov 29, 2023
@Nantris
Copy link
Contributor Author

Nantris commented Jan 9, 2024

Friendly bump. This would be a huge help now that the 2.2.0-rc8 and above will use the updated ProseMirror deps.

@Nantris
Copy link
Contributor Author

Nantris commented Feb 6, 2024

Friendly bump. Is there any chance this will be added? There are use cases we simply cannot implement without this and it prevents us from completing the port of our editor.

@Nantris
Copy link
Contributor Author

Nantris commented Feb 14, 2024

Am I wrong to think TipTap InputRules are actually unrelated to the ProseMirror concept? I don't see where the ProseMirror InputRule is used in this file at all: https://github.com/ueberdosis/tiptap/blob/3e440c2f96cd56683d3d7eb3c0e6cea83f7a31b7/packages/core/src/InputRule.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
No open projects
Status: Triage open
Development

No branches or pull requests

3 participants