Skip to content

Commit 5ef5adc

Browse files
dustinswaleshertnekygrantfirlscrasmussenclimbfuji
authored
Updates for ccpp-capgen v1 (#378)
* [scm/dev] Ability to build with ip and sp library (NCAR#1208) * Add ability to build with ip if it is found. sp is being replaced by ip so this is needed. Note that in spack-stack 1.9.3 the ip package builds with the OpenMP flag, so CMAKE_Fortran_FLAGS_OPENMP_OFF needs to be set by the host model. The RRTMGP files currently break if compiled with OpenMP flags. * only have DTC/SCM people in the CODEOWNERS for the scm/dev branch --------- Co-authored-by: Soren Rasmussen <s.c.rasmussen@gmail.com> * [main] Followup for NCAR#1187 for NOAA models (NCAR#1205) * update several files to work with CCPP SCM after PR 1187 * remove ccpp_bcast for aerin and aer_pres due to UFS RT hanging * [scm/dev] Update scm/dev from main (includes ccpp_bcast PR + followup NOAA fixes) (NCAR#1209) * Read and broadcast data from MPI root rank during init and timestep init phase in GFS time vary; add time vary interstitials for NEPTUNE (NCAR#1187) * 1. number_of_coefficients_in_ozone_data --> number_of_coefficients_in_ozone_forcing_data 2. Add NEPTUNE interstitials in physics/Interstitials/UFS_SCM_NEPTUNE/ * Read and broadcast data in CCPP init and timestep_init phases instead of reading with every MPI rank * In physics/Radiation/radiation_astronomy.f, replace hardcoded zero with mpiroot; move mpiutil.F90 to subdirectory tools * physics/tools/mpiutil.F90: add temporary routine to mpi-abort the model if MPI broadcast errors occur * Bug fixes in physics/Interstitials/UFS_SCM_NEPTUNE/GFS_time_vary_pre.*.F90 when writing to errmsg for invalid w3kindreal/w3kindint; additionally: formatting updates * In physics/Radiation/radiation_astronomy.f, replace hardcoded zero with mpiroot; move mpiutil.F90 to subdirectory tools * Add ability to build with ip if it is found. sp is being replaced by ip so this is needed. Note that in spack-stack 1.9.3 the ip package builds with the OpenMP flag, so CMAKE_Fortran_FLAGS_OPENMP_OFF needs to be set by the host model. The RRTMGP files currently break if compiled with OpenMP flags. * update several files to work with CCPP SCM after PR 1187 * remove ccpp_bcast for aerin and aer_pres due to UFS RT hanging --------- Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> Co-authored-by: Soren Rasmussen <s.c.rasmussen@gmail.com> * [main] ccpp-physics SciDocs to github pages (NCAR#1207) * add doxygen action * minor changes * minor changes * minor changes * doxy only * Create main.yml * Create jekyll-gh-pages.yml * change * add doxyfile into wkfl * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update ccpp_doxyfile * Update ccpp_doxyfile * update ccpp doxyfile * Update doxygen.yml * update doxyfile * Update doxygen.yml * Update doxygen.yml * update doxyfile * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * change path * add mactex * add mactex * minor changes * minor fix * try1 * try1 * try2 * updates * update perl * update perl * update path * explicitly install * updates * updates * fix * fix path * fix * fix path * fixes * fix3 * cleanup * restore yml files * hsd updates * add doxygen.yml * update branch * update wflw * test * fix * fix * fix * fix * rearrange steps * oops * . * debug * chng dir * chng dir * chng dir * -landing page * -update para * try to add a backlink, fix typo * fix css link * link path * try cp stylesheet * Add CCPP website * fix * add SRW build, backlink * try mainpage * changes for mainpage * mainpage config * mainpage config * mainpage config * mainpage debug * mainpage debug * mainpage debug * mainpage debug * mainpage debug * fix landing page sidebar. * fix landing page sidebar. * fix landing page sidebar. * fix landing page sidebar. * style updates * mainpage style * mainpage style * hide tree on mainpage * add back tree * try adding backlink * add backlink to other pages * updates migrated from mzhangw * fix missed conflicts * fix syntax * run workflow on this branch * remove branch from workflow run, update doxyfile * mods to mainpag dxy * updates * try update for v7 arg table * turn on scidoc branch for deploy * recurse checkout * fix directory * try fix * update landing page with acknowledgements * fix path * fix path * debug * add prebuild_config for building tables * fix * debug * debug * restructure workflow to work with metadata2html.py * add remaining prebuild configs * attempt fix srwv3 checkout * fix main checkout for landing page, stash prebuild configs * fix syntax * update prebuild location * workflow updates * point to NCAR/main --------- Co-authored-by: mzhangw <man.zhang@noaa.gov> Co-authored-by: mzhangw <mzhangw@gmail.com> Co-authored-by: Grant Firl <grant.firl@noaa.gov> * fix: update actions/checkout version to v6, v4 uses deprecated nodejs version. Updating other actions to their newest release (NCAR#1215) Co-authored-by: Grant Firl <grant.firl@noaa.gov> * First round of updates and bug fixes for capgen-ng * Update submodule pointer for physics/MP/TEMPO/TEMPO * Minor bugfixes for building with capgen-ng in SCM * ufs-dev PR#337 (NCAR#1212) * remove Zhao-Carr cloud schemes and combine Xu-Randall cloud fraction calculations * change Xu-Randall cloud fraction scheme to be elemental * use new cld_frac_XuRandall function from module_radiation_clouds in RRTMGP scheme * modify the cld_frac_XuRandall function call in RRTMGP scheme * add the repository update to this PR * Revert "add the repository update to this PR" This reverts commit 565d62c. * remove the printing tests * remove Zhao-Carr schemes from modules in the UFS_SCM_NEPTUNE directory * remove Zhao-Carr microphysics scheme from physics/MP directory * remove non-ASCII character in canopy_levs.F90 (from previous PR) * Apply suggestion from @matusmartini Co-authored-by: Matus Martini <matusmartini@users.noreply.github.com> --------- Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov> Co-authored-by: Grant Firl <grant.firl@noaa.gov> Co-authored-by: Matus Martini <matusmartini@users.noreply.github.com> * Metadata corrections from ccpp_validator.py * Correct dimensions for air_pressure_at_interface in physics/MP/Ferrier_Aligo/mp_fer_hires.meta * physics/Interstitials/UFS_SCM_NEPTUNE/GFS_phys_time_vary.neptune.meta: fix intent for xlat_d and xlon_d * ufs-dev PR#363 PR#339 PR#364 (NCAR#1213) * remove Zhao-Carr cloud schemes and combine Xu-Randall cloud fraction calculations * change Xu-Randall cloud fraction scheme to be elemental * Fixed too-high lower bound for SMC Deleted code associated with already removed print statements Deleted excess comments. * use new cld_frac_XuRandall function from module_radiation_clouds in RRTMGP scheme * Tidy-up for PR. * modify the cld_frac_XuRandall function call in RRTMGP scheme * Changes to the post L-IAU checks: * Change tfreeze to match that in NoahMP * Only set SLC to SMC if temp newly > tfreez * add the repository update to this PR * Revert "add the repository update to this PR" This reverts commit 565d62c. * remove the printing tests * remove Zhao-Carr schemes from modules in the UFS_SCM_NEPTUNE directory * remove Zhao-Carr microphysics scheme from physics/MP directory * Update for 10m wind option in fire_behavior module * remove non-ASCII character in canopy_levs.F90 (from previous PR) * Updates to progomega option of saSAS convection scheme * Correction * correction 2 * Correct parameter setting in samfshalcnv to pass debug runs * address saturation vapor pressure out of bounds error in hafs_4_nest RT --------- Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov> Co-authored-by: Clara.Draoper-NOAA <clara.draper@noaa.gov> Co-authored-by: Grant Firl <grant.firl@noaa.gov> Co-authored-by: Michael Kavulich, Jr <kavulich@ucar.edu> Co-authored-by: Lisa <lisa.bengtsson@noaa.gov> Co-authored-by: Rhae Sung Kim <rhaesung.kim@noaa.gov> * Metadata corrections from ccpp_validator.py (NCAR#1219) * resubmission: Small inconsistency between metadata and fortran code (NCAR#1222) * Fix fortran to metadata inconsistency * Actual fix --------- Co-authored-by: dustinswales <dswales@ucar.edu> * Some small changes * UFS/dev PR#299 (NCAR#1220) * update standard names to move Xgrs to physics_timestep_initial* and remove *_of_new_state (default name refers to 'current' value) * fix a few unchanged standard names * change some timestep_initial variables to general variables; make satmedmfvdifq return new tendencies and new tendency application block in GFS_PBL_generic_post * Refactor physics tendency calculations - Added tendency variables (`ten_t`, `ten_u`, `ten_v`) for temperature and wind tendencies in SAMF deep and shallow convection schemes. - Updated relevant `.meta` files to reflect changes in variable intent (`inout` -> `in` where appropriate) and added tendencies. - Modified Interstitials (`GFS_DCNV_generic_post`, `GFS_DCNV_generic_pre`, `GFS_SCNV_generic_post`, `GFS_SCNV_generic_pre`) to directly use tendencies instead of saved state variables. - Removed redundant saved variables (`save_u`, `save_v`, `save_t`). - Added `delt` to post interstitials. * update unified_ugwp, ugwpv1, and drag_suite to use new tendency code * save tendency work with GFS_photochemistry * add tracer tendency changes to convection; fix typos in GFS_photochemistry * fix typo in samfdeepcnv.f * save tendency work with Thompson MP * save tendency work with radiation * add FMS to ccpp-physics CMakeLists.txt for fv3 * add initial setting of state in GFS_time_vary_pre.fv3; fix horizontal_dimension in GFS_time_vary_pre.scm * fix metadata in GFS_time_vary_pre.fv3 * add momentum tendency output to mp_thompson and fix intent in metadata * fix array size bug in mp_thompson.F90; cleanup dtend code using new tendency paradigm; cleanup saving of states no longer needed * fix improperly-merged conflict resolution in GFS_photochemistry.F90 * fix access of ntlnc/ntinc access of tracer array when missing * convert many RAD, PBL, GWD, CONV, and MP schemes to return tendencies * convert MG micro and Arakawa-Wu adjustment schemes * convert MYNNEDMF PBL scheme to return tendencies * add changes to MYNN EDMF PBL * add back divide-by-zero bugfix in module_sf_noahmp_glacier.F90 that was removed recently * remove obsolete interstitial schemes * fix 2 minor compilation issues after testing with UFS RTs * fix bug in MG MP * fix near-surface air temperature standard name in GFS_surface_composites_pre * apply tendency cleanup to GFDLMPv3 and TEMPO * fix compilation error * fix typo in TEMPO * debug sgscloud_radpre/post * remove tendency application code from rrtmg_lw/sw_post * change thmpsn to thompson to fix compilation error * fix compilation errors in GFS_radiation_post.F90 * remove Zhao-Carr cloud schemes and combine Xu-Randall cloud fraction calculations * fix array size problem in cs_conv.F90 * refactor RAS tendencies * fix compilation error in rascnv.F90 * change Xu-Randall cloud fraction scheme to be elemental * Fixed too-high lower bound for SMC Deleted code associated with already removed print statements Deleted excess comments. * use new cld_frac_XuRandall function from module_radiation_clouds in RRTMGP scheme * Tidy-up for PR. * modify the cld_frac_XuRandall function call in RRTMGP scheme * Changes to the post L-IAU checks: * Change tfreeze to match that in NoahMP * Only set SLC to SMC if temp newly > tfreez * add the repository update to this PR * Revert "add the repository update to this PR" This reverts commit 565d62c. * fix bug in GFDLMPv3 tendency implementation * remove the printing tests * remove Zhao-Carr schemes from modules in the UFS_SCM_NEPTUNE directory * remove Zhao-Carr microphysics scheme from physics/MP directory * fix hail tendency changes from reviewer suggestions * fix indexing bug in cu_tiedtke caught in code review * changes to RAS tendency application update code from code review * check for flag_for_generic_tendency_due_to_gravity_wave_drag before computing diagnostic tendencies in drag_suite * fix diagnostic tendency bug in physics/GWD/ugwpv1_gsldrag.F90 * remove unused arguments in physics/GWD/ugwpv1_gsldrag_post.F90 * fix tendency diagnostics in physics/GWD/unified_ugwp.F90 * fix merge problem in mp_thompson.meta * add arguments to drag_suite_run called outside of ccpp entry point * initialize dclw variables in cu_ntiedtke * fix loop bounds for ten_q in cu_gf_driver.F90 * fix loop bounds in cu_c3_driver * fix new_q typo in mp_fer_hires.F90 * deallocate locally-allocated variables in MP schemes * update zeroing logic in m_micro_post after review * Update for 10m wind option in fire_behavior module * remove non-ASCII character in canopy_levs.F90 (from previous PR) * Updates to progomega option of saSAS convection scheme * Correction * correction 2 * fix line in SHOC where a tracer was being updated directly * remove old_ozone array since it was not being used * deallocate local variables in satmedmfvdifq at end of run phase * save temperature before modification to pass in to diagnostics in GFS_radiation_post * fix diagnostic temp tendency in GFS_MP_generic.F90 for when radar is/isn't available * Correct parameter setting in samfshalcnv to pass debug runs * address saturation vapor pressure out of bounds error in hafs_4_nest RT * update long names to remove 'updated by physics'; change prognostic updraft standard names * remove additional references to Zhao-Carr microphysics * remove Zhao-Carr references from GFS_scnv_generic_post * fix deallocation statement in Thompson MP * fix additional warnings * Bug fix in physics/GWD/rayleigh_damp.f: don't mix scalars and rank-2 arrays * remove whitespace changes in radiation_clouds.f --------- Co-authored-by: VanderleiVargas-NOAA <vanderlei.vargas@noaa.gov> Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov> Co-authored-by: Clara.Draoper-NOAA <clara.draper@noaa.gov> Co-authored-by: Michael Kavulich, Jr <kavulich@ucar.edu> Co-authored-by: Lisa <lisa.bengtsson@noaa.gov> Co-authored-by: Rhae Sung Kim <rhaesung.kim@noaa.gov> Co-authored-by: Grant Firl <grant@Macbook-Air-M4.local> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> * Add metadata to physcons.F90 * Fix metadata vs Fortran inconsistencies in GFS_PBL_generic_post.meta and mp_nssl.{F90,meta} * Some inconsistencies found by validator * Fix inconsistencies Fortran vs Metadata physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_pre.meta * Few more small changes * number_of_openmp_threads --> number_of_physics_threads in all schemes * C3 * Fix inconsistencies in metadata/fortran * More metadata/source inconsistencies * Ufs dev pr367 (NCAR#1223) * update standard names to move Xgrs to physics_timestep_initial* and remove *_of_new_state (default name refers to 'current' value) * fix a few unchanged standard names * change some timestep_initial variables to general variables; make satmedmfvdifq return new tendencies and new tendency application block in GFS_PBL_generic_post * Refactor physics tendency calculations - Added tendency variables (`ten_t`, `ten_u`, `ten_v`) for temperature and wind tendencies in SAMF deep and shallow convection schemes. - Updated relevant `.meta` files to reflect changes in variable intent (`inout` -> `in` where appropriate) and added tendencies. - Modified Interstitials (`GFS_DCNV_generic_post`, `GFS_DCNV_generic_pre`, `GFS_SCNV_generic_post`, `GFS_SCNV_generic_pre`) to directly use tendencies instead of saved state variables. - Removed redundant saved variables (`save_u`, `save_v`, `save_t`). - Added `delt` to post interstitials. * update unified_ugwp, ugwpv1, and drag_suite to use new tendency code * save tendency work with GFS_photochemistry * add tracer tendency changes to convection; fix typos in GFS_photochemistry * fix typo in samfdeepcnv.f * save tendency work with Thompson MP * save tendency work with radiation * add FMS to ccpp-physics CMakeLists.txt for fv3 * add initial setting of state in GFS_time_vary_pre.fv3; fix horizontal_dimension in GFS_time_vary_pre.scm * fix metadata in GFS_time_vary_pre.fv3 * add momentum tendency output to mp_thompson and fix intent in metadata * fix array size bug in mp_thompson.F90; cleanup dtend code using new tendency paradigm; cleanup saving of states no longer needed * fix improperly-merged conflict resolution in GFS_photochemistry.F90 * fix access of ntlnc/ntinc access of tracer array when missing * convert many RAD, PBL, GWD, CONV, and MP schemes to return tendencies * convert MG micro and Arakawa-Wu adjustment schemes * convert MYNNEDMF PBL scheme to return tendencies * add changes to MYNN EDMF PBL * add back divide-by-zero bugfix in module_sf_noahmp_glacier.F90 that was removed recently * remove obsolete interstitial schemes * fix 2 minor compilation issues after testing with UFS RTs * fix bug in MG MP * fix near-surface air temperature standard name in GFS_surface_composites_pre * apply tendency cleanup to GFDLMPv3 and TEMPO * fix compilation error * fix typo in TEMPO * debug sgscloud_radpre/post * remove tendency application code from rrtmg_lw/sw_post * change thmpsn to thompson to fix compilation error * fix compilation errors in GFS_radiation_post.F90 * remove Zhao-Carr cloud schemes and combine Xu-Randall cloud fraction calculations * fix array size problem in cs_conv.F90 * refactor RAS tendencies * fix compilation error in rascnv.F90 * change Xu-Randall cloud fraction scheme to be elemental * Fixed too-high lower bound for SMC Deleted code associated with already removed print statements Deleted excess comments. * use new cld_frac_XuRandall function from module_radiation_clouds in RRTMGP scheme * Tidy-up for PR. * modify the cld_frac_XuRandall function call in RRTMGP scheme * Changes to the post L-IAU checks: * Change tfreeze to match that in NoahMP * Only set SLC to SMC if temp newly > tfreez * add the repository update to this PR * Revert "add the repository update to this PR" This reverts commit 565d62c. * fix bug in GFDLMPv3 tendency implementation * remove the printing tests * remove Zhao-Carr schemes from modules in the UFS_SCM_NEPTUNE directory * remove Zhao-Carr microphysics scheme from physics/MP directory * fix hail tendency changes from reviewer suggestions * fix indexing bug in cu_tiedtke caught in code review * changes to RAS tendency application update code from code review * check for flag_for_generic_tendency_due_to_gravity_wave_drag before computing diagnostic tendencies in drag_suite * fix diagnostic tendency bug in physics/GWD/ugwpv1_gsldrag.F90 * remove unused arguments in physics/GWD/ugwpv1_gsldrag_post.F90 * fix tendency diagnostics in physics/GWD/unified_ugwp.F90 * fix merge problem in mp_thompson.meta * add arguments to drag_suite_run called outside of ccpp entry point * initialize dclw variables in cu_ntiedtke * fix loop bounds for ten_q in cu_gf_driver.F90 * fix loop bounds in cu_c3_driver * fix new_q typo in mp_fer_hires.F90 * deallocate locally-allocated variables in MP schemes * update zeroing logic in m_micro_post after review * Update for 10m wind option in fire_behavior module * remove non-ASCII character in canopy_levs.F90 (from previous PR) * Updates to progomega option of saSAS convection scheme * Correction * correction 2 * fix line in SHOC where a tracer was being updated directly * remove old_ozone array since it was not being used * deallocate local variables in satmedmfvdifq at end of run phase * save temperature before modification to pass in to diagnostics in GFS_radiation_post * Remove goto in physics/MP/Morrison_Gettelman/aer_cloud.F * Remove goto in physics/Radiation/radiation_clouds.f * fix diagnostic temp tendency in GFS_MP_generic.F90 for when radar is/isn't available * Correct parameter setting in samfshalcnv to pass debug runs * Name END DO * Remove goto physics/MP/calpreciptype.f90 * Remove goto physics/MP/Morrison_Gettelman/cldwat2m_micro.F * Start goto physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90 * Remove goto physics/SFC_Layer/UFS/module_nst_model.f90 * address saturation vapor pressure out of bounds error in hafs_4_nest RT * update long names to remove 'updated by physics'; change prognostic updraft standard names * remove additional references to Zhao-Carr microphysics * remove Zhao-Carr references from GFS_scnv_generic_post * fix deallocation statement in Thompson MP * Remove go to physics/CONV/C3/cu_c3_sh.F90 * Remove go to physics/PBL/MYJ/module_BL_MYJPBL.F90 * Remove goto physics/MP/Morrison_Gettelman/wv_saturation.F * Again physics/MP/Morrison_Gettelman/wv_saturation.F * physics/MP/Morrison_Gettelman/wv_saturation.F * Typo * Remove goto physics/CONV/C3/cu_c3_deep.F90 * Remove go to physics/CONV/RAS/rascnv.F90 * Typo rascnv.F90 * physics/SFC_Layer/GFDL/gfdl_sfc_layer.F90 * physics/CONV/Grell_Freitas/cu_gf_sh.F90 * Typo module_BL_MYJPBL.F90 * physics/SFC_Layer/MYJ/module_SF_JSFC.F90 * First pass physics/CONV/Grell_Freitas/cu_gf_deep.F90 * physics/CONV/Grell_Freitas/cu_gf_deep.F90 * physics/GWD/ugwp_driver_v0.F * physics/MP/Thompson/module_mp_thompson.F90 * physics/PBL/MYNN_EDMF/module_bl_mynn.F90 * physics/MP/GFDL/v1_2019/gfdl_cloud_microphys_mod.F90 * physics/MP/GFDL/v3_2022/gfdl_cloud_microphys_v3_mod.F90 * Fix compile physics/Radiation/radiation_clouds.f * Compile fixes * Fix for 73 character limit line * Compile fix * Start physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90 * physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90 * fix additional warnings * Fix compile hafsw wcoss2 * Revert rascnv so control_ras_intel b4b on wcoss2 * remove whitespace changes in radiation_clouds.f --------- Co-authored-by: Grant Firl <grant.firl@noaa.gov> Co-authored-by: VanderleiVargas-NOAA <vanderlei.vargas@noaa.gov> Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov> Co-authored-by: Clara.Draoper-NOAA <clara.draper@noaa.gov> Co-authored-by: Michael Kavulich, Jr <kavulich@ucar.edu> Co-authored-by: Lisa <lisa.bengtsson@noaa.gov> Co-authored-by: Nicholas Szapiro <149816583+NickSzapiro-NOAA@users.noreply.github.com> Co-authored-by: Rhae Sung Kim <rhaesung.kim@noaa.gov> Co-authored-by: Nick Szapiro <nick.szapiro@noaa.gov> Co-authored-by: Nick Szapiro <nick.szapiro@clogin06.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: Grant Firl <grant@Macbook-Air-M4.local> * ufs-dev PR#371 (NCAR#1224) * update standard names to move Xgrs to physics_timestep_initial* and remove *_of_new_state (default name refers to 'current' value) * fix a few unchanged standard names * change some timestep_initial variables to general variables; make satmedmfvdifq return new tendencies and new tendency application block in GFS_PBL_generic_post * Refactor physics tendency calculations - Added tendency variables (`ten_t`, `ten_u`, `ten_v`) for temperature and wind tendencies in SAMF deep and shallow convection schemes. - Updated relevant `.meta` files to reflect changes in variable intent (`inout` -> `in` where appropriate) and added tendencies. - Modified Interstitials (`GFS_DCNV_generic_post`, `GFS_DCNV_generic_pre`, `GFS_SCNV_generic_post`, `GFS_SCNV_generic_pre`) to directly use tendencies instead of saved state variables. - Removed redundant saved variables (`save_u`, `save_v`, `save_t`). - Added `delt` to post interstitials. * update unified_ugwp, ugwpv1, and drag_suite to use new tendency code * save tendency work with GFS_photochemistry * add tracer tendency changes to convection; fix typos in GFS_photochemistry * fix typo in samfdeepcnv.f * save tendency work with Thompson MP * save tendency work with radiation * add FMS to ccpp-physics CMakeLists.txt for fv3 * add initial setting of state in GFS_time_vary_pre.fv3; fix horizontal_dimension in GFS_time_vary_pre.scm * fix metadata in GFS_time_vary_pre.fv3 * add momentum tendency output to mp_thompson and fix intent in metadata * fix array size bug in mp_thompson.F90; cleanup dtend code using new tendency paradigm; cleanup saving of states no longer needed * fix improperly-merged conflict resolution in GFS_photochemistry.F90 * fix access of ntlnc/ntinc access of tracer array when missing * convert many RAD, PBL, GWD, CONV, and MP schemes to return tendencies * convert MG micro and Arakawa-Wu adjustment schemes * convert MYNNEDMF PBL scheme to return tendencies * add changes to MYNN EDMF PBL * add back divide-by-zero bugfix in module_sf_noahmp_glacier.F90 that was removed recently * remove obsolete interstitial schemes * fix 2 minor compilation issues after testing with UFS RTs * fix bug in MG MP * fix near-surface air temperature standard name in GFS_surface_composites_pre * apply tendency cleanup to GFDLMPv3 and TEMPO * fix compilation error * fix typo in TEMPO * debug sgscloud_radpre/post * remove tendency application code from rrtmg_lw/sw_post * change thmpsn to thompson to fix compilation error * fix compilation errors in GFS_radiation_post.F90 * remove Zhao-Carr cloud schemes and combine Xu-Randall cloud fraction calculations * fix array size problem in cs_conv.F90 * refactor RAS tendencies * fix compilation error in rascnv.F90 * change Xu-Randall cloud fraction scheme to be elemental * Fixed too-high lower bound for SMC Deleted code associated with already removed print statements Deleted excess comments. * use new cld_frac_XuRandall function from module_radiation_clouds in RRTMGP scheme * Tidy-up for PR. * modify the cld_frac_XuRandall function call in RRTMGP scheme * Changes to the post L-IAU checks: * Change tfreeze to match that in NoahMP * Only set SLC to SMC if temp newly > tfreez * add the repository update to this PR * Revert "add the repository update to this PR" This reverts commit 565d62c. * fix bug in GFDLMPv3 tendency implementation * remove the printing tests * remove Zhao-Carr schemes from modules in the UFS_SCM_NEPTUNE directory * remove Zhao-Carr microphysics scheme from physics/MP directory * fix hail tendency changes from reviewer suggestions * fix indexing bug in cu_tiedtke caught in code review * changes to RAS tendency application update code from code review * check for flag_for_generic_tendency_due_to_gravity_wave_drag before computing diagnostic tendencies in drag_suite * fix diagnostic tendency bug in physics/GWD/ugwpv1_gsldrag.F90 * remove unused arguments in physics/GWD/ugwpv1_gsldrag_post.F90 * fix tendency diagnostics in physics/GWD/unified_ugwp.F90 * fix merge problem in mp_thompson.meta * add arguments to drag_suite_run called outside of ccpp entry point * initialize dclw variables in cu_ntiedtke * fix loop bounds for ten_q in cu_gf_driver.F90 * fix loop bounds in cu_c3_driver * fix new_q typo in mp_fer_hires.F90 * deallocate locally-allocated variables in MP schemes * update zeroing logic in m_micro_post after review * Update for 10m wind option in fire_behavior module * remove non-ASCII character in canopy_levs.F90 (from previous PR) * Updates to progomega option of saSAS convection scheme * Correction * correction 2 * fix line in SHOC where a tracer was being updated directly * remove old_ozone array since it was not being used * deallocate local variables in satmedmfvdifq at end of run phase * save temperature before modification to pass in to diagnostics in GFS_radiation_post * Remove goto in physics/MP/Morrison_Gettelman/aer_cloud.F * Remove goto in physics/Radiation/radiation_clouds.f * fix diagnostic temp tendency in GFS_MP_generic.F90 for when radar is/isn't available * Correct parameter setting in samfshalcnv to pass debug runs * Name END DO * Remove goto physics/MP/calpreciptype.f90 * Remove goto physics/MP/Morrison_Gettelman/cldwat2m_micro.F * Start goto physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90 * Remove goto physics/SFC_Layer/UFS/module_nst_model.f90 * address saturation vapor pressure out of bounds error in hafs_4_nest RT * update long names to remove 'updated by physics'; change prognostic updraft standard names * remove additional references to Zhao-Carr microphysics * remove Zhao-Carr references from GFS_scnv_generic_post * fix deallocation statement in Thompson MP * Remove go to physics/CONV/C3/cu_c3_sh.F90 * Remove go to physics/PBL/MYJ/module_BL_MYJPBL.F90 * Remove goto physics/MP/Morrison_Gettelman/wv_saturation.F * Again physics/MP/Morrison_Gettelman/wv_saturation.F * physics/MP/Morrison_Gettelman/wv_saturation.F * Typo * Remove goto physics/CONV/C3/cu_c3_deep.F90 * Remove go to physics/CONV/RAS/rascnv.F90 * Typo rascnv.F90 * physics/SFC_Layer/GFDL/gfdl_sfc_layer.F90 * physics/CONV/Grell_Freitas/cu_gf_sh.F90 * Typo module_BL_MYJPBL.F90 * physics/SFC_Layer/MYJ/module_SF_JSFC.F90 * First pass physics/CONV/Grell_Freitas/cu_gf_deep.F90 * physics/CONV/Grell_Freitas/cu_gf_deep.F90 * physics/GWD/ugwp_driver_v0.F * physics/MP/Thompson/module_mp_thompson.F90 * physics/PBL/MYNN_EDMF/module_bl_mynn.F90 * physics/MP/GFDL/v1_2019/gfdl_cloud_microphys_mod.F90 * physics/MP/GFDL/v3_2022/gfdl_cloud_microphys_v3_mod.F90 * Fix compile physics/Radiation/radiation_clouds.f * Compile fixes * Fix for 73 character limit line * Compile fix * Start physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90 * physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90 * fix additional warnings * Fix compile hafsw wcoss2 * Revert rascnv so control_ras_intel b4b on wcoss2 * Use 10-m intepolated winds in the explicit in-canopy diffusion of tracers. Remove hpbl/kpbl update due to explicit in-canopy diffusion. * Clean up commented out code. Correct a truncated source line. * Comment out the integrated-canopy meteorology effect. Keep the lines for future PR with the canopy met effects. * revert radiation_clouds.f --------- Co-authored-by: Grant Firl <grant.firl@noaa.gov> Co-authored-by: VanderleiVargas-NOAA <vanderlei.vargas@noaa.gov> Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov> Co-authored-by: Clara.Draoper-NOAA <clara.draper@noaa.gov> Co-authored-by: Michael Kavulich, Jr <kavulich@ucar.edu> Co-authored-by: Lisa <lisa.bengtsson@noaa.gov> Co-authored-by: Nicholas Szapiro <149816583+NickSzapiro-NOAA@users.noreply.github.com> Co-authored-by: Rhae Sung Kim <rhaesung.kim@noaa.gov> Co-authored-by: Nick Szapiro <nick.szapiro@noaa.gov> Co-authored-by: Nick Szapiro <nick.szapiro@clogin06.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: iri01 <i.t.ivanova@gmail.com> Co-authored-by: iri01 <129897017+iri01@users.noreply.github.com> Co-authored-by: Grant Firl <grant@Macbook-Air-M4.local> Co-authored-by: Tracy <hertneky@ucar.edu> * ufs-dev PR#365 (NCAR#1225) * update standard names to move Xgrs to physics_timestep_initial* and remove *_of_new_state (default name refers to 'current' value) * fix a few unchanged standard names * change some timestep_initial variables to general variables; make satmedmfvdifq return new tendencies and new tendency application block in GFS_PBL_generic_post * Refactor physics tendency calculations - Added tendency variables (`ten_t`, `ten_u`, `ten_v`) for temperature and wind tendencies in SAMF deep and shallow convection schemes. - Updated relevant `.meta` files to reflect changes in variable intent (`inout` -> `in` where appropriate) and added tendencies. - Modified Interstitials (`GFS_DCNV_generic_post`, `GFS_DCNV_generic_pre`, `GFS_SCNV_generic_post`, `GFS_SCNV_generic_pre`) to directly use tendencies instead of saved state variables. - Removed redundant saved variables (`save_u`, `save_v`, `save_t`). - Added `delt` to post interstitials. * update unified_ugwp, ugwpv1, and drag_suite to use new tendency code * save tendency work with GFS_photochemistry * add tracer tendency changes to convection; fix typos in GFS_photochemistry * fix typo in samfdeepcnv.f * save tendency work with Thompson MP * save tendency work with radiation * add FMS to ccpp-physics CMakeLists.txt for fv3 * add initial setting of state in GFS_time_vary_pre.fv3; fix horizontal_dimension in GFS_time_vary_pre.scm * fix metadata in GFS_time_vary_pre.fv3 * add momentum tendency output to mp_thompson and fix intent in metadata * fix array size bug in mp_thompson.F90; cleanup dtend code using new tendency paradigm; cleanup saving of states no longer needed * fix improperly-merged conflict resolution in GFS_photochemistry.F90 * fix access of ntlnc/ntinc access of tracer array when missing * convert many RAD, PBL, GWD, CONV, and MP schemes to return tendencies * convert MG micro and Arakawa-Wu adjustment schemes * convert MYNNEDMF PBL scheme to return tendencies * add changes to MYNN EDMF PBL * add back divide-by-zero bugfix in module_sf_noahmp_glacier.F90 that was removed recently * remove obsolete interstitial schemes * fix 2 minor compilation issues after testing with UFS RTs * fix bug in MG MP * fix near-surface air temperature standard name in GFS_surface_composites_pre * apply tendency cleanup to GFDLMPv3 and TEMPO * fix compilation error * fix typo in TEMPO * debug sgscloud_radpre/post * remove tendency application code from rrtmg_lw/sw_post * change thmpsn to thompson to fix compilation error * fix compilation errors in GFS_radiation_post.F90 * remove Zhao-Carr cloud schemes and combine Xu-Randall cloud fraction calculations * fix array size problem in cs_conv.F90 * refactor RAS tendencies * fix compilation error in rascnv.F90 * change Xu-Randall cloud fraction scheme to be elemental * Fixed too-high lower bound for SMC Deleted code associated with already removed print statements Deleted excess comments. * use new cld_frac_XuRandall function from module_radiation_clouds in RRTMGP scheme * Tidy-up for PR. * modify the cld_frac_XuRandall function call in RRTMGP scheme * Changes to the post L-IAU checks: * Change tfreeze to match that in NoahMP * Only set SLC to SMC if temp newly > tfreez * add the repository update to this PR * Revert "add the repository update to this PR" This reverts commit 565d62c. * fix bug in GFDLMPv3 tendency implementation * remove the printing tests * remove Zhao-Carr schemes from modules in the UFS_SCM_NEPTUNE directory * remove Zhao-Carr microphysics scheme from physics/MP directory * Chagne to not using ozone physics DDT when not active * fix hail tendency changes from reviewer suggestions * fix indexing bug in cu_tiedtke caught in code review * changes to RAS tendency application update code from code review * check for flag_for_generic_tendency_due_to_gravity_wave_drag before computing diagnostic tendencies in drag_suite * fix diagnostic tendency bug in physics/GWD/ugwpv1_gsldrag.F90 * remove unused arguments in physics/GWD/ugwpv1_gsldrag_post.F90 * fix tendency diagnostics in physics/GWD/unified_ugwp.F90 * fix merge problem in mp_thompson.meta * add arguments to drag_suite_run called outside of ccpp entry point * initialize dclw variables in cu_ntiedtke * fix loop bounds for ten_q in cu_gf_driver.F90 * fix loop bounds in cu_c3_driver * fix new_q typo in mp_fer_hires.F90 * deallocate locally-allocated variables in MP schemes * update zeroing logic in m_micro_post after review * Update for 10m wind option in fire_behavior module * remove non-ASCII character in canopy_levs.F90 (from previous PR) * Updates to progomega option of saSAS convection scheme * Correction * correction 2 * fix line in SHOC where a tracer was being updated directly * remove old_ozone array since it was not being used * deallocate local variables in satmedmfvdifq at end of run phase * save temperature before modification to pass in to diagnostics in GFS_radiation_post * Remove goto in physics/MP/Morrison_Gettelman/aer_cloud.F * Remove goto in physics/Radiation/radiation_clouds.f * fix diagnostic temp tendency in GFS_MP_generic.F90 for when radar is/isn't available * Correct parameter setting in samfshalcnv to pass debug runs * Name END DO * Remove goto physics/MP/calpreciptype.f90 * Remove goto physics/MP/Morrison_Gettelman/cldwat2m_micro.F * Start goto physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90 * Remove goto physics/SFC_Layer/UFS/module_nst_model.f90 * address saturation vapor pressure out of bounds error in hafs_4_nest RT * update long names to remove 'updated by physics'; change prognostic updraft standard names * remove additional references to Zhao-Carr microphysics * remove Zhao-Carr references from GFS_scnv_generic_post * fix deallocation statement in Thompson MP * Remove go to physics/CONV/C3/cu_c3_sh.F90 * Remove go to physics/PBL/MYJ/module_BL_MYJPBL.F90 * Remove goto physics/MP/Morrison_Gettelman/wv_saturation.F * Again physics/MP/Morrison_Gettelman/wv_saturation.F * physics/MP/Morrison_Gettelman/wv_saturation.F * Typo * Remove goto physics/CONV/C3/cu_c3_deep.F90 * Remove go to physics/CONV/RAS/rascnv.F90 * Typo rascnv.F90 * physics/SFC_Layer/GFDL/gfdl_sfc_layer.F90 * physics/CONV/Grell_Freitas/cu_gf_sh.F90 * Typo module_BL_MYJPBL.F90 * physics/SFC_Layer/MYJ/module_SF_JSFC.F90 * First pass physics/CONV/Grell_Freitas/cu_gf_deep.F90 * physics/CONV/Grell_Freitas/cu_gf_deep.F90 * physics/GWD/ugwp_driver_v0.F * physics/MP/Thompson/module_mp_thompson.F90 * physics/PBL/MYNN_EDMF/module_bl_mynn.F90 * physics/MP/GFDL/v1_2019/gfdl_cloud_microphys_mod.F90 * physics/MP/GFDL/v3_2022/gfdl_cloud_microphys_v3_mod.F90 * Fix compile physics/Radiation/radiation_clouds.f * Compile fixes * Fix for 73 character limit line * Compile fix * Start physics/SFC_Models/Land/RUC/module_sf_ruclsm.F90 * physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90 * fix additional warnings * Fix compile hafsw wcoss2 * Revert rascnv so control_ras_intel b4b on wcoss2 * Use 10-m intepolated winds in the explicit in-canopy diffusion of tracers. Remove hpbl/kpbl update due to explicit in-canopy diffusion. * Clean up commented out code. Correct a truncated source line. * Bug in gcycle error message * Comment out the integrated-canopy meteorology effect. Keep the lines for future PR with the canopy met effects. --------- Co-authored-by: Grant Firl <grant.firl@noaa.gov> Co-authored-by: VanderleiVargas-NOAA <vanderlei.vargas@noaa.gov> Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov> Co-authored-by: Clara.Draoper-NOAA <clara.draper@noaa.gov> Co-authored-by: Dustin Swales <dustin.swales@noaa.gov> Co-authored-by: Michael Kavulich, Jr <kavulich@ucar.edu> Co-authored-by: Lisa <lisa.bengtsson@noaa.gov> Co-authored-by: Nicholas Szapiro <149816583+NickSzapiro-NOAA@users.noreply.github.com> Co-authored-by: Rhae Sung Kim <rhaesung.kim@noaa.gov> Co-authored-by: Nick Szapiro <nick.szapiro@noaa.gov> Co-authored-by: Nick Szapiro <nick.szapiro@clogin06.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: iri01 <i.t.ivanova@gmail.com> Co-authored-by: iri01 <129897017+iri01@users.noreply.github.com> Co-authored-by: Grant Firl <grant@Macbook-Air-M4.local> Co-authored-by: Tracy <hertneky@ucar.edu> * copy fix from FV3 version to SCM version of GFS_phys_time_vary (NCAR#1227) * UGWP_v0: Scale cdmbgwd(1:2) by inverse square root of dx (NCAR#1218) * GW multiplication factors scaled by inverse square root of dx (#82) * Scale cdmb with the inverse square root of dxres in ugwp_v0 * Scale cleff with the inverse square root of dxres in ugwp_v0 * Replace the non-ascii 1/2 with its ascii representation to satisfy ci test requirement. * Unify cdmbgwd0 and cdmbgwd (#83) * Make cdmbgwd0 to be rank 4 * Unify cdmbgwd0 and cdmbgwd * Remove unnecessary line * Multiply coefficients by a power of 10 * add Alex and Matus as codeowners for ugwp_v0 --------- Co-authored-by: Matus Martini <matus.n.martini.ctr@us.navy.mil> Co-authored-by: Grant Firl <grant.firl@noaa.gov> * New SciDocs for GWv1 release and LandDA capability (NCAR#1226) * add doxygen action * minor changes * minor changes * minor changes * doxy only * Create main.yml * Create jekyll-gh-pages.yml * change * add doxyfile into wkfl * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update ccpp_doxyfile * Update ccpp_doxyfile * update ccpp doxyfile * Update doxygen.yml * update doxyfile * Update doxygen.yml * Update doxygen.yml * update doxyfile * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * Update doxygen.yml * change path * add mactex * add mactex * minor changes * minor fix * try1 * try1 * try2 * updates * update perl * update perl * update path * explicitly install * updates * updates * fix * fix path * fix * fix path * fixes * fix3 * cleanup * restore yml files * hsd updates * add doxygen.yml * update branch * update wflw * test * fix * fix * fix * fix * rearrange steps * oops * . * debug * chng dir * chng dir * chng dir * -landing page * -update para * try to add a backlink, fix typo * fix css link * link path * try cp stylesheet * Add CCPP website * fix * add SRW build, backlink * try mainpage * changes for mainpage * mainpage config * mainpage config * mainpage config * mainpage debug * mainpage debug * mainpage debug * mainpage debug * mainpage debug * fix landing page sidebar. * fix landing page sidebar. * fix landing page sidebar. * fix landing page sidebar. * style updates * mainpage style * mainpage style * hide tree on mainpage * add back tree * try adding backlink * add backlink to other pages * updates migrated from mzhangw * fix missed conflicts * fix syntax * run workflow on this branch * remove branch from workflow run, update doxyfile * mods to mainpag dxy * updates * try update for v7 arg table * turn on scidoc branch for deploy * recurse checkout * fix directory * try fix * update landing page with acknowledgements * fix path * fix path * debug * add prebuild_config for building tables * fix * debug * debug * restructure workflow to work with metadata2html.py * add remaining prebuild configs * attempt fix srwv3 checkout * fix main checkout for landing page, stash prebuild configs * fix syntax * update prebuild location * workflow updates * point to NCAR/main * initial landDA sciDoc commits * point to fork for testing * point to fork for testing in 1 more place * add sciDocs for GW release, some reorg * point to fork * remove main * Changes to GW mainpage * try fix * fix! * fix few things * Add nml links * fix land DA overview page * fixes * oops * oops * updates to GFS_ugwpv1 from Michael Toy and Bo Yang * updates to SAMFdeep from Lisa Bengtsson * updates from Jongil Han for convective, sfc, pbl schemes * Update SciDoc link on README * updates for H2O/Ozone schemes from Qingfu Lui * fix sfclyr link * update reference * try bib fix * try bib tweak * trying to get ref to work * fix bib links * updates for RRTMG from Qingfu Lui * update tracy-fork > main for merging into NCAR/main --------- Co-authored-by: mzhangw <man.zhang@noaa.gov> Co-authored-by: mzhangw <mzhangw@gmail.com> Co-authored-by: Grant Firl <grant.firl@noaa.gov> * run on upstream only since deploy will fail when run from forks (NCAR#1229) Co-authored-by: Grant Firl <grant.firl@noaa.gov> * ufs-dev PR#373 (NCAR#1228) * remove old C3 directory * add C3 as a submodule in a standalone repository * add cu_c3_driver.meta into C3 repository to hook up with CCPP * C3 refactoring - create new CCPP-facing interface compatible with new shared MPAS code. Move to stand alone submodule * Remove non ascii charachters that ccpp doesn't like * translate some comments from Portuguese to English as ccpp doesn't like the ascii format * translate some comments from Portuguese to English as ccpp doesn't like the ascii format 2 * translate some comments from Portuguese to English as ccpp doesn't like the ascii format 3 * more ascii symbols correction * non-ascii charachters * Add host driver directories inside the C3 submodule and rename driver to have suffix _ccpp and _mpas respectively * Add mod_cu_kinds module for consistent kind_phys handling * Fix C3 CCPP plume postprocessing consistency and add neg_check to ensure moisture conservation * Minor updates to avoid compiler warnings associated with subten-variables * Address typos in meta files according to review comments * Correct typo from host model causing inconsistent prebuild * Update C3 commit to 4a41088 and update .gitmodules --------- Co-authored-by: Lisa <lisa.bengtsson@noaa.gov> * number_of_openmp_threads --> number_of_physics_threads * Update submodule pointer for C3 * Add optional attribute for tke vars in cires_ugwp * Bug fix in physics/GWD/cires_ugwp.meta * Add back in metadata file changes that were lost? * Remove changes accidentally intrioduced * Remove changes accidentally intrioduced * Remove cmakelists. Not used * Remove commented line * Updates for TEMPO changes * One more TEMPO change * Update submodule name in .gitmodules. Not impactful sice path os set correctly, but still inconsistent. * Update physics submodules --------- Co-authored-by: Tracy <hertneky@ucar.edu> Co-authored-by: Grant Firl <grant.firl@noaa.gov> Co-authored-by: Soren Rasmussen <s.c.rasmussen@gmail.com> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> Co-authored-by: Tracy Hertneky <39317287+hertneky@users.noreply.github.com> Co-authored-by: mzhangw <man.zhang@noaa.gov> Co-authored-by: mzhangw <mzhangw@gmail.com> Co-authored-by: Qingfu Liu <Qingfu.Liu@noaa.gov> Co-authored-by: Matus Martini <matusmartini@users.noreply.github.com> Co-authored-by: Clara.Draoper-NOAA <clara.draper@noaa.gov> Co-authored-by: Michael Kavulich, Jr <kavulich@ucar.edu> Co-authored-by: Lisa <lisa.bengtsson@noaa.gov> Co-authored-by: Rhae Sung Kim <rhaesung.kim@noaa.gov> Co-authored-by: dustinswales <dswales@ucar.edu> Co-authored-by: VanderleiVargas-NOAA <vanderlei.vargas@noaa.gov> Co-authored-by: Grant Firl <grant@Macbook-Air-M4.local> Co-authored-by: Nicholas Szapiro <149816583+NickSzapiro-NOAA@users.noreply.github.com> Co-authored-by: Nick Szapiro <nick.szapiro@noaa.gov> Co-authored-by: Nick Szapiro <nick.szapiro@clogin06.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: iri01 <i.t.ivanova@gmail.com> Co-authored-by: iri01 <129897017+iri01@users.noreply.github.com> Co-authored-by: Matus Martini <matus.n.martini.ctr@us.navy.mil>
1 parent 8ac9c2e commit 5ef5adc

86 files changed

Lines changed: 638 additions & 3218 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.gitmodules‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,3 @@
1414
path = physics/CONV/C3
1515
url = https://github.com/ufs-community/c3
1616
branch = main
17-
18-

‎CMakeLists.txt‎

Lines changed: 0 additions & 235 deletions
This file was deleted.

‎CODEOWNERS‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
# Default codeowners for files that don't have specific owners:
66

7-
* @grantfirl @rhaesung @Qingfu-Liu @dustinswales @mzhangw
7+
* @grantfirl @rhaesung @Qingfu-Liu @dustinswales @mzhangw @climbfuji
88

99

1010
# The following lines are from the CCPP Primary Schemes Points of Contact
@@ -30,7 +30,7 @@ physics/GWD/drag_suite.* @md
3030
physics/GWD/gwdc.* @Songyou184 @grantfirl @rhaesung @Qingfu-Liu @dustinswales
3131
physics/GWD/gwdps.* @Songyou184 @grantfirl @rhaesung @Qingfu-Liu @dustinswales
3232
physics/GWD/rayleigh_damp.* @yangfanglin @grantfirl @rhaesung @Qingfu-Liu @dustinswales
33-
physics/GWD/ugwp_driver_v0.F90 @mdtoyNOAA @grantfirl @rhaesung @Qingfu-Liu @dustinswales
33+
physics/GWD/ugwp_driver_v0.F90 @mdtoyNOAA @matusmartini @areinecke @grantfirl @rhaesung @Qingfu-Liu @dustinswales
3434
physics/GWD/ugwpv1_gsldrag.* @mdtoyNOAA @BoYang-NOAA @grantfirl @rhaesung @Qingfu-Liu @dustinswales
3535
physics/GWD/ugwpv1_gsldrag_post.* @mdtoyNOAA @BoYang-NOAA @grantfirl @rhaesung @Qingfu-Liu @dustinswales
3636
physics/GWD/unified_ugwp* @mdtoyNOAA @grantfirl @rhaesung @Qingfu-Liu @dustinswales

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Please see more information about the CCPP at the locations below.
77
- [CCPP website hosted by the Developmental Testbed Center (DTC)](https://dtcenter.org/ccpp)
88
- [CCPP public release information](https://dtcenter.org/community-code/common-community-physics-package-ccpp/download)
99
- [CCPP Technical Documentation](https://ccpp-techdoc.readthedocs.io/en/v6.0.0/)
10-
- [CCPP Scientific Documentation](https://dtcenter.ucar.edu/GMTB/v6.0.0/sci_doc/index.html)
10+
- [CCPP Scientific Documentation](https://ncar.github.io/ccpp-physics/)
1111
- [CCPP Physics GitHub wiki](https://github.com/NCAR/ccpp-physics/wiki)
1212
- [CCPP Framework GitHub wiki](https://github.com/NCAR/ccpp-framework/wiki)
1313

‎physics/CONV/C3‎

‎physics/GWD/cires_ugwp.F90‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ module cires_ugwp
1616

1717
use machine, only: kind_phys
1818

19-
use cires_ugwpv0_module, only: knob_ugwp_version, cires_ugwpv0_mod_init, cires_ugwpv0_mod_finalize
19+
use cires_ugwpv0_module, only: knob_ugwp_version, cires_ugwpv0_mod_init, cires_ugwpv0_mod_final
2020
use ugwp_driver_v0
2121
use gwdps, only: gwdps_run
2222
use cires_ugwp_triggers
@@ -25,7 +25,7 @@ module cires_ugwp
2525

2626
private
2727

28-
public cires_ugwp_init, cires_ugwp_run, cires_ugwp_finalize
28+
public cires_ugwp_init, cires_ugwp_run, cires_ugwp_final
2929

3030
logical :: is_initialized = .False.
3131

@@ -103,16 +103,16 @@ subroutine cires_ugwp_init (me, master, nlunit, input_nml_file, logunit, &
103103
end subroutine cires_ugwp_init
104104

105105
! -----------------------------------------------------------------------
106-
! finalize of cires_ugwp (_finalize)
106+
! finalize of cires_ugwp (_final)
107107
! -----------------------------------------------------------------------
108108

109109
!> The subroutine finalizes the CIRES UGWP
110110
#if 0
111-
!> \section arg_table_cires_ugwp_finalize Argument Table
112-
!! \htmlinclude cires_ugwp_finalize.html
111+
!> \section arg_table_cires_ugwp_final Argument Table
112+
!! \htmlinclude cires_ugwp_final.html
113113
!!
114114
#endif
115-
subroutine cires_ugwp_finalize(errmsg, errflg)
115+
subroutine cires_ugwp_final(errmsg, errflg)
116116

117117
implicit none
118118
!
@@ -125,11 +125,11 @@ subroutine cires_ugwp_finalize(errmsg, errflg)
125125

126126
if (.not.is_initialized) return
127127

128-
call cires_ugwpv0_mod_finalize()
128+
call cires_ugwpv0_mod_final()
129129

130130
is_initialized = .false.
131131

132-
end subroutine cires_ugwp_finalize
132+
end subroutine cires_ugwp_final
133133

134134
! -----------------------------------------------------------------------
135135
! originally from ugwp_driver_v0.f
@@ -244,7 +244,7 @@ subroutine cires_ugwp_run(do_ugwp, me, master, im, levs, ntrac, dtp, kdt, lonr
244244
real(kind=kind_phys), intent(in), dimension(:) :: rain
245245

246246
integer, intent(in) :: ntke
247-
real(kind=kind_phys), intent(in), dimension(:,:) :: q_tke, dqdt_tke
247+
real(kind=kind_phys), intent(in), dimension(:,:), optional :: q_tke, dqdt_tke
248248

249249
logical, intent(in) :: lprnt
250250
integer, intent(in) :: ipr

‎physics/GWD/cires_ugwp.meta‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@
163163

164164
########################################################################
165165
[ccpp-arg-table]
166-
name = cires_ugwp_finalize
166+
name = cires_ugwp_final
167167
type = scheme
168168
[errmsg]
169169
standard_name = ccpp_error_message
@@ -791,6 +791,7 @@
791791
type = real
792792
kind = kind_phys
793793
intent = in
794+
optional = True
794795
[dqdt_tke]
795796
standard_name = process_split_cumulative_tendency_of_turbulent_kinetic_energy
796797
long_name = turbulent kinetic energy tendency due to model physics
@@ -799,6 +800,7 @@
799800
type = real
800801
kind = kind_phys
801802
intent = in
803+
optional = True
802804
[lprnt]
803805
standard_name = flag_print
804806
long_name = control flag for diagnostic print out

‎physics/GWD/cires_ugwp_module.F90‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ module cires_ugwpv0_module
7171
!/
7272
!
7373
! allocatable arrays, initilized during "cires_ugwp_init" &
74-
! released during "cires_ugwp_finalize"
74+
! released during "cires_ugwp_final"
7575
!
7676
real, allocatable :: kvg(:), ktg(:), krad(:), kion(:)
7777
real, allocatable :: zkm(:), pmb(:)
@@ -227,11 +227,11 @@ subroutine cires_ugwpv0_mod_init (me, master, nlunit, input_nml_file, logunit, &
227227
end subroutine cires_ugwpv0_mod_init
228228
!
229229
! -----------------------------------------------------------------------
230-
! finalize of cires_ugwp (_finalize)
230+
! finalize of cires_ugwp (_final)
231231
! -----------------------------------------------------------------------
232232

233233
!> This subroutine deallocate sources/spectra and some diagnostics.
234-
subroutine cires_ugwpv0_mod_finalize
234+
subroutine cires_ugwpv0_mod_final
235235
!
236236
! deallocate sources/spectra & some diagnostics need to find where "deaalocate them"
237237
! before "end" of the FV3GFS
@@ -245,5 +245,5 @@ subroutine cires_ugwpv0_mod_finalize
245245
deallocate( zkm, pmb )
246246
deallocate( rfdis, rfdist)
247247

248-
end subroutine cires_ugwpv0_mod_finalize
248+
end subroutine cires_ugwpv0_mod_final
249249
end module cires_ugwpv0_module

‎physics/GWD/cires_ugwpv1_module.F90‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ module cires_ugwpv1_module
9292

9393
!
9494
! allocatable arrays, initilized during "cires_ugwp_init" &
95-
! released during "cires_ugwp_finalize"
95+
! released during "cires_ugwp_final"
9696
!
9797
real(kind=kind_phys), allocatable :: kvg(:), ktg(:), krad(:), kion(:)
9898
real(kind=kind_phys), allocatable :: zkm(:), pmb(:)

0 commit comments

Comments
 (0)