Skip to content

Commit 3cecc93

Browse files
authored
Merge pull request #874 from unilabsim/fix/860-device-parity-production-reward
test: restore production reward config in device parity fixture
2 parents d4bd170 + 7f37d2a commit 3cecc93

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

tests/training/test_device_lifecycle.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,11 +163,12 @@ def _host_device_fixture(*, num_envs: int, seed: int) -> Iterator[_HostDeviceFix
163163
observation_noise_level=0.0,
164164
observation_noise_seed=None,
165165
)
166+
# Use the production reward config (feet_phase, non-zero gait_frequency,
167+
# non-zero vel_limit) so the device implementation's independent Bezier /
168+
# gait-phase math is covered by the oracle. Stripping those fields was a
169+
# pre-existing workaround that left the highest-risk device term without
170+
# any host↔device equivalence evidence (issue #860).
166171
assert cfg.reward_config is not None
167-
cfg.reward_config.scales.pop("feet_phase")
168-
cfg.reward_config.gait_frequency = 0.0
169-
cfg.reset_base_qvel_limit = 0.0
170-
cfg.commands.vel_limit = [[0.0, 0.0, 0.0], [0.0, 0.0, 0.0]]
171172
assert cfg.scene is not None
172173

173174
host_cfg = deepcopy(cfg)

0 commit comments

Comments
 (0)