Replace flyte-core subchart with direct templates (FAB-277)

Add dedicated templates for flyteadmin and flyteconsole that render
identically to the flyte-core subchart output. The subchart is now
suppressed by default via `flyte.useDirectTemplates: true`.

New templates:
- templates/flyteadmin/ — configmap, deployment, hpa, rbac, secret,
  service, secret-auth (7 files)
- templates/flyteconsole/ — configmap, deployment, service (3 files)

Absorbed subchart helpers into _flyte-core.tpl:
- storage.base, storage (S3/GCS/sandbox/custom)
- databaseSecret.volume, databaseSecret.volumeMount
- flyteadmin.podLabels, flyteconsole.* helpers
- flyte.chart (now uses controlplane chart identity)

Values changes:
- flyte.useDirectTemplates: true (default on, opt-out with false)
- flyte.flyteadmin.enabled: false (subchart suppressed)
- flyte.flyteconsole.enabled: false (subchart suppressed)
- flyte.secrets.adminOauthClientCredentials.enabled: false

**Breaking change — requires `helm upgrade --force`:**
Labels on flyteadmin/flyteconsole resources change:
- `helm.sh/chart` changes from `flyte-core-v1.16.1` to `controlplane-<version>`
- `app.kubernetes.io/managed-by: Helm` is now included (was commented out)

Selector labels (`app.kubernetes.io/name`, `app.kubernetes.io/instance`)
are unchanged, so pod scheduling is not affected.

**Legacy subchart behavior:** Set `flyte.useDirectTemplates: false` and
re-enable `flyte.flyteadmin.enabled: true`, `flyte.flyteconsole.enabled: true`,
`flyte.secrets.adminOauthClientCredentials.enabled: true`.

ref FAB-277

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: mhotan

charts/controlplane/templates/_flyte-core.tpl

@@ -1,7 +1,32 @@
+{{/*
+Flyte component helpers.
+
+These were originally defined in the flyte-core subchart _helpers.tpl and overridden
+here. As part of FAB-277 (remove flyte-core subchart), they are now the canonical
+definitions. Direct templates in templates/flyteadmin/ and templates/flyteconsole/
+use these helpers.
+
+NOTE: Labels intentionally differ from the old subchart output:
+  - helm.sh/chart uses the controlplane chart version (was flyte-core-v1.16.1)
+  - app.kubernetes.io/managed-by is included (was commented out)
+  This requires `helm upgrade --force` when upgrading from subchart-based releases.
+*/}}
+
 {{- define "flyte.namespace" -}}
 {{- default .Release.Namespace .Values.forceNamespace | trunc 63 | trimSuffix "-" -}}
 {{- end -}}
 
+{{/* Chart label — uses controlplane chart identity (breaking change from subchart) */}}
+{{- define "flyte.chart" -}}
+{{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" -}}
+{{- end -}}
+
+{{- define "flyte.selectorLabels" -}}
+app.kubernetes.io/instance: {{ .Release.Name }}
+{{- end }}
+
+{{/* ---- flyteadmin ---- */}}
+
 {{- define "flyteadmin.name" -}}
 flyteadmin
 {{- end -}}
@@ -11,16 +36,154 @@ app.kubernetes.io/name: {{ template "flyteadmin.name" . }}
 app.kubernetes.io/instance: {{ .Release.Name }}
 {{- end -}}
 
-{{/*
-Selector labels
-*/}}
-{{- define "flyte.selectorLabels" -}}
+{{- define "flyteadmin.labels" -}}
+{{ include "flyteadmin.selectorLabels" . }}
+helm.sh/chart: {{ include "flyte.chart" . }}
+app.kubernetes.io/managed-by: {{ .Release.Service }}
+{{- end -}}
+
+{{- define "flyteadmin.podLabels" -}}
+{{ include "flyteadmin.labels" . }}
+{{- with .Values.flyte.flyteadmin.podLabels }}
+{{ toYaml . }}
+{{- end }}
+{{- end -}}
+
+{{/* ---- flyteconsole ---- */}}
+
+{{- define "flyteconsole.name" -}}
+flyteconsole
+{{- end -}}
+
+{{- define "flyteconsole.selectorLabels" -}}
+app.kubernetes.io/name: {{ template "flyteconsole.name" . }}
 app.kubernetes.io/instance: {{ .Release.Name }}
+{{- end -}}
+
+{{- define "flyteconsole.labels" -}}
+{{ include "flyteconsole.selectorLabels" . }}
+helm.sh/chart: {{ include "flyte.chart" . }}
+app.kubernetes.io/managed-by: {{ .Release.Service }}
+{{- end -}}
+
+{{- define "flyteconsole.podLabels" -}}
+{{ include "flyteconsole.labels" . }}
+{{- with .Values.flyte.flyteconsole.podLabels }}
+{{ toYaml . }}
 {{- end }}
+{{- end -}}
 
+{{/* ---- cacheservice (already has dedicated templates, helpers referenced there) ---- */}}
 
-{{- define "flyteadmin.labels" -}}
-{{ include "flyteadmin.selectorLabels" . }}
+{{- define "cacheservice.name" -}}
+cacheservice
+{{- end -}}
+
+{{- define "cacheservice.selectorLabels" -}}
+app.kubernetes.io/name: {{ template "cacheservice.name" . }}
+app.kubernetes.io/instance: {{ .Release.Name }}
+{{- end -}}
+
+{{- define "cacheservice.labels" -}}
+{{ include "cacheservice.selectorLabels" . }}
 helm.sh/chart: {{ include "flyte.chart" . }}
-#app.kubernetes.io/managed-by: {{ .Release.Service }}
+app.kubernetes.io/managed-by: {{ .Release.Service }}
 {{- end -}}
+
+{{- define "cacheservice.podLabels" -}}
+{{ include "cacheservice.labels" . }}
+{{- with .Values.flyte.cacheservice.podLabels }}
+{{ toYaml . }}
+{{- end }}
+{{- end -}}
+
+{{/* ---- Database secret volume helpers ---- */}}
+
+{{- define "databaseSecret.volume" -}}
+{{- with .Values.flyte.common.databaseSecret.name -}}
+- name: {{ . }}
+  secret:
+    secretName: {{ . }}
+{{- end }}
+{{- end }}
+
+{{- define "databaseSecret.volumeMount" -}}
+{{- with .Values.flyte.common.databaseSecret.name -}}
+- mountPath: /etc/db
+  name: {{ . }}
+{{- end }}
+{{- end }}
+
+{{/* cacheservice uses the same pattern but was historically separate */}}
+{{- define "cacheservice-databaseSecret.volume" -}}
+{{- with .Values.flyte.common.databaseSecret.name -}}
+- name: {{ . }}
+  secret:
+    secretName: {{ . }}
+{{- end }}
+{{- end }}
+
+{{- define "cacheservice-databaseSecret.volumeMount" -}}
+{{- with .Values.flyte.common.databaseSecret.name -}}
+- mountPath: /etc/db
+  name: {{ . }}
+{{- end }}
+{{- end }}
+
+{{/* ---- Storage helpers (from flyte-core _helpers.tpl) ---- */}}
+
+{{- define "storage.base" -}}
+storage:
+{{- if eq .Values.flyte.storage.type "s3" }}
+  type: s3
+  container: {{ .Values.flyte.storage.bucketName | quote }}
+  connection:
+    auth-type: {{ .Values.flyte.storage.s3.authType }}
+    region: {{ .Values.flyte.storage.s3.region }}
+    {{- if .Values.flyte.storage.s3.endpoint }}
+    endpoint: {{ .Values.flyte.storage.s3.endpoint }}
+    {{- end }}
+    {{- if eq .Values.flyte.storage.s3.authType "accesskey" }}
+    access-key: {{ .Values.flyte.storage.s3.accessKey }}
+    secret-key: {{ .Values.flyte.storage.s3.secretKey }}
+    {{- end }}
+{{- else if eq .Values.flyte.storage.type "gcs" }}
+  type: stow
+  stow:
+    kind: google
+    config:
+      json: ""
+      project_id: {{ .Values.flyte.storage.gcs.projectId }}
+      scopes: https://www.googleapis.com/auth/cloud-platform
+  container: {{ .Values.flyte.storage.bucketName | quote }}
+{{- else if eq .Values.flyte.storage.type "sandbox" }}
+  type: minio
+  container: {{ .Values.flyte.storage.bucketName | quote }}
+  stow:
+    kind: s3
+    config:
+      access_key_id: minio
+      auth_type: accesskey
+      secret_key: miniostorage
+      disable_ssl: true
+      endpoint: http://minio.{{ .Release.Namespace }}.svc.cluster.local:9000
+      region: us-east-1
+  signedUrl:
+    stowConfigOverride:
+      endpoint: http://minio.{{ .Release.Namespace }}.svc.cluster.local:9000
+{{- else if eq .Values.flyte.storage.type "custom" }}
+{{- with .Values.flyte.storage.custom -}}
+  {{ tpl (toYaml .) $ | nindent 2 }}
+{{- end }}
+{{- end }}
+{{- end }}
+
+{{- define "storage" -}}
+{{ include "storage.base" .}}
+  enable-multicontainer: {{ .Values.flyte.storage.enableMultiContainer }}
+  limits:
+    maxDownloadMBs: {{ .Values.flyte.storage.limits.maxDownloadMBs }}
+  cache:
+    max_size_mbs: {{ .Values.flyte.storage.cache.maxSizeMBs }}
+    target_gc_percent: {{ .Values.flyte.storage.cache.targetGCPercent }}
+{{- end }}

charts/controlplane/templates/flyteadmin/configmap.yaml

@@ -0,0 +1,103 @@
+{{- if .Values.flyte.useDirectTemplates }}
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: flyte-admin-clusters-config
+  namespace: {{ template "flyte.namespace" . }}
+  labels: {{ include "flyteadmin.labels" . | nindent 4 }}
+data:
+{{- with .Values.flyte.configmap.clusters }}
+  clusters.yaml: |
+    clusters:
+      {{- tpl (toYaml .) $ | nindent 6 }}
+{{- end }}
+---
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: flyte-admin-base-config
+  namespace: {{ template "flyte.namespace" . }}
+  labels: {{ include "flyteadmin.labels" . | nindent 4 }}
+data:
+{{- with .Values.flyte.db.admin }}
+  db.yaml: | {{ tpl (toYaml .) $ | nindent 4 }}
+{{- end }}
+{{- with .Values.flyte.configmap.domain }}
+  domain.yaml: | {{ tpl (toYaml .) $ | nindent 4 }}
+{{- end }}
+{{- with .Values.flyte.configmap.logger }}
+  logger.yaml: | {{ tpl (toYaml .) $ | nindent 4 }}
+{{- end }}
+{{- with .Values.flyte.configmap.otel }}
+  otel.yaml: | {{ tpl (toYaml .) $ | nindent 4 }}
+{{- end }}
+{{- with .Values.flyte.configmap.adminServer }}
+  server.yaml: | {{ tpl (toYaml .) $ | nindent 4 }}
+{{- end }}
+{{- with .Values.flyte.configmap.remoteData }}
+  remoteData.yaml: | {{ tpl (toYaml .) $ | nindent 4 }}
+{{- end }}
+{{- with .Values.flyte.configmap.namespace_config }}
+  namespace_config.yaml: | {{ toYaml . | nindent 4 }}
+{{- end }}
+{{- with .Values.flyte.configmap.clusterpool_config }}
+  clusterpool_config.yaml: | {{ toYaml . | nindent 4 }}
+{{- end }}
+{{- if not .Values.flyte.storage.secretName }}
+  storage.yaml: | {{ tpl (include "storage" .) $ | nindent 4 }}
+{{- end }}
+{{- with .Values.flyte.configmap.task_resource_defaults }}
+  task_resource_defaults.yaml: | {{ tpl (toYaml .) $ | nindent 4 }}
+{{- end }}
+{{- if .Values.flyte.workflow_notifications.enabled }}
+  notifications.yaml: |
+    notifications:
+      type: {{ .Values.flyte.workflow_notifications.config.notifications.type }}
+      {{- if not .Values.flyte.workflow_notifications.config.notifications.aws }}
+      {{- with .Values.flyte.workflow_notifications.config.notifications.region }}
+      region: {{ tpl . $ }}
+      {{- end }}
+      {{- end }}
+      {{- if eq .Values.flyte.workflow_notifications.config.notifications.type "aws" }}
+      {{- with .Values.flyte.workflow_notifications.config.notifications.aws }}
+      aws: {{ tpl (toYaml .) $ | nindent 8 }}
+      {{- end }}
+      {{- end }}
+      {{- if eq .Values.flyte.workflow_notifications.config.notifications.type "gcp" }}
+      {{- with .Values.flyte.workflow_notifications.config.notifications.gcp }}
+      gcp: {{ tpl (toYaml .) $ | nindent 8 }}
+      {{- end }}
+      {{- end }}
+      {{- with .Values.flyte.workflow_notifications.config.notifications.publisher }}
+      publisher: {{- tpl (toYaml .) $ | nindent 8 }}
+      {{- end }}
+      {{- with .Values.flyte.workflow_notifications.config.notifications.processor }}
+      processor: {{- tpl (toYaml .) $ | nindent 8 }}
+      {{- end }}
+      {{- with .Values.flyte.workflow_notifications.config.notifications.emailer }}
+      emailer: {{- toYaml . | nindent 8 }}
+      {{- end }}
+{{- end }}
+{{- if .Values.flyte.external_events.enable }}
+{{- with .Values.flyte.external_events }}
+  external_events.yaml: |
+    externalEvents: {{ tpl (toYaml .) $ | nindent 6 }}
+{{- end }}
+{{- end }}
+{{- if .Values.flyte.cloud_events.enable }}
+{{- with .Values.flyte.cloud_events }}
+  cloud_events.yaml: |
+    cloudEvents: {{ tpl (toYaml .) $ | nindent 6 }}
+{{- end }}
+{{- end }}
+{{- if .Values.flyte.cluster_resource_manager.enabled }}
+  {{- with .Values.flyte.cluster_resource_manager.config }}
+  cluster_resources.yaml: | {{ tpl (toYaml .) $ | nindent 4 }}
+  {{- end }}
+{{- end }}
+{{- if and .Values.flyte.workflow_scheduler.enabled (eq .Values.flyte.workflow_scheduler.type "aws") }}
+  {{- with .Values.flyte.workflow_scheduler.config }}
+  scheduler.yaml: | {{ tpl (toYaml .) $ | nindent 4 }}
+  {{- end }}
+{{- end }}
+{{- end }}