refactor(chatView): Enhance chatView by avoiding webview destruction and boosting operation speed (#70)

* refactor(chatView): Enhance chatView by avoiding webview destruction and boosting operation speed

* Optimize chatView request: Switch from loop waiting to waiting for chatView onLoad

Author: meteor199

Diff for: src/base/common/defer.ts

@@ -0,0 +1,32 @@
+interface Deferred<T> {
+	abort: () => void;
+	resolve: (value: T) => void;
+	reject: (reason?: unknown) => void;
+	promise: Promise<T>;
+}
+
+export function defer<T>(signal?: AbortSignal): Deferred<T> {
+	const ac = new AbortController();
+	const dtd = {} as Deferred<T>;
+
+	dtd.promise = new Promise((resolve, reject) => {
+		dtd.resolve = resolve;
+		dtd.reject = reject;
+	});
+
+	function onDidAbort() {
+		dtd.reject(new Error('user aborted'));
+	}
+
+	ac.signal.addEventListener('abort', onDidAbort);
+
+	if (signal) {
+		signal.addEventListener('abort', onDidAbort);
+	}
+
+	dtd.abort = function () {
+		ac.abort();
+	};
+
+	return dtd;
+}

Diff for: src/commands/commandsService.ts

@@ -90,8 +90,6 @@ export class CommandsService {
 			return;
 		}
 
-		// TODO hack message render empty
-		await setTimeout(800);
 
 		const selection = editor.selection;
 		if (selection.isEmpty) {
@@ -124,8 +122,6 @@ export class CommandsService {
 
 		await chat.show();
 
-		// TODO hack message render empty
-		await setTimeout(800);
 		await addHighlightedCodeToContext(editor, selection, chat);
 
 		await setTimeout(800);
@@ -147,8 +143,6 @@ export class CommandsService {
 
 		await chat.show();
 
-		// TODO hack message render empty
-		await setTimeout(600);
 		await addHighlightedCodeToContext(editor, selection, chat);
 
 		await setTimeout(800);

Diff for: src/commands/commandsUtils.ts

@@ -81,7 +81,7 @@ export async function addHighlightedCodeToContext(editor: TextEditor, selection:
 		},
 	};
 
-	await chat.send('highlightedCode', {
+	await chat.request('highlightedCode', {
 		rangeInFileWithContents,
 	});
 }

Diff for: src/editor/views/chat/chatViewService.ts

@@ -29,6 +29,9 @@ export class ChatViewService {
 		return this.continueViewProvider.send(type, message);
 	}
 
+	request(type: string, message?: unknown) {
+		return this.continueViewProvider.request(type, message);
+	}
 	postMessage(message: unknown) {
 		return this.continueViewProvider.postMessage(message);
 	}
@@ -46,6 +49,8 @@ export class ChatViewService {
 	}
 
 	register() {
-		return window.registerWebviewViewProvider(CHAT_VIEW_ID, this.continueViewProvider);
+		return window.registerWebviewViewProvider(CHAT_VIEW_ID, this.continueViewProvider, {
+			webviewOptions: { retainContextWhenHidden: true },
+		});
 	}
 }

Diff for: src/editor/views/chat/continue/continueMessages.ts

@@ -209,3 +209,9 @@ export class ContinueEvent<
 		});
 	}
 }
+
+export interface Message<T = any> {
+    messageType: string;
+    messageId: string;
+    data: T;
+}

Diff for: src/editor/views/chat/continue/continueViewProvider.ts

@@ -19,6 +19,7 @@ import {
 
 import { CMD_CODEASPACE_ANALYSIS, CMD_CODEASPACE_KEYWORDS_ANALYSIS } from 'base/common/configuration/configuration';
 import { ConfigurationService } from 'base/common/configuration/configurationService';
+import { defer } from 'base/common/defer';
 import { ChatMessageRole, type IChatMessage } from 'base/common/language-models/languageModels';
 import { LanguageModelsService } from 'base/common/language-models/languageModelsService';
 import { logger } from 'base/common/log/log';
@@ -33,13 +34,15 @@ import {
 	type FromWebviewMessage,
 	type IChatMessageParam,
 	IChatModelResource,
+	Message,
 	PersistedSessionInfo,
 	SessionInfo,
 	type ShowErrorMessage,
 } from './continueMessages';
 
 export class ContinueViewProvider extends AbstractWebviewViewProvider implements WebviewViewProvider {
 	private historySaveDir = path.join(os.homedir(), '.autodev/sessions');
+	private _readyDefer = defer<void>();
 
 	constructor(
 		private context: ExtensionContext,
@@ -48,6 +51,7 @@ export class ContinueViewProvider extends AbstractWebviewViewProvider implements
 	) {
 		super(context);
 
+		logger.debug('ContinueViewProvider init');
 		// TODO disposable
 		configService.onDidChange(event => {
 			if (event.affectsConfiguration('autodev.chat.models')) {
@@ -59,6 +63,10 @@ export class ContinueViewProvider extends AbstractWebviewViewProvider implements
 		});
 	}
 
+	ready() {
+		return this._readyDefer.promise;
+	}
+
 	newSession(prompt?: string) {
 		if (prompt) {
 			this.send('newSessionWithPrompt', { prompt });
@@ -79,6 +87,28 @@ export class ContinueViewProvider extends AbstractWebviewViewProvider implements
 		});
 	}
 
+	async request(type: string, data?: unknown): Promise<boolean> {
+		const messageId = randomUUID();
+
+		await this.ready();
+
+		return new Promise((resolve, reject) => {
+			const disposable = this._webview!.onDidReceiveMessage((msg: Message) => {
+				if (msg.messageId === messageId) {
+					logger.debug(`message received, messageID: ${messageId}`);
+					resolve(msg.data);
+					disposable?.dispose();
+				}
+			});
+			this.postMessage({
+				messageId: messageId,
+				messageType: type,
+				data: data,
+			});
+			logger.debug(`send success, messageType:${type},messageID:${messageId}`);
+		});
+	}
+
 	async provideWebviewView(webviewView: WebviewView): Promise<void> {
 		const webview = webviewView.webview;
 		const extensionUri = this.context.extensionUri;
@@ -130,6 +160,7 @@ export class ContinueViewProvider extends AbstractWebviewViewProvider implements
 
 			switch (payload.messageType) {
 				case 'onLoad':
+					logger.debug('sidebar webview onLoad ');
 					this.handleViewLoad(new ContinueEvent(webview, payload));
 					break;
 
@@ -209,6 +240,7 @@ export class ContinueViewProvider extends AbstractWebviewViewProvider implements
 			vscMachineId: '1111',
 			vscMediaUrl: '',
 		});
+		this._readyDefer.resolve();
 	}
 
 	private handleGetOpenFiles(event: ContinueEvent<'getOpenFiles'>) {