Merge pull request #134 from unzerdev/CC-126/liability_shift_indicator

Cc 126/liability shift indicator

Author: Ryouzanpaku

CHANGELOG.md

@@ -11,6 +11,8 @@ to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 *   Enable PHP version 8.2 in composer.json.
 *   Add paypage property to `Payment` class.
+*   Add constants `\UnzerSDK\Constants\LiabilityShiftIndicator` for valid liability shift indicator values, relevant for card payment.
+    *   Charge and authorize transactions with card can contain that indicator in Api Response. (Accesed like:`$transaction->getAdditionalTransactionData()->card->liability`)
 
 ### Changed
 

src/Constants/LiabilityShiftIndicator.php

@@ -0,0 +1,29 @@
+<?php
+/**
+ * This file contains the valid Liability shift indicator values
+ *
+ * Copyright (C) 2020 - today Unzer E-Com GmbH
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * @link  https://dev.unzer.com/
+ *
+ * @package  UnzerSDK\Constants
+ */
+namespace UnzerSDK\Constants;
+
+class LiabilityShiftIndicator
+{
+    public const ISSUER    = 'ISSUER';
+    public const MERCHANT = 'MERCHANT';
+}

src/Services/ResourceService.php

@@ -447,7 +447,6 @@ public function fetchPayPage($payPage): Paypage
         return $payPageObject;
     }
 
-
     /**
      * {@inheritDoc}
      */

test/integration/PaymentTypes/CardTest.php

@@ -265,6 +265,32 @@ public function cardWith3dsFlagShouldSetItAlsoInTransactions(): void
         $this->assertFalse($charge->isCard3ds());
     }
 
+    /**
+     * Verify card transaction returns Liability Shift Indicator.
+     *
+     * @test
+     * @dataProvider cardTransactionReturnsLiabilityIndicatorDP()
+     */
+    public function cardTransactionReturnsLiabilityIndicator($pan): void
+    {
+        $this->markTestSkipped('Requires a special config for card.');
+        $card = $this->createCardObject()->setNumber($pan)->set3ds(false);
+        /** @var Card $card */
+        $card = $this->unzer->createPaymentType($card);
+        $charge = $card->charge(12.34, 'EUR', 'https://docs.unzer.com');
+
+        // Verify Liability Indicator in response.
+        $this->assertNotNull($charge->getAdditionalTransactionData());
+        $this->assertNotNull($charge->getAdditionalTransactionData()->card->liability);
+
+        // Verify Liability Indicator In payment response.
+        $fetchedPayment = $this->unzer->fetchPayment($charge->getPaymentId());
+        $paymentCharge = $fetchedPayment->getCharge('s-chg-1', true);
+        $this->assertNotNull($paymentCharge->getAdditionalTransactionData()->card->liability);
+
+        $this->getUnzerObject()->fetchCharge($charge);
+    }
+
     /**
      * Verify that the card can perform an authorization with a card.
      *
@@ -670,4 +696,14 @@ public function invalidRecurrenceTypesDP(): array
             'number' => [42],
         ];
     }
+
+    public function cardTransactionReturnsLiabilityIndicatorDP()
+    {
+        return [
+            '6799851000000032' => ['6799851000000032'],
+            '5453010000059543' => ['5453010000059543'],
+            '4711100000000000' => ['4711100000000000'],
+            '4012001037461114' => ['4012001037461114']
+        ];
+    }
 }

test/unit/Resources/PaymentTest.php

@@ -819,7 +819,7 @@ public function handleResponseShouldFetchAndUpdateCustomerIfItIsAlreadySet(): vo
     public function handleResponseShouldFetchAndUpdatePayPageIfItIsAlreadySet(): void
     {
         $payment = (new Payment())->setId('myPaymentId');
-        $payPage = (new Paypage(0,'',''))->setId('payPageId');
+        $payPage = (new Paypage(0, '', ''))->setId('payPageId');
 
         $resourceServiceMock = $this->getMockBuilder(ResourceService::class)
             ->disableOriginalConstructor()->setMethods(['fetchResource'])->getMock();

test/unit/Resources/TransactionTypes/AbstractTransactionTypeTest.php

@@ -29,6 +29,7 @@
 use PHPUnit\Framework\MockObject\MockObject;
 use stdClass;
 use UnzerSDK\Adapter\HttpAdapterInterface;
+use UnzerSDK\Constants\LiabilityShiftIndicator;
 use UnzerSDK\Constants\TransactionStatus;
 use UnzerSDK\Resources\Payment;
 use UnzerSDK\Resources\TransactionTypes\AbstractTransactionType;
@@ -268,6 +269,24 @@ public function fetchPaymentShouldFetchPaymentObject(): void
         $transactionType->fetchPayment();
     }
 
+    /**
+     * Liability indicator response should stored in transaction
+     *
+     * @test
+     */
+    public function liabilityResponseShouldBeStroedInTransaction()
+    {
+        $jsonRespone = '{"additionalTransactionData":{"card":{"liability":"MERCHANT"}}}';
+
+        $transaction = new DummyTransactionType();
+        $transaction->handleResponse(json_decode($jsonRespone, false));
+        $this->assertEquals($transaction->getAdditionalTransactionData()->card->liability, LiabilityShiftIndicator::MERCHANT);
+
+        $jsonRespone = '{"additionalTransactionData":{"card":{"liability":"ISSUER"}}}';
+        $transaction->handleResponse(json_decode($jsonRespone, false));
+        $this->assertEquals($transaction->getAdditionalTransactionData()->card->liability, LiabilityShiftIndicator::ISSUER);
+    }
+
     //<editor-fold desc="Data Providers">
 
     /**