Merge pull request #89 from unzerdev/UMCS-383/qa_changes

UMCS-383(change) UPL example: Adjust text regarding transaction refer…

Author: Ryouzanpaku

examples/Success.php

@@ -46,7 +46,9 @@
 
             $shortId = $_SESSION['ShortId'] ?? null;
             if ($shortId !== null) {
-                echo '<p>Please look for ShortId ' . $shortId . ' in Unzer Insights to see the transaction.</p>';
+                $defaultTransactionMessage = '<p>Please look for ShortId ' . $shortId . ' in Unzer Insights to see the transaction.</p>';
+                $paylaterTransactionMessage = '<p>Please use the "descriptor" to look for the transaction in the Unzer Pay Later Merchant Portal.</p>';
+                echo preg_match('/[\d]{4}.[\d]{4}.[\d]{4}/', $shortId) ? $defaultTransactionMessage : $paylaterTransactionMessage;
             }
             $paymentId = $_SESSION['PaymentId'] ?? null;
             if ($paymentId !== null) {
@@ -73,7 +75,7 @@
                                 <input type="hidden" name="payment_id" value="' . $paymentId . ' ">
                                 <div class="fields inline">
                                     <div class="field">
-                                        <button class="unzerUI primary button fluid" id="submit-button" type="submit">Charge payment.</button>
+                                        <button class="unzerUI primary button fluid" id="submit-button" type="submit">Charge payment</button>
                                     </div>
                                 </div>
                             </form>';

test/integration/BasketV2Test.php

@@ -28,7 +28,6 @@
 use UnzerSDK\Exceptions\UnzerApiException;
 use UnzerSDK\Resources\Basket;
 use UnzerSDK\Resources\EmbeddedResources\BasketItem;
-use UnzerSDK\Resources\PaymentTypes\Invoice;
 use UnzerSDK\Resources\PaymentTypes\Paypal;
 use UnzerSDK\Resources\PaymentTypes\SepaDirectDebit;
 use UnzerSDK\test\BaseIntegrationTest;
@@ -58,8 +57,6 @@ public function minV2BasketShouldBeCreatableAndFetchable(): void
         $this->unzer->createBasket($basket);
         $this->assertNotEmpty($basket->getId());
 
-        $invoice = new Invoice();
-        $invoice->setParentResource($this->unzer)->charge(100, 'EUR', 'https://unzer.com', null, 'orderId', null, $basket);
         $fetchedBasket = $this->unzer->fetchBasket($basket->getId())->setOrderId('');
         $this->assertEquals($basket->expose(), $fetchedBasket->expose());
     }
@@ -87,8 +84,6 @@ public function BasketShouldBeCreatableAndFetchable(): void
         $this->unzer->createBasket($basket);
         $this->assertNotEmpty($basket->getId());
 
-        $invoice = new Invoice();
-        $invoice->setParentResource($this->unzer)->charge(100, 'EUR', 'https://unzer.com', null, 'orderId', null, $basket);
         $fetchedBasket = $this->unzer->fetchBasket($basket->getId());
         $this->assertEquals($basket->expose(), $fetchedBasket->expose());
     }

test/integration/PaymentCancelTest.php

@@ -27,6 +27,7 @@
 use UnzerSDK\Constants\CancelReasonCodes;
 use UnzerSDK\Resources\PaymentTypes\Invoice;
 use UnzerSDK\Resources\PaymentTypes\InvoiceSecured;
+use UnzerSDK\Services\EnvironmentService;
 use UnzerSDK\test\BaseIntegrationTest;
 
 class PaymentCancelTest extends BaseIntegrationTest
@@ -344,6 +345,7 @@ public function partCancelOnPartlyChargedAuthorizeWithAmountGtCharged(): void
      */
     public function fullCancelOnInitialInvoiceCharge($amount): void
     {
+        $this->unzer->setKey(EnvironmentService::getTestPrivateKey(true));
         /** @var Invoice $invoice */
         $invoice = $this->unzer->createPaymentType(new Invoice());
         $charge = $invoice->charge(100.0, 'EUR', self::RETURN_URL);
@@ -364,6 +366,7 @@ public function fullCancelOnInitialInvoiceCharge($amount): void
      */
     public function partCancelOnInitialInvoiceChargeShouldBePossible(): void
     {
+        $this->unzer->setKey(EnvironmentService::getTestPrivateKey(true));
         /** @var Invoice $invoice */
         $invoice = $this->unzer->createPaymentType(new Invoice());
         $charge = $invoice->charge(100.0, 'EUR', self::RETURN_URL);

test/integration/PaymentTypes/InvoiceTest.php

@@ -27,10 +27,16 @@
 use UnzerSDK\Constants\ApiResponseCodes;
 use UnzerSDK\Exceptions\UnzerApiException;
 use UnzerSDK\Resources\PaymentTypes\Invoice;
+use UnzerSDK\Services\EnvironmentService;
 use UnzerSDK\test\BaseIntegrationTest;
 
 class InvoiceTest extends BaseIntegrationTest
 {
+    protected function setUp(): void
+    {
+        $this->getUnzerObject(EnvironmentService::getTestPrivateKey(true));
+    }
+
     /**
      * Verifies invoice payment type can be created.
      *