ci: clean up github actions & add build checks for phoenix

Abstract testing & linting code out to a separate file to reduce code
duplication with the phoenix build workflow. Additionally add cargo deny
checks.

Author: mk-rw

.github/workflows/argus-build.yml

@@ -4,40 +4,19 @@ on:
     branches: [main]
   pull_request:
     paths:
-      - ".github/workflows/argus/**"
       - "boards/argus/**"
       - "common/**" # because argus has some dependencies on common
   workflow_dispatch:
 name: Build Verification
 
 jobs:
-  lint:
-    name: Check for Formatting/Linting/Semantic Issues
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v2
-
-      - name: Setup Rust Environment (Cached)
-        uses: ./.github/actions/common/setup-rust-environment/
-
-      - name: Install Formatting Dependencies
-        run: |
-          cargo install cargo-sort
-          rustup component add rustfmt clippy
-        working-directory: boards/argus
-
-      - name: Check Formatting
-        run: cargo fmt -- --check
-        working-directory: boards/argus
-
-      - name: Check Cargo.toml Sorting
-        run: cargo sort --check
-        working-directory: boards/argus
-
-      - name: Check for Clippy Warnings
-        run: cargo clippy -p argus --features temperature --no-deps
-        working-directory: boards/argus
+  checks:
+    uses: ./.github/workflows/build.yml
+    with:
+      crate-name: argus
+      crate-path: boards/argus
+      # TODO: Checks for the other types of board (might benefit from use of matrices)
+      default-features: temperature
 
   build_pressure:
     name: Build with Pressure Feature
@@ -48,9 +27,9 @@ jobs:
 
       - name: Setup Rust Environment (Cached)
         uses: ./.github/actions/common/setup-rust-environment/
-# TODO: --target thumbv7em-none-eabihf should not be needed as it should be using workspace target. Look into
+
       - name: "Build with Pressure Feature"
-        run: cargo build --release --features pressure --target thumbv7em-none-eabihf
+        run: cargo build --release --features pressure 
         working-directory: boards/argus
 
   build_temperature:
@@ -64,7 +43,7 @@ jobs:
         uses: ./.github/actions/common/setup-rust-environment/
 
       - name: "Build with Temperature Feature"
-        run: cargo build --release --features temperature --target thumbv7em-none-eabihf
+        run: cargo build --release --features temperature
         working-directory: boards/argus
 
   build_strain:
@@ -78,23 +57,5 @@ jobs:
         uses: ./.github/actions/common/setup-rust-environment/
 
       - name: "Build with Strain Feature"
-        run: cargo build --release --features strain --target thumbv7em-none-eabihf
+        run: cargo build --release --features strain
         working-directory: boards/argus
-
-  test:
-    name: Run Host Tests
-    runs-on: ubuntu-latest
-    env:
-      RUST_MIN_STACK: 8388608
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v2
-
-      - name: Setup Rust Environment (Cached)
-        uses: ./.github/actions/common/setup-rust-environment/
-
-      - uses: actions-rs/cargo@v1
-        name: "Run Host Tests"
-        with:
-          command: make
-          args: test-host

.github/workflows/build.yml

@@ -0,0 +1,68 @@
+on:
+  workflow_call:
+    inputs:
+      crate-name:
+        required: true
+        type: string
+      crate-path:
+        required: true
+        type: string
+      default-features:
+        required: false
+        type: string
+
+jobs:
+  lint:
+    name: Check for Formatting/Linting/Semantic Issues
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Setup Rust Environment (Cached)
+        uses: ./.github/actions/common/setup-rust-environment/
+
+      - name: Install Formatting Dependencies
+        run: |
+          cargo install cargo-sort cargo-deny
+          rustup component add rustfmt clippy
+        working-directory: $crate-path
+
+      - name: Check Formatting
+        run: cargo fmt -- --check
+        working-directory: $crate-path
+
+      - name: Check Cargo.toml Sorting
+        run: cargo sort --check
+        working-directory: $crate-path
+
+      - name: Check for Clippy Warnings
+        run: cargo clippy -p $crate-name --features $default-features --no-deps
+        working-directory: $crate-path
+
+      - name: Check for Crate Duplication
+        run: cargo deny check bans
+        working-directory: $crate-path
+
+      - name: Check for Advisories
+        run: cargo deny check advisories
+        working-directory: $crate-path
+
+    test:
+      name: Run Host Tests
+      runs-on: ubuntu-latest
+      env:
+        # NOTE: Unsure why this is here
+        RUST_MIN_STACK: 8388608
+      steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Setup Rust Environment (Cached)
+        uses: ./.github/actions/common/setup-rust-environment/
+
+        name: "Run Host Tests"
+      - uses: actions-rs/cargo@v1
+        with:
+          command: make
+          args: test-host

.github/workflows/phoenix-build.yml

@@ -0,0 +1,31 @@
+on:
+  push:
+    branches: [main]
+  pull_request:
+    paths:
+      - "boards/phoenix/**"
+      - "common/**" # because phoenix has some dependencies on common
+  workflow_dispatch:
+name: Build Verification
+
+jobs:
+  checks:
+    uses: ./.github/workflow/build.yml
+    with:
+      crate-name: phoenix
+      crate-path: boards/phoenix
+      default-features: music
+
+  build:
+    name: Build Phoenix (All Features)
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Setup Rust Environment (Cached)
+        uses: ./.github/actions/common/setup-rust-environment/
+
+      - name: Build
+        run: cargo build --release --features pressure
+        working-directory: boards/phoenix