Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update type of actor field in the session #4

Open
chungquantin opened this issue Jan 24, 2025 · 0 comments
Open

refactor: update type of actor field in the session #4

chungquantin opened this issue Jan 24, 2025 · 0 comments

Comments

@chungquantin
Copy link

actor field in Session is no longer used in the main logic of the session with the introduction of Revive. Reason for that is all internal logic of the drink library requires the RuntimeOrigin type. Hence, the actor field is only used in the get_actor method. However, as the method is used by the developers to debug the current actor, it would be best to return AccountId instead of RuntimeOrigin.
@chungquantin chungquantin changed the title refactor: deprecate actor field in the session refactor: update type of actor field in the session Jan 24, 2025
@chungquantin chungquantin mentioned this issue Jan 24, 2025
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chungquantin